was initially created using clang-tidy:
clang-tidy -checks="-*,moderize-use-default" -fix
However, the resulting patch only wanted to alter the
definitions in the .cpp file. I think it makes more
sense to remove the definitions completely and just
add "= default" to the declarations in the header file.
16 files changed:
namespace pv {
namespace data {
namespace pv {
namespace data {
-SignalData::SignalData()
-{
-}
-
} // namespace data
} // namespace pv
} // namespace data
} // namespace pv
class SignalData
{
public:
class SignalData
{
public:
+ SignalData() = default;
virtual ~SignalData() {}
public:
virtual ~SignalData() {}
public:
driver_scan(entry.second, map<const ConfigKey *, VariantBase>());
}
driver_scan(entry.second, map<const ConfigKey *, VariantBase>());
}
-DeviceManager::~DeviceManager()
-{
-}
-
const std::shared_ptr<sigrok::Context>& DeviceManager::context() const
{
return context_;
const std::shared_ptr<sigrok::Context>& DeviceManager::context() const
{
return context_;
public:
DeviceManager(std::shared_ptr<sigrok::Context> context);
public:
DeviceManager(std::shared_ptr<sigrok::Context> context);
+ ~DeviceManager() = default;
const std::shared_ptr<sigrok::Context>& context() const;
const std::shared_ptr<sigrok::Context>& context() const;
QWidget* Bool::get_widget(QWidget *parent, bool auto_commit)
{
if (check_box_)
QWidget* Bool::get_widget(QWidget *parent, bool auto_commit)
{
if (check_box_)
public:
Bool(QString name, Getter getter, Setter setter);
public:
Bool(QString name, Getter getter, Setter setter);
+ virtual ~Bool() = default;
QWidget* get_widget(QWidget *parent, bool auto_commit);
bool labeled_widget() const;
QWidget* get_widget(QWidget *parent, bool auto_commit);
bool labeled_widget() const;
-Double::~Double()
-{
-}
-
QWidget* Double::get_widget(QWidget *parent, bool auto_commit)
{
if (spin_box_)
QWidget* Double::get_widget(QWidget *parent, bool auto_commit)
{
if (spin_box_)
Getter getter,
Setter setter);
Getter getter,
Setter setter);
+ virtual ~Double() = default;
QWidget* get_widget(QWidget *parent, bool auto_commit);
QWidget* get_widget(QWidget *parent, bool auto_commit);
QWidget* Enum::get_widget(QWidget *parent, bool auto_commit)
{
if (selector_)
QWidget* Enum::get_widget(QWidget *parent, bool auto_commit)
{
if (selector_)
Enum(QString name, std::vector<std::pair<Glib::VariantBase, QString> > values,
Getter getter, Setter setter);
Enum(QString name, std::vector<std::pair<Glib::VariantBase, QString> > values,
Getter getter, Setter setter);
+ virtual ~Enum() = default;
QWidget* get_widget(QWidget *parent, bool auto_commit);
QWidget* get_widget(QWidget *parent, bool auto_commit);
QWidget* Int::get_widget(QWidget *parent, bool auto_commit)
{
int64_t int_val = 0, range_min = 0;
QWidget* Int::get_widget(QWidget *parent, bool auto_commit)
{
int64_t int_val = 0, range_min = 0;
boost::optional< std::pair<int64_t, int64_t> > range,
Getter getter, Setter setter);
boost::optional< std::pair<int64_t, int64_t> > range,
Getter getter, Setter setter);
+ virtual ~Int() = default;
QWidget* get_widget(QWidget *parent, bool auto_commit);
QWidget* get_widget(QWidget *parent, bool auto_commit);
set_colour(SignalColours[channel_->index() % countof(SignalColours)]);
}
set_colour(SignalColours[channel_->index() % countof(SignalColours)]);
}
-AnalogSignal::~AnalogSignal()
-{
-}
-
shared_ptr<pv::data::SignalData> AnalogSignal::data() const
{
return data_;
shared_ptr<pv::data::SignalData> AnalogSignal::data() const
{
return data_;
std::shared_ptr<sigrok::Channel> channel,
std::shared_ptr<pv::data::Analog> data);
std::shared_ptr<sigrok::Channel> channel,
std::shared_ptr<pv::data::Analog> data);
- virtual ~AnalogSignal();
+ virtual ~AnalogSignal() = default;
std::shared_ptr<pv::data::SignalData> data() const;
std::shared_ptr<pv::data::SignalData> data() const;
trigger_match_ = match->type();
}
trigger_match_ = match->type();
}
-LogicSignal::~LogicSignal()
-{
-}
-
shared_ptr<pv::data::SignalData> LogicSignal::data() const
{
return data_;
shared_ptr<pv::data::SignalData> LogicSignal::data() const
{
return data_;
std::shared_ptr<sigrok::Channel> channel,
std::shared_ptr<pv::data::Logic> data);
std::shared_ptr<sigrok::Channel> channel,
std::shared_ptr<pv::data::Logic> data);
- virtual ~LogicSignal();
+ virtual ~LogicSignal() = default;
std::shared_ptr<pv::data::SignalData> data() const;
std::shared_ptr<pv::data::SignalData> data() const;