a5d0a5987774436e178b0e3f250ce46633538d7d
[pulseview.git] / pv / views / trace / logicsignal.cpp
1 /*
2  * This file is part of the PulseView project.
3  *
4  * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, see <http://www.gnu.org/licenses/>.
18  */
19
20 #include <extdef.h>
21
22 #include <cassert>
23 #include <cmath>
24
25 #include <algorithm>
26
27 #include <QApplication>
28 #include <QFormLayout>
29 #include <QToolBar>
30
31 #include "logicsignal.hpp"
32 #include "view.hpp"
33
34 #include <pv/data/logic.hpp>
35 #include <pv/data/logicsegment.hpp>
36 #include <pv/data/signalbase.hpp>
37 #include <pv/devicemanager.hpp>
38 #include <pv/devices/device.hpp>
39 #include <pv/globalsettings.hpp>
40 #include <pv/session.hpp>
41
42 #include <libsigrokcxx/libsigrokcxx.hpp>
43
44 using std::deque;
45 using std::max;
46 using std::make_pair;
47 using std::min;
48 using std::none_of;
49 using std::out_of_range;
50 using std::pair;
51 using std::shared_ptr;
52 using std::vector;
53
54 using sigrok::ConfigKey;
55 using sigrok::Capability;
56 using sigrok::Trigger;
57 using sigrok::TriggerMatch;
58 using sigrok::TriggerMatchType;
59
60 using pv::data::LogicSegment;
61
62 namespace pv {
63 namespace views {
64 namespace trace {
65
66 const float LogicSignal::Oversampling = 2.0f;
67
68 const QColor LogicSignal::EdgeColor(0x80, 0x80, 0x80);
69 const QColor LogicSignal::HighColor(0x00, 0xC0, 0x00);
70 const QColor LogicSignal::LowColor(0xC0, 0x00, 0x00);
71 const QColor LogicSignal::SamplingPointColor(0x77, 0x77, 0x77);
72
73 const QColor LogicSignal::SignalColors[10] = {
74         QColor(0x16, 0x19, 0x1A),       // Black
75         QColor(0x8F, 0x52, 0x02),       // Brown
76         QColor(0xCC, 0x00, 0x00),       // Red
77         QColor(0xF5, 0x79, 0x00),       // Orange
78         QColor(0xED, 0xD4, 0x00),       // Yellow
79         QColor(0x73, 0xD2, 0x16),       // Green
80         QColor(0x34, 0x65, 0xA4),       // Blue
81         QColor(0x75, 0x50, 0x7B),       // Violet
82         QColor(0x88, 0x8A, 0x85),       // Grey
83         QColor(0xEE, 0xEE, 0xEC),       // White
84 };
85
86 QColor LogicSignal::TriggerMarkerBackgroundColor = QColor(0xED, 0xD4, 0x00);
87 const int LogicSignal::TriggerMarkerPadding = 2;
88 const char* LogicSignal::TriggerMarkerIcons[8] = {
89         nullptr,
90         ":/icons/trigger-marker-low.svg",
91         ":/icons/trigger-marker-high.svg",
92         ":/icons/trigger-marker-rising.svg",
93         ":/icons/trigger-marker-falling.svg",
94         ":/icons/trigger-marker-change.svg",
95         nullptr,
96         nullptr
97 };
98
99 QCache<QString, const QIcon> LogicSignal::icon_cache_;
100 QCache<QString, const QPixmap> LogicSignal::pixmap_cache_;
101
102 LogicSignal::LogicSignal(
103         pv::Session &session,
104         shared_ptr<devices::Device> device,
105         shared_ptr<data::SignalBase> base) :
106         Signal(session, base),
107         device_(device),
108         trigger_types_(get_trigger_types()),
109         trigger_none_(nullptr),
110         trigger_rising_(nullptr),
111         trigger_high_(nullptr),
112         trigger_falling_(nullptr),
113         trigger_low_(nullptr),
114         trigger_change_(nullptr)
115 {
116         shared_ptr<Trigger> trigger;
117
118         base_->set_color(SignalColors[base->index() % countof(SignalColors)]);
119
120         GlobalSettings gs;
121         signal_height_ = gs.value(GlobalSettings::Key_View_DefaultLogicHeight).toInt();
122
123         /* Populate this channel's trigger setting with whatever we
124          * find in the current session trigger, if anything. */
125         trigger_match_ = nullptr;
126         if ((trigger = session_.session()->trigger()))
127                 for (auto stage : trigger->stages())
128                         for (auto match : stage->matches())
129                                 if (match->channel() == base_->channel())
130                                         trigger_match_ = match->type();
131 }
132
133 shared_ptr<pv::data::SignalData> LogicSignal::data() const
134 {
135         return base_->logic_data();
136 }
137
138 shared_ptr<pv::data::Logic> LogicSignal::logic_data() const
139 {
140         return base_->logic_data();
141 }
142
143 void LogicSignal::save_settings(QSettings &settings) const
144 {
145         settings.setValue("trace_height", signal_height_);
146 }
147
148 void LogicSignal::restore_settings(QSettings &settings)
149 {
150         if (settings.contains("trace_height")) {
151                 const int old_height = signal_height_;
152                 signal_height_ = settings.value("trace_height").toInt();
153
154                 if ((signal_height_ != old_height) && owner_) {
155                         // Call order is important, otherwise the lazy event handler won't work
156                         owner_->extents_changed(false, true);
157                         owner_->row_item_appearance_changed(false, true);
158                 }
159         }
160 }
161
162 pair<int, int> LogicSignal::v_extents() const
163 {
164         const int signal_margin =
165                 QFontMetrics(QApplication::font()).height() / 2;
166         return make_pair(-signal_height_ - signal_margin, signal_margin);
167 }
168
169 void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp)
170 {
171         QLineF *line;
172
173         vector< pair<int64_t, bool> > edges;
174
175         assert(base_);
176         assert(owner_);
177
178         const int y = get_visual_y();
179
180         if (!base_->enabled())
181                 return;
182
183         const float low_offset = y + 0.5f;
184         const float high_offset = low_offset - signal_height_;
185
186         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
187         if (!segment || (segment->get_sample_count() == 0))
188                 return;
189
190         double samplerate = segment->samplerate();
191
192         // Show sample rate as 1Hz when it is unknown
193         if (samplerate == 0.0)
194                 samplerate = 1.0;
195
196         const double pixels_offset = pp.pixels_offset();
197         const pv::util::Timestamp& start_time = segment->start_time();
198         const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
199         const double samples_per_pixel = samplerate * pp.scale();
200         const double pixels_per_sample = 1 / samples_per_pixel;
201         const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
202         const pv::util::Timestamp end = start + samples_per_pixel * pp.width();
203
204         const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
205                 (int64_t)0), last_sample);
206         const uint64_t end_sample = min(max(ceil(end).convert_to<int64_t>(),
207                 (int64_t)0), last_sample);
208
209         segment->get_subsampled_edges(edges, start_sample, end_sample,
210                 samples_per_pixel / Oversampling, base_->index());
211         assert(edges.size() >= 2);
212
213         const float first_sample_x =
214                 pp.left() + (edges.front().first / samples_per_pixel - pixels_offset);
215         const float last_sample_x =
216                 pp.left() + (edges.back().first / samples_per_pixel - pixels_offset);
217
218         // Check whether we need to paint the sampling points
219         GlobalSettings settings;
220         const bool show_sampling_points =
221                 settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool() &&
222                 (samples_per_pixel < 0.25);
223
224         vector<QRectF> sampling_points;
225         float sampling_point_x = first_sample_x;
226         int64_t sampling_point_sample = start_sample;
227         const int w = 2;
228
229         if (show_sampling_points)
230                 sampling_points.reserve(end_sample - start_sample + 1);
231
232         // Check whether we need to fill the high areas
233         const bool fill_high_areas =
234                 settings.value(GlobalSettings::Key_View_FillSignalHighAreas).toBool();
235         vector<QRectF> high_rects;
236         float rising_edge_x;
237         bool rising_edge_seen = false;
238
239         // Paint the edges
240         const unsigned int edge_count = edges.size() - 2;
241         QLineF *const edge_lines = new QLineF[edge_count];
242         line = edge_lines;
243
244         if (edges.front().second) {
245                 // Beginning of trace is high
246                 rising_edge_x = first_sample_x;
247                 rising_edge_seen = true;
248         }
249
250         for (auto i = edges.cbegin() + 1; i != edges.cend() - 1; i++) {
251                 // Note: multiple edges occupying a single pixel are represented by an edge
252                 // with undefined logic level. This means that only the first falling edge
253                 // after a rising edge corresponds to said rising edge - and vice versa. If
254                 // more edges with the same logic level follow, they denote multiple edges.
255
256                 const float x = pp.left() + ((*i).first / samples_per_pixel - pixels_offset);
257                 *line++ = QLineF(x, high_offset, x, low_offset);
258
259                 if (fill_high_areas) {
260                         // Any edge terminates a high area
261                         if (rising_edge_seen) {
262                                 const int width = x - rising_edge_x;
263                                 if (width > 0)
264                                         high_rects.emplace_back(rising_edge_x, high_offset,
265                                                 width, signal_height_);
266                                 rising_edge_seen = false;
267                         }
268
269                         // Only rising edges start high areas
270                         if ((*i).second) {
271                                 rising_edge_x = x;
272                                 rising_edge_seen = true;
273                         }
274                 }
275
276                 if (show_sampling_points)
277                         while (sampling_point_sample < (*i).first) {
278                                 const float y = (*i).second ? low_offset : high_offset;
279                                 sampling_points.emplace_back(
280                                         QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
281                                 sampling_point_sample++;
282                                 sampling_point_x += pixels_per_sample;
283                         };
284         }
285
286         // Calculate the sample points from the last edge to the end of the trace
287         if (show_sampling_points)
288                 while ((uint64_t)sampling_point_sample <= end_sample) {
289                         // Signal changed after the last edge, so the level is inverted
290                         const float y = (edges.cend() - 1)->second ? high_offset : low_offset;
291                         sampling_points.emplace_back(
292                                 QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
293                         sampling_point_sample++;
294                         sampling_point_x += pixels_per_sample;
295                 };
296
297         if (fill_high_areas) {
298                 // Add last high rectangle if the signal is still high at the end of the trace
299                 if (rising_edge_seen && (edges.cend() - 1)->second)
300                         high_rects.emplace_back(rising_edge_x, high_offset,
301                                 last_sample_x - rising_edge_x, signal_height_);
302
303                 const QColor fill_color = QColor::fromRgba(settings.value(
304                         GlobalSettings::Key_View_FillSignalHighAreaColor).value<uint32_t>());
305                 p.setPen(fill_color);
306                 p.setBrush(fill_color);
307                 p.drawRects((const QRectF*)(high_rects.data()), high_rects.size());
308         }
309
310         p.setPen(EdgeColor);
311         p.drawLines(edge_lines, edge_count);
312         delete[] edge_lines;
313
314         // Paint the caps
315         const unsigned int max_cap_line_count = edges.size();
316         QLineF *const cap_lines = new QLineF[max_cap_line_count];
317
318         p.setPen(HighColor);
319         paint_caps(p, cap_lines, edges, true, samples_per_pixel,
320                 pixels_offset, pp.left(), high_offset);
321         p.setPen(LowColor);
322         paint_caps(p, cap_lines, edges, false, samples_per_pixel,
323                 pixels_offset, pp.left(), low_offset);
324
325         delete[] cap_lines;
326
327         // Paint the sampling points
328         if (show_sampling_points) {
329                 p.setPen(SamplingPointColor);
330                 p.drawRects(sampling_points.data(), sampling_points.size());
331         }
332 }
333
334 void LogicSignal::paint_fore(QPainter &p, ViewItemPaintParams &pp)
335 {
336         if (base_->enabled()) {
337                 if (trigger_match_) {
338                         // Draw the trigger marker
339                         const int y = get_visual_y();
340
341                         for (int32_t type_id : trigger_types_) {
342                                 const TriggerMatchType *const type =
343                                         TriggerMatchType::get(type_id);
344                                 if (trigger_match_ != type || type_id < 0 ||
345                                         (size_t)type_id >= countof(TriggerMarkerIcons) ||
346                                         !TriggerMarkerIcons[type_id])
347                                         continue;
348
349                                 const QPixmap *const pixmap = get_pixmap(
350                                         TriggerMarkerIcons[type_id]);
351                                 if (!pixmap)
352                                         continue;
353
354                                 const float pad = TriggerMarkerPadding - 0.5f;
355                                 const QSize size = pixmap->size();
356                                 const QPoint point(
357                                         pp.right() - size.width() - pad * 2,
358                                         y - (signal_height_ + size.height()) / 2);
359
360                                 p.setPen(QPen(TriggerMarkerBackgroundColor.darker()));
361                                 p.setBrush(TriggerMarkerBackgroundColor);
362                                 p.drawRoundedRect(QRectF(point, size).adjusted(
363                                         -pad, -pad, pad, pad), pad, pad);
364                                 p.drawPixmap(point, *pixmap);
365
366                                 break;
367                         }
368                 }
369
370                 if (show_hover_marker_)
371                         paint_hover_marker(p);
372         }
373 }
374
375 vector<LogicSegment::EdgePair> LogicSignal::get_nearest_level_changes(uint64_t sample_pos)
376 {
377         assert(base_);
378         assert(owner_);
379
380         if (sample_pos == 0)
381                 return vector<LogicSegment::EdgePair>();
382
383         shared_ptr<LogicSegment> segment = get_logic_segment_to_paint();
384         if (!segment || (segment->get_sample_count() == 0))
385                 return vector<LogicSegment::EdgePair>();
386
387         const View *view = owner_->view();
388         assert(view);
389         const double samples_per_pixel = base_->get_samplerate() * view->scale();
390
391         vector<LogicSegment::EdgePair> edges;
392
393         segment->get_surrounding_edges(edges, sample_pos,
394                 samples_per_pixel / Oversampling, base_->index());
395
396         if (edges.empty())
397                 return vector<LogicSegment::EdgePair>();
398
399         return edges;
400 }
401
402 void LogicSignal::paint_caps(QPainter &p, QLineF *const lines,
403         vector< pair<int64_t, bool> > &edges, bool level,
404         double samples_per_pixel, double pixels_offset, float x_offset,
405         float y_offset)
406 {
407         QLineF *line = lines;
408
409         for (auto i = edges.begin(); i != (edges.end() - 1); i++)
410                 if ((*i).second == level) {
411                         *line++ = QLineF(
412                                 ((*i).first / samples_per_pixel -
413                                         pixels_offset) + x_offset, y_offset,
414                                 ((*(i+1)).first / samples_per_pixel -
415                                         pixels_offset) + x_offset, y_offset);
416                 }
417
418         p.drawLines(lines, line - lines);
419 }
420
421 shared_ptr<pv::data::LogicSegment> LogicSignal::get_logic_segment_to_paint() const
422 {
423         shared_ptr<pv::data::LogicSegment> segment;
424
425         const deque< shared_ptr<pv::data::LogicSegment> > &segments =
426                 base_->logic_data()->logic_segments();
427
428         if (!segments.empty()) {
429                 if (segment_display_mode_ == ShowLastSegmentOnly) {
430                         segment = segments.back();
431                 }
432
433         if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
434                 (segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
435                         try {
436                                 segment = segments.at(current_segment_);
437                         } catch (out_of_range&) {
438                                 qDebug() << "Current logic segment out of range for signal" << base_->name() << ":" << current_segment_;
439                         }
440                 }
441         }
442
443         return segment;
444 }
445
446 void LogicSignal::init_trigger_actions(QWidget *parent)
447 {
448         trigger_none_ = new QAction(*get_icon(":/icons/trigger-none.svg"),
449                 tr("No trigger"), parent);
450         trigger_none_->setCheckable(true);
451         connect(trigger_none_, SIGNAL(triggered()), this, SLOT(on_trigger()));
452
453         trigger_rising_ = new QAction(*get_icon(":/icons/trigger-rising.svg"),
454                 tr("Trigger on rising edge"), parent);
455         trigger_rising_->setCheckable(true);
456         connect(trigger_rising_, SIGNAL(triggered()), this, SLOT(on_trigger()));
457
458         trigger_high_ = new QAction(*get_icon(":/icons/trigger-high.svg"),
459                 tr("Trigger on high level"), parent);
460         trigger_high_->setCheckable(true);
461         connect(trigger_high_, SIGNAL(triggered()), this, SLOT(on_trigger()));
462
463         trigger_falling_ = new QAction(*get_icon(":/icons/trigger-falling.svg"),
464                 tr("Trigger on falling edge"), parent);
465         trigger_falling_->setCheckable(true);
466         connect(trigger_falling_, SIGNAL(triggered()), this, SLOT(on_trigger()));
467
468         trigger_low_ = new QAction(*get_icon(":/icons/trigger-low.svg"),
469                 tr("Trigger on low level"), parent);
470         trigger_low_->setCheckable(true);
471         connect(trigger_low_, SIGNAL(triggered()), this, SLOT(on_trigger()));
472
473         trigger_change_ = new QAction(*get_icon(":/icons/trigger-change.svg"),
474                 tr("Trigger on rising or falling edge"), parent);
475         trigger_change_->setCheckable(true);
476         connect(trigger_change_, SIGNAL(triggered()), this, SLOT(on_trigger()));
477 }
478
479 const vector<int32_t> LogicSignal::get_trigger_types() const
480 {
481         // We may not be associated with a device
482         if (!device_)
483                 return vector<int32_t>();
484
485         const auto sr_dev = device_->device();
486         if (sr_dev->config_check(ConfigKey::TRIGGER_MATCH, Capability::LIST)) {
487                 const Glib::VariantContainerBase gvar =
488                         sr_dev->config_list(ConfigKey::TRIGGER_MATCH);
489
490                 vector<int32_t> ttypes;
491
492                 for (unsigned int i = 0; i < gvar.get_n_children(); i++) {
493                         Glib::VariantBase tmp_vb;
494                         gvar.get_child(tmp_vb, i);
495
496                         Glib::Variant<int32_t> tmp_v =
497                                 Glib::VariantBase::cast_dynamic< Glib::Variant<int32_t> >(tmp_vb);
498
499                         ttypes.push_back(tmp_v.get());
500                 }
501
502                 return ttypes;
503         } else {
504                 return vector<int32_t>();
505         }
506 }
507
508 QAction* LogicSignal::action_from_trigger_type(const TriggerMatchType *type)
509 {
510         QAction *action;
511
512         action = trigger_none_;
513         if (type) {
514                 switch (type->id()) {
515                 case SR_TRIGGER_ZERO:
516                         action = trigger_low_;
517                         break;
518                 case SR_TRIGGER_ONE:
519                         action = trigger_high_;
520                         break;
521                 case SR_TRIGGER_RISING:
522                         action = trigger_rising_;
523                         break;
524                 case SR_TRIGGER_FALLING:
525                         action = trigger_falling_;
526                         break;
527                 case SR_TRIGGER_EDGE:
528                         action = trigger_change_;
529                         break;
530                 default:
531                         assert(false);
532                 }
533         }
534
535         return action;
536 }
537
538 const TriggerMatchType *LogicSignal::trigger_type_from_action(QAction *action)
539 {
540         if (action == trigger_low_)
541                 return TriggerMatchType::ZERO;
542         else if (action == trigger_high_)
543                 return TriggerMatchType::ONE;
544         else if (action == trigger_rising_)
545                 return TriggerMatchType::RISING;
546         else if (action == trigger_falling_)
547                 return TriggerMatchType::FALLING;
548         else if (action == trigger_change_)
549                 return TriggerMatchType::EDGE;
550         else
551                 return nullptr;
552 }
553
554 void LogicSignal::populate_popup_form(QWidget *parent, QFormLayout *form)
555 {
556         Signal::populate_popup_form(parent, form);
557
558         signal_height_sb_ = new QSpinBox(parent);
559         signal_height_sb_->setRange(5, 1000);
560         signal_height_sb_->setSingleStep(5);
561         signal_height_sb_->setSuffix(tr(" pixels"));
562         signal_height_sb_->setValue(signal_height_);
563         connect(signal_height_sb_, SIGNAL(valueChanged(int)),
564                 this, SLOT(on_signal_height_changed(int)));
565         form->addRow(tr("Trace height"), signal_height_sb_);
566
567         // Trigger settings
568         const vector<int32_t> trig_types = get_trigger_types();
569
570         if (!trig_types.empty()) {
571                 trigger_bar_ = new QToolBar(parent);
572                 init_trigger_actions(trigger_bar_);
573                 trigger_bar_->addAction(trigger_none_);
574                 trigger_none_->setChecked(!trigger_match_);
575
576                 for (auto type_id : trig_types) {
577                         const TriggerMatchType *const type =
578                                 TriggerMatchType::get(type_id);
579                         QAction *const action = action_from_trigger_type(type);
580                         trigger_bar_->addAction(action);
581                         action->setChecked(trigger_match_ == type);
582                 }
583
584                 // Only allow triggers to be changed when we're stopped
585                 if (session_.get_capture_state() != Session::Stopped)
586                         for (QAction* action : trigger_bar_->findChildren<QAction*>())
587                                 action->setEnabled(false);
588
589                 form->addRow(tr("Trigger"), trigger_bar_);
590         }
591 }
592
593 void LogicSignal::modify_trigger()
594 {
595         auto trigger = session_.session()->trigger();
596         auto new_trigger = session_.device_manager().context()->create_trigger("pulseview");
597
598         if (trigger) {
599                 for (auto stage : trigger->stages()) {
600                         const auto &matches = stage->matches();
601                         if (none_of(matches.begin(), matches.end(),
602                             [&](shared_ptr<TriggerMatch> match) {
603                                         return match->channel() != base_->channel(); }))
604                                 continue;
605
606                         auto new_stage = new_trigger->add_stage();
607                         for (auto match : stage->matches()) {
608                                 if (match->channel() == base_->channel())
609                                         continue;
610                                 new_stage->add_match(match->channel(), match->type());
611                         }
612                 }
613         }
614
615         if (trigger_match_) {
616                 // Until we can let the user decide how to group trigger matches
617                 // into stages, put all of the matches into a single stage --
618                 // most devices only support a single trigger stage.
619                 if (new_trigger->stages().empty())
620                         new_trigger->add_stage();
621
622                 new_trigger->stages().back()->add_match(base_->channel(),
623                         trigger_match_);
624         }
625
626         session_.session()->set_trigger(
627                 new_trigger->stages().empty() ? nullptr : new_trigger);
628
629         if (owner_)
630                 owner_->row_item_appearance_changed(false, true);
631 }
632
633 const QIcon* LogicSignal::get_icon(const char *path)
634 {
635         if (!icon_cache_.contains(path)) {
636                 const QIcon *icon = new QIcon(path);
637                 icon_cache_.insert(path, icon);
638         }
639
640         return icon_cache_.take(path);
641 }
642
643 const QPixmap* LogicSignal::get_pixmap(const char *path)
644 {
645         if (!pixmap_cache_.contains(path)) {
646                 const QPixmap *pixmap = new QPixmap(path);
647                 pixmap_cache_.insert(path, pixmap);
648         }
649
650         return pixmap_cache_.take(path);
651 }
652
653 void LogicSignal::on_trigger()
654 {
655         QAction *action;
656
657         action_from_trigger_type(trigger_match_)->setChecked(false);
658
659         action = (QAction *)sender();
660         action->setChecked(true);
661         trigger_match_ = trigger_type_from_action(action);
662
663         modify_trigger();
664 }
665
666 void LogicSignal::on_signal_height_changed(int height)
667 {
668         signal_height_ = height;
669
670         if (owner_) {
671                 // Call order is important, otherwise the lazy event handler won't work
672                 owner_->extents_changed(false, true);
673                 owner_->row_item_appearance_changed(false, true);
674         }
675 }
676
677 } // namespace trace
678 } // namespace views
679 } // namespace pv