From: Tilman Sauerbeck <tilman@code-monkey.de>
Date: Mon, 1 Jan 2018 10:58:56 +0000 (+0100)
Subject: Use strdup() in Client_textmessage().
X-Git-Url: http://git.code-monkey.de/?p=umurmur.git;a=commitdiff_plain;h=d9280fa11ed4cb6cc0f36394c5d57350464973b3

Use strdup() in Client_textmessage().

This is more efficient than the combination of malloc(), strlen() and
strcpy() that we used before.
---

diff --git a/src/client.c b/src/client.c
index d61de2b..5b76b7e 100644
--- a/src/client.c
+++ b/src/client.c
@@ -670,14 +670,18 @@ void Client_textmessage(client_t *client, char *text)
 	uint32_t *tree_id;
 	message_t *sendmsg = NULL;
 
-	message = Memory_safeMalloc(1, strlen(text) + 1);
+	message = strdup(text);
+
+	if (message == NULL)
+		Log_fatal("Out of memory");
+
 	tree_id = Memory_safeMalloc(1, sizeof(uint32_t));
 	*tree_id = 0;
 	sendmsg = Msg_create(TextMessage);
 	sendmsg->payload.textMessage->message = message;
 	sendmsg->payload.textMessage->n_tree_id = 1;
 	sendmsg->payload.textMessage->tree_id = tree_id;
-	strcpy(message, text);
+
 	Client_send_message(client, sendmsg);
 }