From f20bab80ca655b5b65a5d0d8660d2265a2410b00 Mon Sep 17 00:00:00 2001 From: Tilman Sauerbeck Date: Thu, 17 Aug 2006 21:26:48 +0200 Subject: [PATCH] Made Ogg::Vorbis::Tagger#close return nil. --- ext/ext.c | 8 +++++--- test/test_main.rb | 5 ++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ext/ext.c b/ext/ext.c index 6a45359..46ce0d1 100644 --- a/ext/ext.c +++ b/ext/ext.c @@ -142,9 +142,11 @@ c_init (VALUE self, VALUE filename) /* * call-seq: - * object.close -> object + * object.close -> nil * - * Closes *object* and returns it. + * Closes *object*. Further method calls on *object* will raise an + * Ogg::Vorbis::Tagger::ClosedStreamError exception. + * Returns +nil+. */ static VALUE c_close (VALUE self) @@ -158,7 +160,7 @@ c_close (VALUE self) vcedit_state_unref (o->state); o->state = NULL; - return self; + return Qnil; } /* diff --git a/test/test_main.rb b/test/test_main.rb index 3b57719..6355e7e 100644 --- a/test/test_main.rb +++ b/test/test_main.rb @@ -254,8 +254,11 @@ EOF end def test_close2 + t = Ogg::Vorbis::Tagger.new(OGG_FILE) + t.close + assert_raise(Ogg::Vorbis::Tagger::ClosedStreamError) do - Ogg::Vorbis::Tagger.new(OGG_FILE).close.close + t.close end assert_raise(Ogg::Vorbis::Tagger::ClosedStreamError) do -- 2.30.2