Made Ogg::Vorbis::Tagger#close return nil.
authorTilman Sauerbeck <tilman@code-monkey.de>
Thu, 17 Aug 2006 19:26:48 +0000 (21:26 +0200)
committerTilman Sauerbeck <tilman@code-monkey.de>
Wed, 23 Aug 2006 17:39:15 +0000 (19:39 +0200)
ext/ext.c
test/test_main.rb

index 6a45359772e325ff0ca6c75f8a265917cb77df76..46ce0d178d1090296f6a74b16e29b205e692c706 100644 (file)
--- a/ext/ext.c
+++ b/ext/ext.c
@@ -142,9 +142,11 @@ c_init (VALUE self, VALUE filename)
 
 /*
  * call-seq:
- *  object.close -> object
+ *  object.close -> nil
  *
- * Closes *object* and returns it.
+ * Closes *object*. Further method calls on *object* will raise an
+ * Ogg::Vorbis::Tagger::ClosedStreamError exception.
+ * Returns +nil+.
  */
 static VALUE
 c_close (VALUE self)
@@ -158,7 +160,7 @@ c_close (VALUE self)
        vcedit_state_unref (o->state);
        o->state = NULL;
 
-       return self;
+       return Qnil;
 }
 
 /*
index 3b577196032c72dff3769a74edb109588e2ef82c..6355e7e9d23fca663d55283d059b51f427a71804 100644 (file)
@@ -254,8 +254,11 @@ EOF
        end
 
        def test_close2
+               t = Ogg::Vorbis::Tagger.new(OGG_FILE)
+               t.close
+
                assert_raise(Ogg::Vorbis::Tagger::ClosedStreamError) do
-                       Ogg::Vorbis::Tagger.new(OGG_FILE).close.close
+                       t.close
                end
 
                assert_raise(Ogg::Vorbis::Tagger::ClosedStreamError) do