Code cleanup.

[ruby-eet.git] / ext / ext.c

diff --git a/ext/ext.c b/ext/ext.c
index 1e9d21f1b22a0332a42283dcc4de788fa1f89945..938720af2a68d56e97f6cab75f0d206f74a437e9 100644 (file)
--- a/ext/ext.c
+++ b/ext/ext.c
@@ -1,5 +1,5 @@
 /*
- * $Id: ext.c 36 2005-05-11 17:19:38Z tilman $
+ * $Id: ext.c 48 2005-05-30 19:20:42Z tilman $
  *
  * Copyright (c) 2005 Tilman Sauerbeck (tilman at code-monkey de)
  *
@@ -44,7 +44,7 @@
 
 static VALUE c_close (VALUE self);
 
-static VALUE id_include;
+static ID id_include, id_tag, id_data;
 
 static void
 c_free (Eet_File **ef)
@@ -454,6 +454,30 @@ stream_serialize (VALUE self)
        return ret;
 }
 
+static VALUE
+chunk_init (VALUE self, VALUE tag, VALUE data)
+{
+       unsigned long len;
+
+       StringValue (tag);
+       StringValue (data);
+
+       if (rb_funcall (tag, id_include, 1, INT2FIX (0)) == Qtrue) \
+               rb_raise (rb_eArgError, "tag must not contain binary zeroes");
+
+       /* libeet uses a signed 32bit integer to store the
+        * chunk size, so make sure we don't overflow it
+        */
+       len = RSTRING (tag)->len + 1 + RSTRING (data)->len;
+       if (len < 0 || len >= 2147483647L)
+               rb_raise (rb_eArgError, "tag or data too long");
+
+       rb_ivar_set (self, id_tag, rb_str_dup_frozen (tag));
+       rb_ivar_set (self, id_data, rb_str_dup_frozen (data));
+
+       return self;
+}
+
 static VALUE
 chunk_serialize (VALUE self)
 {
@@ -461,13 +485,6 @@ chunk_serialize (VALUE self)
        unsigned int size, buf_len;
        unsigned char *buf;
        struct RString *tag, *data;
-       static ID id_tag, id_data;
-
-       if (!id_tag)
-               id_tag = rb_intern ("@tag");
-
-       if (!id_data)
-               id_data = rb_intern ("@data");
 
        tmp = rb_ivar_get (self, id_tag);
        StringValue (tmp);
@@ -504,7 +521,7 @@ chunk_serialize (VALUE self)
 void
 Init_eet_ext ()
 {
-       VALUE m, c;
+       VALUE m, c, cs, cc;
 
        m = rb_define_module ("Eet");
 
@@ -520,11 +537,17 @@ Init_eet_ext ()
        rb_define_method (c, "read_image", c_read_image, 1);
        rb_define_method (c, "write_image", c_write_image, -1);
 
-       c = rb_define_class_under (m, "Stream", rb_cArray);
-       rb_define_method (c, "serialize", stream_serialize, 0);
+       cs = rb_define_class_under (m, "Stream", rb_cArray);
+       rb_define_method (cs, "serialize", stream_serialize, 0);
+
+       cc = rb_define_class_under (m, "Chunk", rb_cObject);
+       rb_define_method (cc, "initialize", chunk_init, 2);
+       rb_define_method (cc, "serialize", chunk_serialize, 0);
 
-       c = rb_define_class_under (m, "Chunk", rb_cObject);
-       rb_define_method (c, "serialize", chunk_serialize, 0);
+       rb_define_attr (cc, "tag", 1, 0);
+       rb_define_attr (cc, "data", 1, 0);
 
        id_include = rb_intern ("include?");
+       id_tag = rb_intern ("@tag");
+       id_data = rb_intern ("@data");
 }