X-Git-Url: http://git.code-monkey.de/?p=ruby-ecore.git;a=blobdiff_plain;f=src%2Fecore_job%2Frb_job.c;h=5c4ff46c00cc55620c414ac9abacb77b28c8ce95;hp=e0b1691054f4dcc2ab36ec5855cadc6cd0c53e3d;hb=d907bd016f15dc5be72d12ee1742047eafc2abae;hpb=98ce45a70b8b219b738bb804297417aae0ae9baa

diff --git a/src/ecore_job/rb_job.c b/src/ecore_job/rb_job.c
index e0b1691..5c4ff46 100644
--- a/src/ecore_job/rb_job.c
+++ b/src/ecore_job/rb_job.c
@@ -1,7 +1,7 @@
 /*
- * $Id: rb_job.c 27 2004-07-08 18:25:05Z tilman $
+ * $Id: rb_job.c 351 2006-02-10 15:25:40Z tilman $
  *
- * Copyright (C) 2004 Tilman Sauerbeck (tilman at code-monkey de)
+ * Copyright (C) 2004 ruby-ecore team (see AUTHORS)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -27,62 +27,83 @@
 #include "rb_ecore_job.h"
 
 typedef struct {
-	Ecore_Job *job;
-	void *cb;
+	Ecore_Job *real;
+	VALUE callback;
 	bool deleted;
-} RbEcoreJob;
-
-static VALUE cJob;
+} RbJob;
 
 static void on_job (void *data)
 {
-	RbEcoreJob *job = data;
+	RbJob *job = data;
 
-	rb_funcall ((VALUE) job->cb, rb_intern ("call"), 0);
+	rb_funcall (job->callback, rb_intern ("call"), 0);
 	job->deleted = true;
 }
 
-static void c_free (RbEcoreJob *job)
+static void c_mark (RbJob *job)
 {
-	if (job->job && !job->deleted)
-		ecore_job_del (job->job);
+	rb_gc_mark (job->callback);
+}
+
+static void c_free (RbJob *job)
+{
+	if (job->real && !job->deleted)
+		ecore_job_del (job->real);
 
 	ecore_shutdown ();
 
 	free (job);
 }
 
-static VALUE c_new (VALUE klass)
+static VALUE c_alloc (VALUE klass)
 {
-	VALUE self;
-	RbEcoreJob *job;
+	RbJob *job = NULL;
 
-	if (!rb_block_given_p ())
-		return Qnil;
+	ecore_init ();
 
-	self = Data_Make_Struct (klass, RbEcoreJob, NULL, c_free, job);
+	return Data_Make_Struct (klass, RbJob, c_mark, c_free, job);
+}
 
-	ecore_init ();
+/*
+ * call-seq:
+ *  Ecore::Job::Job.new { block } => job
+ *
+ * Creates an Ecore::Job::Job object.
+ * After execution, the object will be deleted.
+ */
+static VALUE c_init (VALUE self)
+{
+	RbJob *job = NULL;
+
+	if (!rb_block_given_p ())
+		rb_raise (rb_eStandardError, "block missing");
 
-	job->cb = (void *) rb_block_proc ();
-	job->job = ecore_job_add (on_job, job);
+	Data_Get_Struct (self, RbJob, job);
 
-	rb_obj_call_init (self, 0, NULL);
+	job->callback = rb_block_proc ();
+	job->deleted = false;
+	job->real = ecore_job_add (on_job, job);
 
 	return self;
 }
 
+/*
+ * call-seq:
+ *  job.delete => nil
+ *
+ * Deletes <i>job</i>.
+ */
 static VALUE c_delete (VALUE self)
 {
 	VALUE ret = Qfalse;
-	RbEcoreJob *job = NULL;
+	RbJob *job = NULL;
 
-	Data_Get_Struct (self, RbEcoreJob, job);
+	Data_Get_Struct (self, RbJob, job);
 
-	if (job->job && !job->deleted) {
-		ecore_job_del (job->job);
+	if (job->real && !job->deleted) {
+		ecore_job_del (job->real);
 		job->deleted = true;
-		job->job = NULL;
+		job->real = NULL;
 		ret = Qtrue;
 	}
 
@@ -91,9 +112,9 @@ static VALUE c_delete (VALUE self)
 
 void Init_Job (void)
 {
-	cJob = rb_define_class_under (mJob, "Job", rb_cObject);
+	VALUE c = rb_define_class_under (mJob, "Job", rb_cObject);
 
-	rb_define_singleton_method (cJob, "new", c_new, 0);
-	rb_define_method (cJob, "delete", c_delete, 0);
+	rb_define_alloc_func (c, c_alloc);
+	rb_define_method (c, "initialize", c_init, 0);
+	rb_define_method (c, "delete", c_delete, 0);
 }
-