From d2d0056dc4ff51ae814b136ff92c3458dfae27d3 Mon Sep 17 00:00:00 2001 From: Soeren Apel Date: Sun, 14 Oct 2018 22:56:08 +0200 Subject: [PATCH] Implement fixes proposed by clang-tidy --- pv/application.cpp | 4 ++-- pv/dialogs/settings.cpp | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/pv/application.cpp b/pv/application.cpp index 1bc844a..f588fa3 100644 --- a/pv/application.cpp +++ b/pv/application.cpp @@ -115,14 +115,14 @@ void Application::collect_version_info(shared_ptr context) // Firmware paths l_orig = sr_resourcepaths_get(SR_RESOURCE_FIRMWARE); for (GSList *l = l_orig; l; l = l->next) - fw_path_list_.push_back(QString((char*)l->data)); + fw_path_list_.emplace_back((char*)l->data); g_slist_free_full(l_orig, g_free); // PD paths #ifdef ENABLE_DECODE l_orig = srd_searchpaths_get(); for (GSList *l = l_orig; l; l = l->next) - pd_path_list_.push_back(QString((char*)l->data)); + pd_path_list_.emplace_back((char*)l->data); g_slist_free_full(l_orig, g_free); #endif diff --git a/pv/dialogs/settings.cpp b/pv/dialogs/settings.cpp index 0795879..d17f5d0 100644 --- a/pv/dialogs/settings.cpp +++ b/pv/dialogs/settings.cpp @@ -54,7 +54,6 @@ #include #endif -using std::shared_ptr; using pv::widgets::ColorButton; namespace pv { -- 2.30.2