From b9a3a67e4bb39b769ac580d8d2f76eef6458f5d6 Mon Sep 17 00:00:00 2001 From: Soeren Apel Date: Thu, 14 Jun 2018 17:41:02 +0200 Subject: [PATCH] Prevent log length to be set to 0 Doing so prevents PV from starting up, so disallow it --- pv/dialogs/settings.cpp | 1 + pv/logging.cpp | 1 + pv/logging.hpp | 1 + 3 files changed, 3 insertions(+) diff --git a/pv/dialogs/settings.cpp b/pv/dialogs/settings.cpp index 04565a3..5b33272 100644 --- a/pv/dialogs/settings.cpp +++ b/pv/dialogs/settings.cpp @@ -493,6 +493,7 @@ QWidget *Settings::get_logging_page(QWidget *parent) const // Background buffer size QSpinBox *buffersize_sb = new QSpinBox(); buffersize_sb->setSuffix(tr(" lines")); + buffersize_sb->setMinimum(Logging::MIN_BUFFER_SIZE); buffersize_sb->setMaximum(Logging::MAX_BUFFER_SIZE); buffersize_sb->setValue( settings.value(GlobalSettings::Key_Log_BufferSize).toInt()); diff --git a/pv/logging.cpp b/pv/logging.cpp index ab0594c..dea333e 100644 --- a/pv/logging.cpp +++ b/pv/logging.cpp @@ -34,6 +34,7 @@ namespace pv { Logging logging; +const int Logging::MIN_BUFFER_SIZE = 10; const int Logging::MAX_BUFFER_SIZE = 50000; Logging::~Logging() diff --git a/pv/logging.hpp b/pv/logging.hpp index fe05c54..28f2107 100644 --- a/pv/logging.hpp +++ b/pv/logging.hpp @@ -44,6 +44,7 @@ public: LogSource_srd }; + static const int MIN_BUFFER_SIZE; static const int MAX_BUFFER_SIZE; public: -- 2.30.2