Trace: Remove unneeded setters
authorSoeren Apel <soeren@apelpie.net>
Fri, 13 Apr 2018 07:27:38 +0000 (09:27 +0200)
committerSoeren Apel <soeren@apelpie.net>
Sun, 15 Apr 2018 06:20:00 +0000 (08:20 +0200)
pv/views/trace/signal.cpp
pv/views/trace/trace.cpp
pv/views/trace/trace.hpp

index e6c2594f82dabd50b25f5211339c97bbadb56e73..d9a7a0841a78b99dc806868e55ebf3198a1cc870 100644 (file)
@@ -72,7 +72,7 @@ Signal::Signal(pv::Session &session,
 
 void Signal::set_name(QString name)
 {
-       Trace::set_name(name);
+       base_->set_name(name);
 
        if (name != name_widget_->currentText())
                name_widget_->setEditText(name);
index cc91fff5a5aa43de401ec6b64cc4f1cc48d61090..0e15480022c9d83cc82a397b449c490bfd65bc30 100644 (file)
@@ -244,16 +244,6 @@ void Trace::populate_popup_form(QWidget *parent, QFormLayout *form)
        add_color_option(parent, form);
 }
 
-void Trace::set_name(QString name)
-{
-       base_->set_name(name);
-}
-
-void Trace::set_color(QColor color)
-{
-       base_->set_color(color);
-}
-
 void Trace::set_segment_display_mode(SegmentDisplayMode mode)
 {
        segment_display_mode_ = mode;
@@ -291,13 +281,13 @@ void Trace::on_popup_closed()
 void Trace::on_nameedit_changed(const QString &name)
 {
        /* This event handler notifies SignalBase that the name changed */
-       set_name(name);
+       base_->set_name(name);
 }
 
 void Trace::on_coloredit_changed(const QColor &color)
 {
        /* This event handler notifies SignalBase that the color changed */
-       set_color(color);
+       base_->set_color(color);
 }
 
 } // namespace trace
index a9ccd7b7c4bd1b581d2b245821054466d2edf036..410d82cd14e8c9121e9a758024dee4c5d540204f 100644 (file)
@@ -100,16 +100,6 @@ public:
         */
        shared_ptr<data::SignalBase> base() const;
 
-       /**
-        * Sets the name of the signal.
-        */
-       virtual void set_name(QString name);
-
-       /**
-        * Set the color of the signal.
-        */
-       virtual void set_color(QColor color);
-
        /**
         * Configures the segment display mode to use.
         */