X-Git-Url: http://git.code-monkey.de/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fviews%2Ftrace%2Flogicsignal.cpp;h=f9ab16f102cdf5328613d81957a5d4563602d07e;hp=438e4e21c1f6a6c639543897cb65f35362e9a746;hb=3b2ead4fbeb899188564ec9c69c216708311a881;hpb=b4bc9b55381ff22196785291d3862c8c8c131885 diff --git a/pv/views/trace/logicsignal.cpp b/pv/views/trace/logicsignal.cpp index 438e4e2..f9ab16f 100644 --- a/pv/views/trace/logicsignal.cpp +++ b/pv/views/trace/logicsignal.cpp @@ -57,6 +57,8 @@ using sigrok::Trigger; using sigrok::TriggerMatch; using sigrok::TriggerMatchType; +using pv::data::LogicSegment; + namespace pv { namespace views { namespace trace { @@ -115,8 +117,14 @@ LogicSignal::LogicSignal( base_->set_color(SignalColors[base->index() % countof(SignalColors)]); - GlobalSettings gs; - signal_height_ = gs.value(GlobalSettings::Key_View_DefaultLogicHeight).toInt(); + GlobalSettings settings; + signal_height_ = settings.value(GlobalSettings::Key_View_DefaultLogicHeight).toInt(); + show_sampling_points_ = + settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool(); + fill_high_areas_ = + settings.value(GlobalSettings::Key_View_FillSignalHighAreas).toBool(); + high_fill_color_ = QColor::fromRgba(settings.value( + GlobalSettings::Key_View_FillSignalHighAreaColor).value()); /* Populate this channel's trigger setting with whatever we * find in the current session trigger, if anything. */ @@ -178,10 +186,10 @@ void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp) if (!base_->enabled()) return; - const float high_offset = y - signal_height_ + 0.5f; const float low_offset = y + 0.5f; + const float high_offset = low_offset - signal_height_; - shared_ptr segment = get_logic_segment_to_paint(); + shared_ptr segment = get_logic_segment_to_paint(); if (!segment || (segment->get_sample_count() == 0)) return; @@ -208,32 +216,62 @@ void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp) samples_per_pixel / Oversampling, base_->index()); assert(edges.size() >= 2); - // Check whether we need to paint the sampling points - GlobalSettings settings; - const bool show_sampling_points = - settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool() && - (samples_per_pixel < 0.25); + const float first_sample_x = + pp.left() + (edges.front().first / samples_per_pixel - pixels_offset); + const float last_sample_x = + pp.left() + (edges.back().first / samples_per_pixel - pixels_offset); + // Check whether we need to paint the sampling points + const bool show_sampling_points = show_sampling_points_ && (samples_per_pixel < 0.25); vector sampling_points; - float sampling_point_x = 0.0f; + float sampling_point_x = first_sample_x; int64_t sampling_point_sample = start_sample; const int w = 2; - if (show_sampling_points) { + if (show_sampling_points) sampling_points.reserve(end_sample - start_sample + 1); - sampling_point_x = (edges.cbegin()->first / samples_per_pixel - pixels_offset) + pp.left(); - } + + vector high_rects; + float rising_edge_x; + bool rising_edge_seen = false; // Paint the edges const unsigned int edge_count = edges.size() - 2; QLineF *const edge_lines = new QLineF[edge_count]; line = edge_lines; + if (edges.front().second) { + // Beginning of trace is high + rising_edge_x = first_sample_x; + rising_edge_seen = true; + } + for (auto i = edges.cbegin() + 1; i != edges.cend() - 1; i++) { - const float x = ((*i).first / samples_per_pixel - - pixels_offset) + pp.left(); + // Note: multiple edges occupying a single pixel are represented by an edge + // with undefined logic level. This means that only the first falling edge + // after a rising edge corresponds to said rising edge - and vice versa. If + // more edges with the same logic level follow, they denote multiple edges. + + const float x = pp.left() + ((*i).first / samples_per_pixel - pixels_offset); *line++ = QLineF(x, high_offset, x, low_offset); + if (fill_high_areas_) { + // Any edge terminates a high area + if (rising_edge_seen) { + const int width = x - rising_edge_x; + if (width > 0) + high_rects.emplace_back(rising_edge_x, high_offset, + width, signal_height_); + rising_edge_seen = false; + } + + // Only rising edges start high areas + if ((*i).second) { + rising_edge_x = x; + rising_edge_seen = true; + } + } + if (show_sampling_points) while (sampling_point_sample < (*i).first) { const float y = (*i).second ? low_offset : high_offset; @@ -255,6 +293,17 @@ void LogicSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp) sampling_point_x += pixels_per_sample; }; + if (fill_high_areas_) { + // Add last high rectangle if the signal is still high at the end of the trace + if (rising_edge_seen && (edges.cend() - 1)->second) + high_rects.emplace_back(rising_edge_x, high_offset, + last_sample_x - rising_edge_x, signal_height_); + + p.setPen(high_fill_color_); + p.setBrush(high_fill_color_); + p.drawRects((const QRectF*)(high_rects.data()), high_rects.size()); + } + p.setPen(EdgeColor); p.drawLines(edge_lines, edge_count); delete[] edge_lines; @@ -320,49 +369,31 @@ void LogicSignal::paint_fore(QPainter &p, ViewItemPaintParams &pp) } } -void LogicSignal::hover_point_changed(const QPoint &hp) +vector LogicSignal::get_nearest_level_changes(uint64_t sample_pos) { - Signal::hover_point_changed(hp); - assert(base_); assert(owner_); - if ((!base_->enabled()) || (hp.x() == 0)) - return; + if (sample_pos == 0) + return vector(); - // Ignore if mouse cursor is not hovering over this trace - const int y = get_visual_y(); - const pair extents = v_extents(); - if ((hp.y() < (y + extents.first)) || ((hp.y() > (y + extents.second)))) - return; - - shared_ptr segment = get_logic_segment_to_paint(); + shared_ptr segment = get_logic_segment_to_paint(); if (!segment || (segment->get_sample_count() == 0)) - return; - - double samplerate = segment->samplerate(); - - // Show sample rate as 1Hz when it is unknown - if (samplerate == 0.0) - samplerate = 1.0; + return vector(); const View *view = owner_->view(); assert(view); - const double scale = view->scale(); - const double pixels_offset = - ((view->offset() - segment->start_time()) / scale).convert_to(); - const double samples_per_pixel = samplerate * scale; - - const uint64_t sample_pos = (uint64_t)max( - (hp.x() + pixels_offset) * samples_per_pixel, 0.0); + const double samples_per_pixel = base_->get_samplerate() * view->scale(); - vector edges; + vector edges; segment->get_surrounding_edges(edges, sample_pos, samples_per_pixel / Oversampling, base_->index()); if (edges.empty()) - return; + return vector(); + + return edges; } void LogicSignal::paint_caps(QPainter &p, QLineF *const lines, @@ -549,7 +580,7 @@ void LogicSignal::populate_popup_form(QWidget *parent, QFormLayout *form) // Only allow triggers to be changed when we're stopped if (session_.get_capture_state() != Session::Stopped) - for (QAction* action : trigger_bar_->findChildren()) + for (QAction* action : trigger_bar_->findChildren()) // clazy:exclude=range-loop action->setEnabled(false); form->addRow(tr("Trigger"), trigger_bar_); @@ -616,6 +647,20 @@ const QPixmap* LogicSignal::get_pixmap(const char *path) return pixmap_cache_.take(path); } +void LogicSignal::on_setting_changed(const QString &key, const QVariant &value) +{ + Signal::on_setting_changed(key, value); + + if (key == GlobalSettings::Key_View_ShowSamplingPoints) + show_sampling_points_ = value.toBool(); + + if (key == GlobalSettings::Key_View_FillSignalHighAreas) + fill_high_areas_ = value.toBool(); + + if (key == GlobalSettings::Key_View_FillSignalHighAreaColor) + high_fill_color_ = QColor::fromRgba(value.value()); +} + void LogicSignal::on_trigger() { QAction *action;