X-Git-Url: http://git.code-monkey.de/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fviews%2Ftrace%2Fheader.cpp;h=1e97521afd7d7b41481eb1b259fc5e8df3e770bf;hp=c5510fcb40c44a8c6cf3ad4631736b51fac061ea;hb=af33d4cbacc745f4473f5c0f4fa1f9ebb8d84d0a;hpb=9e773fecf2d4ab8f2fc6e1cc880b9102c22ec228 diff --git a/pv/views/trace/header.cpp b/pv/views/trace/header.cpp index c5510fc..1e97521 100644 --- a/pv/views/trace/header.cpp +++ b/pv/views/trace/header.cpp @@ -99,16 +99,16 @@ void Header::paintEvent(QPaintEvent*) { const QRect rect(0, 0, width(), height()); - vector< shared_ptr > items(view_.list_by_type()); + vector< shared_ptr > items(view_.list_by_type()); stable_sort(items.begin(), items.end(), - [](const shared_ptr &a, const shared_ptr &b) { + [](const shared_ptr &a, const shared_ptr &b) { return a->drag_point(QRect()).y() < b->drag_point(QRect()).y(); }); QPainter painter(this); painter.setRenderHint(QPainter::Antialiasing); - for (const shared_ptr r : items) { + for (const shared_ptr& r : items) { assert(r); const bool highlight = !item_dragging_ && @@ -142,7 +142,7 @@ void Header::contextMenuEvent(QContextMenuEvent *event) menu->addAction(group); } - menu->exec(event->globalPos()); + menu->popup(event->globalPos()); } void Header::keyPressEvent(QKeyEvent *event) @@ -201,7 +201,7 @@ void Header::on_ungroup() restart = false; const vector< shared_ptr > groups( view_.list_by_type()); - for (const shared_ptr tg : groups) + for (const shared_ptr& tg : groups) if (tg->selected()) { tg->ungroup(); restart = true;