X-Git-Url: http://git.code-monkey.de/?p=pulseview.git;a=blobdiff_plain;f=pv%2Ftoolbars%2Fsamplingbar.cpp;h=778f7aa1cdf747a74d00995da7d051e5a1ba7deb;hp=24c5a420e1782ce0834b172ecdaa60c0e6782d88;hb=488f068c7ecdc101820a3c48be61fb45a7e683dc;hpb=aca00b1e0d3483926c53dfd856483a397f1c29a5 diff --git a/pv/toolbars/samplingbar.cpp b/pv/toolbars/samplingbar.cpp index 24c5a42..778f7aa 100644 --- a/pv/toolbars/samplingbar.cpp +++ b/pv/toolbars/samplingbar.cpp @@ -33,8 +33,9 @@ #include #include +#include -using namespace std; +using std::string; namespace pv { namespace toolbars { @@ -68,9 +69,12 @@ SamplingBar::SamplingBar(SigSession &session, QWidget *parent) : QToolBar("Sampling Bar", parent), _session(session), _device_selector(this), + _updating_device_selector(false), _configure_button(this), + _configure_button_action(NULL), _probes_button(this), _record_length_selector(this), + _sample_rate_action(NULL), _sample_rate_list(this), _icon_red(":/icons/status-red.svg"), _icon_green(":/icons/status-green.svg"), @@ -89,7 +93,7 @@ SamplingBar::SamplingBar(SigSession &session, QWidget *parent) : { const uint64_t &l = RecordLengths[i]; char *const text = sr_si_string_u64(l, " samples"); - _record_length_selector.addItem(QString(text), + _record_length_selector.addItem(QString::fromUtf8(text), qVariantFromValue(l)); g_free(text); @@ -101,13 +105,14 @@ SamplingBar::SamplingBar(SigSession &session, QWidget *parent) : _configure_button.setIcon(QIcon::fromTheme("configure", QIcon(":/icons/configure.png"))); + _probes_button.setIcon(QIcon::fromTheme("probes", QIcon(":/icons/probes.svg"))); _run_stop_button.setToolButtonStyle(Qt::ToolButtonTextBesideIcon); addWidget(&_device_selector); - addWidget(&_configure_button); + _configure_button_action = addWidget(&_configure_button); addWidget(&_probes_button); addWidget(&_record_length_selector); _sample_rate_list_action = addWidget(&_sample_rate_list); @@ -123,6 +128,8 @@ SamplingBar::SamplingBar(SigSession &session, QWidget *parent) : void SamplingBar::set_device_list( const std::list &devices) { + _updating_device_selector = true; + _device_selector.clear(); BOOST_FOREACH (sr_dev_inst *sdi, devices) { @@ -131,7 +138,9 @@ void SamplingBar::set_device_list( qVariantFromValue((void*)sdi)); } - update_sample_rate_selector(); + _updating_device_selector = false; + + on_device_selected(); } struct sr_dev_inst* SamplingBar::get_selected_device() const @@ -176,7 +185,6 @@ void SamplingBar::update_sample_rate_selector() GVariant *gvar_dict, *gvar_list; const uint64_t *elements = NULL; gsize num_elements; - QAction *selector_action = NULL; assert(_sample_rate_value_action); assert(_sample_rate_list_action); @@ -184,8 +192,8 @@ void SamplingBar::update_sample_rate_selector() if (!sdi) return; - if (sr_config_list(sdi->driver, SR_CONF_SAMPLERATE, - &gvar_dict, sdi) != SR_OK) + if (sr_config_list(sdi->driver, sdi, NULL, + SR_CONF_SAMPLERATE, &gvar_dict) != SR_OK) return; _sample_rate_list_action->setVisible(false); @@ -199,7 +207,7 @@ void SamplingBar::update_sample_rate_selector() _sample_rate_value.setSingleStep(elements[2]); g_variant_unref(gvar_list); - selector_action = _sample_rate_value_action; + _sample_rate_action = _sample_rate_value_action; } else if ((gvar_list = g_variant_lookup_value(gvar_dict, "samplerates", G_VARIANT_TYPE("at")))) @@ -211,7 +219,7 @@ void SamplingBar::update_sample_rate_selector() for (unsigned int i = 0; i < num_elements; i++) { char *const s = sr_samplerate_string(elements[i]); - _sample_rate_list.addItem(QString(s), + _sample_rate_list.addItem(QString::fromUtf8(s), qVariantFromValue(elements[i])); g_free(s); } @@ -219,7 +227,7 @@ void SamplingBar::update_sample_rate_selector() _sample_rate_list.show(); g_variant_unref(gvar_list); - selector_action = _sample_rate_list_action; + _sample_rate_action = _sample_rate_list_action; } g_variant_unref(gvar_dict); @@ -227,8 +235,8 @@ void SamplingBar::update_sample_rate_selector() // We delay showing the action, so that value change events // are ignored. - if (selector_action) - selector_action->setVisible(true); + if (_sample_rate_action) + _sample_rate_action->setVisible(true); } void SamplingBar::update_sample_rate_selector_value() @@ -239,8 +247,8 @@ void SamplingBar::update_sample_rate_selector_value() assert(sdi); - if (sr_config_get(sdi->driver, SR_CONF_SAMPLERATE, - &gvar, sdi) != SR_OK) { + if (sr_config_get(sdi->driver, sdi, NULL, + SR_CONF_SAMPLERATE, &gvar) != SR_OK) { qDebug() << "WARNING: Failed to get value of sample rate"; return; @@ -251,9 +259,9 @@ void SamplingBar::update_sample_rate_selector_value() assert(_sample_rate_value_action); assert(_sample_rate_list_action); - if (_sample_rate_value_action->isVisible()) + if (_sample_rate_action == _sample_rate_value_action) _sample_rate_value.setValue(samplerate); - else if (_sample_rate_list_action->isVisible()) + else if (_sample_rate_action == _sample_rate_list_action) { for (int i = 0; i < _sample_rate_list.count(); i++) if (samplerate == _sample_rate_list.itemData( @@ -272,9 +280,9 @@ void SamplingBar::commit_sample_rate() assert(_sample_rate_value_action); assert(_sample_rate_list_action); - if (_sample_rate_value_action->isVisible()) + if (_sample_rate_action == _sample_rate_value_action) sample_rate = (uint64_t)_sample_rate_value.value(); - else if (_sample_rate_list_action->isVisible()) + else if (_sample_rate_action == _sample_rate_list_action) { const int index = _sample_rate_list.currentIndex(); if (index >= 0) @@ -286,7 +294,7 @@ void SamplingBar::commit_sample_rate() return; // Set the samplerate - if (sr_config_set(sdi, SR_CONF_SAMPLERATE, + if (sr_config_set(sdi, NULL, SR_CONF_SAMPLERATE, g_variant_new_uint64(sample_rate)) != SR_OK) { qDebug() << "Failed to configure samplerate."; return; @@ -297,13 +305,23 @@ void SamplingBar::on_device_selected() { using namespace pv::popups; + if (_updating_device_selector) + return; + update_sample_rate_selector(); sr_dev_inst *const sdi = get_selected_device(); _session.set_device(sdi); - _configure_button.set_popup(new DeviceOptions(sdi, this)); - _probes_button.set_popup(new Probes(_session, this)); + // Update the configure popup + DeviceOptions *const opts = new DeviceOptions(sdi, this); + _configure_button_action->setVisible( + !opts->binding().properties().empty()); + _configure_button.set_popup(opts); + + // Update the probes popup + Probes *const probes = new Probes(_session, this); + _probes_button.set_popup(probes); } void SamplingBar::on_sample_rate_changed()