X-Git-Url: http://git.code-monkey.de/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fstoresession.cpp;h=c2135ab3383564b007c70c3484d0d59155b4eaeb;hp=16665369be2b9a2bf7b6d53d5ef66a6ef5c617c0;hb=6f925ba9d6faf1077b73c5a5808259576081716a;hpb=47e9e7bbc3a4e91a960f4cbb1db48c5aff6dcace
diff --git a/pv/storesession.cpp b/pv/storesession.cpp
index 1666536..c2135ab 100644
--- a/pv/storesession.cpp
+++ b/pv/storesession.cpp
@@ -14,8 +14,7 @@
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ * along with this program; if not, see .
*/
#include
@@ -56,7 +55,6 @@ using std::pair;
using std::set;
using std::shared_ptr;
using std::string;
-using std::thread;
using std::unordered_set;
using std::vector;
@@ -70,12 +68,12 @@ using sigrok::OutputFlag;
namespace pv {
-const size_t StoreSession::BlockSize = 1024 * 1024;
+const size_t StoreSession::BlockSize = 10 * 1024 * 1024;
-StoreSession::StoreSession(const std::string &file_name,
+StoreSession::StoreSession(const string &file_name,
const shared_ptr &output_format,
const map &options,
- const std::pair sample_range,
+ const pair sample_range,
const Session &session) :
file_name_(file_name),
output_format_(output_format),
@@ -218,10 +216,6 @@ void StoreSession::store_proc(vector< shared_ptr > achannel_li
{
unsigned progress_scale = 0;
- /// TODO: Wrap this in a std::unique_ptr when we transition to C++11
- uint8_t *const ldata = new uint8_t[BlockSize];
- assert(ldata);
-
int aunit_size = 0;
int lunit_size = 0;
unsigned int lsamples_per_block = INT_MAX;
@@ -245,13 +239,13 @@ void StoreSession::store_proc(vector< shared_ptr > achannel_li
unit_count_ = sample_count_ >> progress_scale;
const unsigned int samples_per_block =
- std::min(asamples_per_block, lsamples_per_block);
+ min(asamples_per_block, lsamples_per_block);
while (!interrupt_ && sample_count_) {
progress_updated();
const uint64_t packet_len =
- std::min((uint64_t)samples_per_block, sample_count_);
+ min((uint64_t)samples_per_block, sample_count_);
try {
const auto context = session_.device_manager().context();
@@ -263,8 +257,6 @@ void StoreSession::store_proc(vector< shared_ptr > achannel_li
const float *adata =
asegment->get_samples(start_sample_, start_sample_ + packet_len);
- // The srzip format currently only supports packets with one
- // analog channel. See zip_append_analog() in srzip.c
auto analog = context->create_analog_packet(
vector >{achannel},
(float *)adata, packet_len,
@@ -279,14 +271,17 @@ void StoreSession::store_proc(vector< shared_ptr > achannel_li
}
if (lsegment) {
- lsegment->get_samples(ldata, start_sample_, start_sample_ + packet_len);
+ const uint8_t* ldata =
+ lsegment->get_samples(start_sample_, start_sample_ + packet_len);
const size_t length = packet_len * lunit_size;
- auto logic = context->create_logic_packet(ldata, length, lunit_size);
+ auto logic = context->create_logic_packet((void*)ldata, length, lunit_size);
const string ldata_str = output_->receive(logic);
if (output_stream_.is_open())
output_stream_ << ldata_str;
+
+ delete[] ldata;
}
} catch (Error error) {
error_ = tr("Error while saving: ") + error.what();
@@ -301,12 +296,11 @@ void StoreSession::store_proc(vector< shared_ptr > achannel_li
// Zeroing the progress variables indicates completion
units_stored_ = unit_count_ = 0;
+ store_successful();
progress_updated();
output_.reset();
output_stream_.close();
-
- delete[] ldata;
}
} // pv