X-Git-Url: http://git.code-monkey.de/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fsession.cpp;h=9c3a2c259e2a635f2eed79f5a8a607a9c33d490c;hp=ba43ac21fb9c64d0d1b2711949fb417e4493c890;hb=bf0edd2b0cbb5f4bd5d69b0f00bcea7d037e2287;hpb=34c11fa778e0383d1f117a98be5e32479372022a

diff --git a/pv/session.cpp b/pv/session.cpp
index ba43ac2..9c3a2c2 100644
--- a/pv/session.cpp
+++ b/pv/session.cpp
@@ -39,6 +39,7 @@
 #include "data/decoderstack.hpp"
 #include "data/logic.hpp"
 #include "data/logicsegment.hpp"
+#include "data/signalbase.hpp"
 #include "data/decode/decoder.hpp"
 
 #include "devices/hardwaredevice.hpp"
@@ -161,7 +162,15 @@ void Session::set_device(shared_ptr<devices::Device> device)
 	signals_changed();
 
 	device_ = std::move(device);
-	device_->open();
+
+	try {
+		device_->open();
+	} catch (const QString &e) {
+		device_.reset();
+		device_selected();
+		throw;
+	}
+
 	device_->session()->add_datafeed_callback([=]
 		(shared_ptr<sigrok::Device> device, shared_ptr<Packet> packet) {
 			data_feed_in(device, packet);
@@ -223,8 +232,7 @@ void Session::start_capture(function<void (const QString)> error_handler)
 
 	// Begin the session
 	sampling_thread_ = std::thread(
-		&Session::sample_thread_proc, this, device_,
-			error_handler);
+		&Session::sample_thread_proc, this, error_handler);
 }
 
 void Session::stop_capture()
@@ -291,7 +299,7 @@ bool Session::add_decoder(srd_decoder *const dec)
 					dynamic_pointer_cast<view::LogicSignal>(s);
 				if (l && QString::fromUtf8(pdch->name).
 					toLower().contains(
-					l->name().toLower()))
+					s->channel()->name().toLower()))
 					channels[pdch] = l;
 			}
 
@@ -301,8 +309,11 @@ bool Session::add_decoder(srd_decoder *const dec)
 		decoder_stack->stack().front()->set_channels(channels);
 
 		// Create the decode signal
+		shared_ptr<data::SignalBase> signalbase =
+			shared_ptr<data::SignalBase>(new data::SignalBase(nullptr));
+
 		shared_ptr<view::DecodeTrace> d(
-			new view::DecodeTrace(*this, decoder_stack,
+			new view::DecodeTrace(*this, signalbase, decoder_stack,
 				decode_traces_.size()));
 		decode_traces_.push_back(d);
 	} catch (std::runtime_error e) {
@@ -394,13 +405,14 @@ void Session::update_signals()
 		signals_.clear();
 
 		for (auto channel : sr_dev->channels()) {
+			shared_ptr<data::SignalBase> signalbase;
 			shared_ptr<view::Signal> signal;
 
 			// Find the channel in the old signals
 			const auto iter = std::find_if(
 				prev_sigs.cbegin(), prev_sigs.cend(),
 				[&](const shared_ptr<view::Signal> &s) {
-					return s->channel() == channel;
+					return s->channel()->channel() == channel;
 				});
 			if (iter != prev_sigs.end()) {
 				// Copy the signal from the old set to the new
@@ -412,13 +424,16 @@ void Session::update_signals()
 						logic_data_);
 			} else {
 				// Create a new signal
+				signalbase = shared_ptr<data::SignalBase>(
+					new data::SignalBase(channel));
+
 				switch(channel->type()->id()) {
 				case SR_CHANNEL_LOGIC:
 					signal = shared_ptr<view::Signal>(
 						new view::LogicSignal(*this,
-							device_, channel,
-							logic_data_));
+							device_, signalbase, logic_data_));
 					all_signal_data_.insert(logic_data_);
+					signalbases_.insert(signalbase);
 					break;
 
 				case SR_CHANNEL_ANALOG:
@@ -427,8 +442,9 @@ void Session::update_signals()
 						new data::Analog());
 					signal = shared_ptr<view::Signal>(
 						new view::AnalogSignal(
-							*this, channel, data));
+							*this, signalbase, data));
 					all_signal_data_.insert(data);
+					signalbases_.insert(signalbase);
 					break;
 				}
 
@@ -446,22 +462,19 @@ void Session::update_signals()
 	signals_changed();
 }
 
-shared_ptr<view::Signal> Session::signal_from_channel(
-	shared_ptr<Channel> channel) const
+shared_ptr<data::SignalBase> Session::signal_from_channel(
+	shared_ptr<sigrok::Channel> channel) const
 {
-	lock_guard<boost::shared_mutex> lock(signals_mutex_);
-	for (shared_ptr<view::Signal> sig : signals_) {
+	for (shared_ptr<data::SignalBase> sig : signalbases_) {
 		assert(sig);
 		if (sig->channel() == channel)
 			return sig;
 	}
-	return shared_ptr<view::Signal>();
+	return shared_ptr<data::SignalBase>();
 }
 
-void Session::sample_thread_proc(shared_ptr<devices::Device> device,
-	function<void (const QString)> error_handler)
+void Session::sample_thread_proc(function<void (const QString)> error_handler)
 {
-	assert(device);
 	assert(error_handler);
 
 	if (!device_)