X-Git-Url: http://git.code-monkey.de/?p=pulseview.git;a=blobdiff_plain;f=pv%2Fdialogs%2Fconnect.cpp;h=19dfde8d1a3f227065e39cd1499b2300212f3d8a;hp=f8fbe67f79bb1bf2260f7e3749e0044c2b139abd;hb=e8d009288de28cb194bc7964f96677c2baf900c9;hpb=68162c2925e3c5a3c7d0b4d3d100184e5c649eba

diff --git a/pv/dialogs/connect.cpp b/pv/dialogs/connect.cpp
index f8fbe67..19dfde8 100644
--- a/pv/dialogs/connect.cpp
+++ b/pv/dialogs/connect.cpp
@@ -18,22 +18,27 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-#include <boost/foreach.hpp>
+#include <cassert>
+
+#include <libsigrok/libsigrok.hpp>
 
 #include "connect.h"
 
 #include "pv/devicemanager.h"
 
-extern "C" {
-/* __STDC_FORMAT_MACROS is required for PRIu64 and friends (in C++). */
-#define __STDC_FORMAT_MACROS
-#include <glib.h>
-#include <libsigrok/libsigrok.h>
-}
+using std::list;
+using std::map;
+using std::shared_ptr;
+using std::string;
 
-using namespace std;
+using Glib::ustring;
+using Glib::Variant;
+using Glib::VariantBase;
 
-extern sr_context *sr_ctx;
+using sigrok::ConfigKey;
+using sigrok::Driver;
+using sigrok::Error;
+using sigrok::HardwareDevice;
 
 namespace pv {
 namespace dialogs {
@@ -77,23 +82,20 @@ Connect::Connect(QWidget *parent, pv::DeviceManager &device_manager) :
 	_layout.addWidget(&_button_box);
 }
 
-struct sr_dev_inst* Connect::get_selected_device() const
+shared_ptr<HardwareDevice> Connect::get_selected_device() const
 {
 	const QListWidgetItem *const item = _device_list.currentItem();
 	if (!item)
-		return NULL;
+		return shared_ptr<HardwareDevice>();
 
-	return (sr_dev_inst*)item->data(Qt::UserRole).value<void*>();
+	return item->data(Qt::UserRole).value<shared_ptr<HardwareDevice>>();
 }
 
 void Connect::populate_drivers()
 {
-	gsize num_opts = 0;
-	const int32_t *hwopts;
-	struct sr_dev_driver **drivers = sr_driver_list();
-	GVariant *gvar_opts;
-
-	for (int i = 0; drivers[i]; ++i) {
+	for (auto entry : _device_manager.context()->drivers()) {
+		auto name = entry.first;
+		auto driver = entry.second;
 		/**
 		 * We currently only support devices that can deliver
 		 * samples at a fixed samplerate i.e. oscilloscopes and
@@ -101,22 +103,13 @@ void Connect::populate_drivers()
 		 * @todo Add support for non-monotonic devices i.e. DMMs
 		 * and sensors.
 		 */
-		bool supported_device = false;
-		if ((sr_config_list(drivers[i], NULL, NULL,
-				SR_CONF_DEVICE_OPTIONS, &gvar_opts) == SR_OK)) {
-			hwopts = (const int32_t *)g_variant_get_fixed_array(gvar_opts,
-					&num_opts, sizeof(int32_t));
-			for (unsigned int j = 0; j < num_opts; j++)
-				if (hwopts[j] == SR_CONF_SAMPLERATE) {
-					supported_device = true;
-					break;
-				}
-		}
+		bool supported_device = driver->config_check(
+			ConfigKey::SAMPLERATE, ConfigKey::DEVICE_OPTIONS);
 
 		if (supported_device)
 			_drivers.addItem(QString("%1 (%2)").arg(
-				drivers[i]->longname).arg(drivers[i]->name),
-				qVariantFromValue((void*)drivers[i]));
+				driver->long_name().c_str()).arg(name.c_str()),
+				qVariantFromValue(driver));
 	}
 }
 
@@ -142,78 +135,47 @@ void Connect::scan_pressed()
 	if (index == -1)
 		return;
 
-	sr_dev_driver *const driver = (sr_dev_driver*)_drivers.itemData(
-		index).value<void*>();
+	shared_ptr<Driver> driver =
+		_drivers.itemData(index).value<shared_ptr<Driver>>();
 
-	GSList *drvopts = NULL;
+	assert(driver);
 
-	if (_serial_device.isVisible()) {
-		sr_config *const src = (sr_config*)g_try_malloc(sizeof(sr_config));
-		src->key = SR_CONF_CONN;
-		const QByteArray byteArray = _serial_device.text().toUtf8();
-		src->data = g_variant_new_string((const gchar*)byteArray.constData());
-		drvopts = g_slist_append(drvopts, src);
-	}
+	map<const ConfigKey *, VariantBase> drvopts;
 
-	const list<sr_dev_inst*> devices = _device_manager.driver_scan(
-		driver, drvopts);
+	if (_serial_device.isVisible())
+		drvopts[ConfigKey::CONN] = Variant<ustring>::create(
+			_serial_device.text().toUtf8().constData());
 
-	g_slist_free_full(drvopts, (GDestroyNotify)free_drvopts);
+	list< shared_ptr<HardwareDevice> > devices =
+		_device_manager.driver_scan(driver, drvopts);
 
-	BOOST_FOREACH(sr_dev_inst *const sdi, devices)
+	for (shared_ptr<HardwareDevice> device : devices)
 	{
-		const string title = DeviceManager::format_device_title(sdi);
-		QString text(title.c_str());
-		if (sdi->probes) {
-			text += QString(" with %1 probes").arg(
-				g_slist_length(sdi->probes));
-		}
+		assert(device);
+
+		QString text = QString::fromStdString(
+			_device_manager.device_description(device));
+		text += QString(" with %1 channels").arg(device->channels().size());
 
 		QListWidgetItem *const item = new QListWidgetItem(text,
 			&_device_list);
-		item->setData(Qt::UserRole, qVariantFromValue((void*)sdi));
+		item->setData(Qt::UserRole, qVariantFromValue(device));
 		_device_list.addItem(item);
 	}
 
 	_device_list.setCurrentRow(0);
-	_button_box.button(QDialogButtonBox::Ok)->setDisabled(false);
+	_button_box.button(QDialogButtonBox::Ok)->setDisabled(_device_list.count() == 0);
 }
 
 void Connect::device_selected(int index)
 {
-	gsize num_opts = 0;
-	const int32_t *hwopts;
-	GVariant *gvar_list;
-	sr_dev_driver *const driver = (sr_dev_driver*)_drivers.itemData(
-		index).value<void*>();
+	shared_ptr<Driver> driver =
+		_drivers.itemData(index).value<shared_ptr<Driver>>();
 
 	unset_connection();
 
-	if ((sr_config_list(driver, NULL, NULL,
-				SR_CONF_SCAN_OPTIONS, &gvar_list) == SR_OK)) {
-		hwopts = (const int32_t *)g_variant_get_fixed_array(gvar_list,
-				&num_opts, sizeof(int32_t));
-
-		for (unsigned int i = 0; i < num_opts; i++) {
-			switch(hwopts[i]) {
-			case SR_CONF_SERIALCOMM:
-				set_serial_connection();
-				break;
-
-			default:
-				continue;
-			}
-
-			break;
-		}
-		g_variant_unref(gvar_list);
-	}
-}
-
-void Connect::free_drvopts(struct sr_config *src)
-{
-	g_variant_unref(src->data);
-	g_free(src);
+	if (driver->config_check(ConfigKey::SERIALCOMM, ConfigKey::SCAN_OPTIONS))
+			set_serial_connection();
 }
 
 } // namespace dialogs