Add generic "Create marker here" context menu entry

[pulseview.git] / pv / views / trace / ruler.cpp

diff --git a/pv/views/trace/ruler.cpp b/pv/views/trace/ruler.cpp
index 7688f2b7e1c0262fc12a89e82e2ee6c75b5605d2..675a39f9bd1b6ece887af2c9bd927e496e84a109 100644 (file)
--- a/pv/views/trace/ruler.cpp
+++ b/pv/views/trace/ruler.cpp
@@ -24,6 +24,8 @@
 #include <QMenu>
 #include <QMouseEvent>
 
+#include <pv/globalsettings.hpp>
+
 #include "ruler.hpp"
 #include "view.hpp"
 
@@ -112,7 +114,7 @@ QString Ruler::format_time_with_distance(
                return pv::util::format_time_minutes(t, precision, sign);
 }
 
-pv::util::Timestamp Ruler::get_time_from_x_pos(uint32_t x)
+pv::util::Timestamp Ruler::get_time_from_x_pos(uint32_t x) const
 {
        return view_.ruler_offset() + ((double)x + 0.5) * view_.scale();
 }
@@ -127,6 +129,16 @@ void Ruler::contextMenuEvent(QContextMenuEvent *event)
        connect(create_marker, SIGNAL(triggered()), this, SLOT(on_createMarker()));
        menu->addAction(create_marker);
 
+       QAction *const toggle_hover_marker = new QAction(this);
+       connect(toggle_hover_marker, SIGNAL(triggered()), this, SLOT(on_toggleHoverMarker()));
+       menu->addAction(toggle_hover_marker);
+
+       GlobalSettings settings;
+       const bool hover_marker_shown =
+               settings.value(GlobalSettings::Key_View_ShowHoverMarker).toBool();
+       toggle_hover_marker->setText(hover_marker_shown ?
+               tr("Disable mouse hover marker") : tr("Enable mouse hover marker"));
+
        menu->popup(event->globalPos());
 }
 
@@ -306,7 +318,14 @@ void Ruler::invalidate_tick_position_cache()
 
 void Ruler::on_createMarker()
 {
-       view_.add_flag(get_time_from_x_pos(context_menu_x_pos_));
+       view_.add_flag(get_time_from_x_pos(mouse_down_point_.x()));
+}
+
+void Ruler::on_toggleHoverMarker()
+{
+       GlobalSettings settings;
+       const bool state = settings.value(GlobalSettings::Key_View_ShowHoverMarker).toBool();
+       settings.setValue(GlobalSettings::Key_View_ShowHoverMarker, !state);
 }
 
 } // namespace trace