Fix clazy warnings regarding range-for references

[pulseview.git] / pv / binding / inputoutput.cpp

diff --git a/pv/binding/inputoutput.cpp b/pv/binding/inputoutput.cpp
index df9d3799eb287ccfdb78682d077236aed95cff5f..f9a061c76e78c7b7e77a33ec1d04250328263b70 100644 (file)
--- a/pv/binding/inputoutput.cpp
+++ b/pv/binding/inputoutput.cpp
@@ -35,7 +35,6 @@
 
 using boost::none;
 
-using std::make_pair;
 using std::map;
 using std::pair;
 using std::shared_ptr;
@@ -60,17 +59,18 @@ namespace binding {
 InputOutput::InputOutput(
        const map<string, shared_ptr<Option>> &options)
 {
-       for (pair<string, shared_ptr<Option>> o : options) {
+       for (const pair<string, shared_ptr<Option>>& o : options) {
                const shared_ptr<Option> &opt = o.second;
                assert(opt);
 
                const QString name = QString::fromStdString(opt->name());
                const QString desc = QString::fromStdString(opt->description());
+
                const VariantBase def_val = opt->default_value();
                const vector<VariantBase> values = opt->values();
 
                options_[opt->id()] = def_val;
- 
+
                const Property::Getter get = [&, opt]() {
                        return options_[opt->id()]; };
                const Property::Setter set = [&, opt](VariantBase value) {
@@ -111,7 +111,7 @@ shared_ptr<Property> InputOutput::bind_enum(
 {
        vector< pair<VariantBase, QString> > enum_vals;
        for (VariantBase var : values)
-               enum_vals.push_back(make_pair(var, print_gvariant(var)));
+               enum_vals.emplace_back(var, print_gvariant(var));
        return shared_ptr<Property>(new Enum(name, desc, enum_vals, getter, setter));
 }