From c56befbe404a7931774526ff5d446610e613a2e9 Mon Sep 17 00:00:00 2001 From: Sebastian Golasch Date: Fri, 3 Mar 2017 17:18:13 +0100 Subject: [PATCH] fix(ui): Masks password input, renders empty list if no search or seasons results are found --- addon.xml | 2 +- resources/language/English/strings.po | 2 +- resources/language/German/strings.po | 2 +- resources/lib/KodiHelper.py | 35 +++++++++++++++++++++------ 4 files changed, 31 insertions(+), 10 deletions(-) diff --git a/addon.xml b/addon.xml index ece241a..1ea39f7 100644 --- a/addon.xml +++ b/addon.xml @@ -1,5 +1,5 @@ - + diff --git a/resources/language/English/strings.po b/resources/language/English/strings.po index 7ec2d52..f1f0ab2 100644 --- a/resources/language/English/strings.po +++ b/resources/language/English/strings.po @@ -1,7 +1,7 @@ # Kodi Media Center language file # Addon Name: Netflix # Addon id: plugin.video.netflix -# Addon version: 0.2.0 +# Addon version: 0.9.3 # Addon Provider: tba. msgid "" msgstr "" diff --git a/resources/language/German/strings.po b/resources/language/German/strings.po index 62ee463..344f028 100644 --- a/resources/language/German/strings.po +++ b/resources/language/German/strings.po @@ -1,7 +1,7 @@ # Kodi Media Center language file # Addon Name: Netflix # Addon id: plugin.video.netflix -# Addon version: 0.2.0 +# Addon version: 0.9.3 # Addon Provider: tba. msgid "" msgstr "" diff --git a/resources/lib/KodiHelper.py b/resources/lib/KodiHelper.py index f96dd2f..04d268e 100644 --- a/resources/lib/KodiHelper.py +++ b/resources/lib/KodiHelper.py @@ -100,7 +100,7 @@ class KodiHelper: Netflix password """ dlg = xbmcgui.Dialog() - return dlg.input(self.get_local_string(string_id=30004), type=xbmcgui.INPUT_ALPHANUM) + return dlg.input(self.get_local_string(string_id=30004), type=xbmcgui.INPUT_ALPHANUM, option=xbmcgui.ALPHANUM_HIDE_INPUT) def show_email_dialog (self): """Asks the user for its Netflix account email @@ -137,6 +137,30 @@ class KodiHelper: dialog.notification(self.get_local_string(string_id=30028), self.get_local_string(string_id=30029), xbmcgui.NOTIFICATION_ERROR, 5000) return True + def show_no_search_results_notification (self): + """Shows notification that no search results could be found + + Returns + ------- + bool + Dialog shown + """ + dialog = xbmcgui.Dialog() + dialog.notification(self.get_local_string(string_id=30011), self.get_local_string(string_id=30013)) + return True + + def show_no_seasons_notification (self): + """Shows notification that no seasons be found + + Returns + ------- + bool + Dialog shown + """ + dialog = xbmcgui.Dialog() + dialog.notification(self.get_local_string(string_id=30010), self.get_local_string(string_id=30012)) + return True + def set_setting (self, key, value): """Public interface for the addons setSetting method @@ -452,8 +476,7 @@ class KodiHelper: bool List could be build """ - li = xbmcgui.ListItem(label=self.get_local_string(30012)) - xbmcplugin.addDirectoryItem(handle=self.plugin_handle, url='', listitem=li, isFolder=False) + self.show_no_seasons_notification() xbmcplugin.endOfDirectory(self.plugin_handle) return True @@ -473,10 +496,8 @@ class KodiHelper: bool List could be build """ - li = xbmcgui.ListItem(label=self.get_local_string(30013)) - xbmcplugin.addDirectoryItem(handle=self.plugin_handle, url=build_url({'action': action}), listitem=li, isFolder=False) - xbmcplugin.endOfDirectory(self.plugin_handle) - return True + self.show_no_search_results_notification() + return xbmcplugin.endOfDirectory(self.plugin_handle) def build_user_sub_listing (self, video_list_ids, type, action, build_url): """Builds the video lists screen for user subfolders (genres & recommendations) -- 2.30.2