Joel Holdsworth [Sat, 9 Mar 2013 15:51:47 +0000 (15:51 +0000)]
Deleted unused pv::view::Viewport::mouseReleaseEvent handler
This resolves the compile failure reported by arekm
Joel Holdsworth [Sat, 9 Mar 2013 15:36:28 +0000 (15:36 +0000)]
Initialise sample_rate in pv::SigSession::feed_in_header
This resolves the compile failure reported by arekm
Uwe Hermann [Sat, 9 Mar 2013 10:41:41 +0000 (11:41 +0100)]
Whitespace fixes.
Matt Ranostay [Thu, 7 Mar 2013 23:51:08 +0000 (15:51 -0800)]
bugfix: Resolved -Werror message in main.cpp
pulseview/main.cpp: In function ‘int main(int, char**)’:
pulseview/main.cpp:91:13: error: comparison is always false due to limited range of data type [-Werror=type-limits]
Signed-off-by: Matt Ranostay <mranostay@gmail.com>
Joel Holdsworth [Thu, 7 Mar 2013 23:25:02 +0000 (23:25 +0000)]
Prevent Ok being pressed when no device is selected
Disable Ok until a device has been selected, and select the first device when scan is pressed
Joel Holdsworth [Thu, 7 Mar 2013 23:18:46 +0000 (23:18 +0000)]
Process selected device
Joel Holdsworth [Thu, 7 Mar 2013 22:41:04 +0000 (22:41 +0000)]
Added pv::SamplingBar::set_selected_device
Joel Holdsworth [Thu, 7 Mar 2013 22:39:55 +0000 (22:39 +0000)]
Moved device enumeration out of pv::SamplingBar into pv::MainWindow
Joel Holdsworth [Thu, 7 Mar 2013 22:40:45 +0000 (22:40 +0000)]
SamplingBar::update_sample_rate_selector should abort if no devices is selected
Joel Holdsworth [Thu, 7 Mar 2013 22:25:06 +0000 (22:25 +0000)]
Fixed indentation in SamplingBar::update_sample_rate_selector_value
Joel Holdsworth [Thu, 7 Mar 2013 21:23:11 +0000 (21:23 +0000)]
Implemented device probing
Joel Holdsworth [Wed, 30 Jan 2013 22:29:06 +0000 (22:29 +0000)]
Only allow monotonic devices in the device list
Joel Holdsworth [Sat, 29 Dec 2012 14:57:10 +0000 (14:57 +0000)]
Initial manual connect dialog with a serial port selector
Alexandru Gagniuc [Wed, 30 Jan 2013 16:54:46 +0000 (10:54 -0600)]
README: Explicitly state meaning of year ranges in copyright statements
Year ranges in copyright statements have no legal meaning. That's why we
explicitly state what they mean in README.
For details, see:
http://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Alexandru Gagniuc [Wed, 30 Jan 2013 16:34:29 +0000 (10:34 -0600)]
Separate the build/install instructions from the README.
Distros include the README in the package, and it doesn't make sense to have
build and install instructions in a binary package.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Joel Holdsworth [Sun, 3 Mar 2013 17:41:19 +0000 (17:41 +0000)]
Sampling bar now commits the sample rate into the device instance
Joel Holdsworth [Sun, 3 Mar 2013 17:05:46 +0000 (17:05 +0000)]
Removed sample_rate parameter from start_capture
We now rely on the statefulness of the device instance instead
Joel Holdsworth [Sun, 3 Mar 2013 16:33:16 +0000 (16:33 +0000)]
Added a binding for SR_CONF_SAMPLERATE
Joel Holdsworth [Sun, 3 Mar 2013 14:40:46 +0000 (14:40 +0000)]
Added a Double property object
Joel Holdsworth [Sun, 3 Mar 2013 15:47:43 +0000 (15:47 +0000)]
Implemented getter behaviour in DeviceOptions
Joel Holdsworth [Sun, 3 Mar 2013 15:46:32 +0000 (15:46 +0000)]
Implemented getter behaviour in Enum
Joel Holdsworth [Sun, 3 Mar 2013 14:31:00 +0000 (14:31 +0000)]
Use namespaces in enum.cpp
Joel Holdsworth [Sun, 3 Mar 2013 16:32:46 +0000 (16:32 +0000)]
Corrected const of DeviceOptions::_sdi
Joel Holdsworth [Sun, 3 Mar 2013 14:40:58 +0000 (14:40 +0000)]
Tidied whitespace
Uwe Hermann [Sun, 3 Mar 2013 16:20:00 +0000 (17:20 +0100)]
Minor whitespace fixes.
Joel Holdsworth [Sun, 3 Mar 2013 11:43:38 +0000 (11:43 +0000)]
Pad mip-map buffers to allow for uint64_t write word
Joel Holdsworth [Sun, 3 Mar 2013 09:55:03 +0000 (09:55 +0000)]
Set the colour of ruler annotations to the correct palette colour
Joel Holdsworth [Sun, 3 Mar 2013 09:06:44 +0000 (09:06 +0000)]
Added open file command line argument
Joel Holdsworth [Sat, 2 Mar 2013 09:26:39 +0000 (09:26 +0000)]
Show samplerate as 1Hz when its value is unknown
Joel Holdsworth [Sat, 2 Mar 2013 09:10:32 +0000 (09:10 +0000)]
Added shorter record lengths
Joel Holdsworth [Sat, 2 Mar 2013 08:49:05 +0000 (08:49 +0000)]
Explicitly set analog signal painting colour
Uwe Hermann [Sat, 2 Mar 2013 10:57:28 +0000 (11:57 +0100)]
About box: Make URL clickable.
Thanks R. Diez <rdiezmail-comparevcd@yahoo.de> for the patch!
Uwe Hermann [Wed, 20 Feb 2013 11:04:23 +0000 (12:04 +0100)]
Drop a few more unneeded 'extern "C"'.
Uwe Hermann [Wed, 20 Feb 2013 10:58:21 +0000 (11:58 +0100)]
Remove unneeded 'extern "C"'.
System headers, glib headers, and libsigrok/libsigrokdecode headers all
use 'extern "C"' already, so there's no need to explicitly add these
in PulseView (for these cases).
Thanks R. Diez <rdiezmail-comparevcd@yahoo.de> for the patch!
Uwe Hermann [Wed, 20 Feb 2013 10:39:38 +0000 (11:39 +0100)]
Print --help/--version output to stdout (not stderr).
Thanks R. Diez <rdiezmail-comparevcd@yahoo.de> for the patch!
This is not a feasible practice for CLI tools where the output might
be piped into other tools (and you don't want to pipe help messages or
other non-data). However, for the PulseView GUI this is acceptable since
it's not meant to be used that way.
Uwe Hermann [Wed, 20 Feb 2013 10:37:49 +0000 (11:37 +0100)]
Fix compiler warnings/errors due to -Wall.
Uwe Hermann [Wed, 20 Feb 2013 10:29:37 +0000 (11:29 +0100)]
Add -Wall compiler option.
Thanks R. Diez <rdiezmail-comparevcd@yahoo.de> for the patch!
Uwe Hermann [Wed, 20 Feb 2013 09:45:30 +0000 (10:45 +0100)]
.gitignore: Add missing CPack files.
Thanks R. Diez <rdiezmail-comparevcd@yahoo.de> for the patch!
Uwe Hermann [Mon, 18 Feb 2013 23:56:19 +0000 (00:56 +0100)]
Cosmetics, typos.
Alexandru Gagniuc [Wed, 2 Jan 2013 23:19:57 +0000 (17:19 -0600)]
main: quit on SIGINT
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Alexandru Gagniuc [Wed, 2 Jan 2013 17:37:49 +0000 (11:37 -0600)]
main: Add signal handler for SIGINT
Add a SIGINT handler as requested here:
http://www.airwebreathe.org.uk/projects/index.php?title=PulseView#Make_PulseView_respond_properly_to_SIGINT
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Alexandru Gagniuc [Tue, 5 Feb 2013 16:33:05 +0000 (10:33 -0600)]
buildsystem: Abort cmake config if Boost is not found
When cmake didn't find Boost, it would not abort; instead the linking
process after the build would fail with non-obvious error messages.
Thus, make Boost a required dependency (fixes bug 59).
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Joel Holdsworth [Mon, 28 Jan 2013 20:35:24 +0000 (20:35 +0000)]
Get sample rate from device instance rather than storing it
Joel Holdsworth [Sun, 27 Jan 2013 16:35:11 +0000 (16:35 +0000)]
Moved signal creation into feed_in_header
Joel Holdsworth [Sun, 27 Jan 2013 11:10:19 +0000 (11:10 +0000)]
Ported sampling to new sigrok API
Joel Holdsworth [Sun, 27 Jan 2013 09:43:57 +0000 (09:43 +0000)]
Renamed pv::dialogs::HwCap to DeviceOptions
Joel Holdsworth [Sun, 27 Jan 2013 09:40:29 +0000 (09:40 +0000)]
Renamed pv::prop::binding::HwCap to DeviceOptions
Joel Holdsworth [Sun, 27 Jan 2013 09:32:20 +0000 (09:32 +0000)]
Ported pv::prop::binding::HwCap to new sigrok API
Joel Holdsworth [Sun, 27 Jan 2013 09:16:40 +0000 (09:16 +0000)]
samplingbar: Replace sr_info_get(SR_DI_SAMPLERATES) with sr_config_list(SR_CONF_SAMPLERATE)
Alexandru Gagniuc [Sat, 26 Jan 2013 06:35:17 +0000 (00:35 -0600)]
View: Decouple horizontal scrolling from the scoll bar
Scrolling horizontally, regardless if through the tilt wheel, dragging the
signals, or moving the scroll bar, updates the viewport and the scroll bar. This
triggered a valueChanged() signal from the scroll bar, causing the viewport to
be updated again (redundantly). The operation of the viewport became dependent
on the scroll bar. On high zoom levels, where the scroll bar's resolution is
limited, the coupling manifested as jitter. The view was rendered with the
proper resolution of, caused the mouse drag event, then immediately updated and
rendered with the limited resolution of the scroll bar.
Decouple the viewport from the valueChanged() signal, and use the sliderMoved()
signal instead. The scroll bar becomes a simple input element, and only causes
a viewport update when acted upon by the user. Using the scroll bar is still
limited in resolution, but other scrolling methods are no longer affected by the
limitations of the scroll bar.
This fixes bug 7.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Alexandru Gagniuc [Tue, 15 Jan 2013 22:09:57 +0000 (16:09 -0600)]
buildsystem: Link against the platform's thread library
At least on Linux, boost-thread depends on pthread. The linking is not
automatic, and users have had issues with this.
We need to link against the platform's thread library, as it is needed for
boost-thread. CMake takes care of getting the exact settings to be passed
to the linker for us with ${CMAKE_THREAD_LIBS_INIT}.
This fixes bug #42.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Uwe Hermann [Thu, 24 Jan 2013 21:34:49 +0000 (22:34 +0100)]
Add missing #include <limits.h>.
The file ruler.cpp uses INT_MAX from <limits.h>, so add the #include line.
Without this, the build would fail on some systems (due to -Werror).
Uwe Hermann [Thu, 24 Jan 2013 21:34:08 +0000 (22:34 +0100)]
Lower Boost dependency to 1.42.
PulseView builds fine with Boost 1.42, too.
Uwe Hermann [Sun, 20 Jan 2013 16:11:51 +0000 (17:11 +0100)]
MinGW: Drop hardcoded BOOST_ROOT.
This was somewhat useful when PulseView only needed header-only parts of
Boost, but since boost-thread is now also needed this is not sufficient
anymore and needs a different setup for native MinGW builds on Windows.
Cross-compile builds using 'sigrok-cross-mingw' from sigrok-util work
fine without it, though.
Uwe Hermann [Sun, 20 Jan 2013 14:48:16 +0000 (15:48 +0100)]
Add missing settings for boost-thread on MinGW.
Uwe Hermann [Sat, 19 Jan 2013 22:15:21 +0000 (23:15 +0100)]
CPack: Only generate a .tar.gz file.
We don't need the tarball as additional *.tar.bz2 and .tar.Z files.
Uwe Hermann [Sat, 19 Jan 2013 22:13:56 +0000 (23:13 +0100)]
README: Minor fixes, typos.
Joel Holdsworth [Sat, 19 Jan 2013 21:55:25 +0000 (21:55 +0000)]
Documented packing procedure
Joel Holdsworth [Sat, 19 Jan 2013 21:52:22 +0000 (21:52 +0000)]
Prevent CPack from generating a source package with -Source appended to the name
Joel Holdsworth [Sat, 19 Jan 2013 21:51:52 +0000 (21:51 +0000)]
Set the package version number
Alexandru Gagniuc [Wed, 24 Oct 2012 15:12:40 +0000 (10:12 -0500)]
Add a way to generate a tarball without requiring git
$ make package_source
This will use CPack to generate tarballs of the source directory.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Joel Holdsworth [Sat, 19 Jan 2013 08:22:12 +0000 (08:22 +0000)]
Added axes to each signal
Joel Holdsworth [Fri, 18 Jan 2013 18:33:01 +0000 (18:33 +0000)]
Eliminated get_nominal_offset
Uwe Hermann [Sat, 19 Jan 2013 20:05:53 +0000 (21:05 +0100)]
Lower Boost dependency to 1.45, which is sufficient.
FreeBSD 9.0 ships with Boost 1.45, and builds fine (without errors), so
lower the dependency to 1.45.
Uwe Hermann [Sat, 19 Jan 2013 19:50:30 +0000 (20:50 +0100)]
samplingbar.cpp: Add missing "ULL".
10000000000 is too large for an int/long on 32bit systems, properly list it
as 10000000000ULL, otherwise the compile will fail.
samplingbar.cpp:48: error: integer constant is too large for 'long' type.
Uwe Hermann [Sat, 19 Jan 2013 19:44:38 +0000 (20:44 +0100)]
Add missing newlines in two header files.
Without the newlines, some compilers will spew warnings such as:
cursor.h:83:37: error: no newline at end of file
(which will break the build due to -Werror, which is default-enabled)
This has been (for example) observed on FreeBSD 9.0's (patched) gcc 4.2.1.
Uwe Hermann [Sat, 19 Jan 2013 19:09:07 +0000 (20:09 +0100)]
CMakeLists.txt: Fix typo.
Uwe Hermann [Sat, 19 Jan 2013 17:48:16 +0000 (18:48 +0100)]
boost-thread: Use 'thread_win32' on Windows/MinGW.
Joel Holdsworth [Wed, 16 Jan 2013 19:04:08 +0000 (19:04 +0000)]
Added -Wextra, and an option to disable -Werror
Joel Holdsworth [Wed, 16 Jan 2013 18:56:16 +0000 (18:56 +0000)]
Explicitly initialise QObject in the copy constructor
Joel Holdsworth [Wed, 16 Jan 2013 18:55:52 +0000 (18:55 +0000)]
Supressed unused parameters
Uwe Hermann [Tue, 15 Jan 2013 22:48:55 +0000 (23:48 +0100)]
pulseview.qrc: Add missing application-exit.png entry.
Without this, the icon won't be shown in the menu.
Joel Holdsworth [Tue, 15 Jan 2013 19:25:43 +0000 (19:25 +0000)]
Added File>Quit menu item
Joel Holdsworth [Tue, 15 Jan 2013 18:55:49 +0000 (18:55 +0000)]
Do not fast_forward if there is no data at the minimum mip-map level
Joel Holdsworth [Sun, 13 Jan 2013 19:24:31 +0000 (19:24 +0000)]
Added Sixteen test case
This test case is a replica of sixteen.sr attached to the Bug #33
Joel Holdsworth [Sun, 13 Jan 2013 13:42:36 +0000 (13:42 +0000)]
Fixed LongPulses test packet setup
The length field is now populated with the number of bytes rather
than the number of samples
Joel Holdsworth [Sun, 13 Jan 2013 11:55:51 +0000 (11:55 +0000)]
Fixed usage of sr_datafeed_logic::length
The length field is a measure of bytes not samples. The previous
usage would fail unless the unitsize was set to 1.
Alexandru Gagniuc [Tue, 8 Jan 2013 20:25:56 +0000 (14:25 -0600)]
global: Do not assert >= 0 for unsigned values
Unsigned values are always >= 0. These assertions are redundant, so remove them.
$ grep assert -r ./ |grep ">=" |grep 0
shows the assert(something >= 0). Remove those which assert(unsigned >= 0).
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Alexandru Gagniuc [Tue, 8 Jan 2013 20:18:37 +0000 (14:18 -0600)]
tests: Add check for handling of wide data (16 probes)
The details of the test are explained in-source. This test is designed to
provide a test case for bug 33.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Joel Holdsworth [Tue, 1 Jan 2013 19:47:24 +0000 (19:47 +0000)]
Fixed pv::dialogs::About to accomodate
42515b0f in libsigrokdecode
Joel Holdsworth [Mon, 31 Dec 2012 09:34:12 +0000 (09:34 +0000)]
Added status icons to Run/Stop button
Joel Holdsworth [Sun, 30 Dec 2012 20:58:55 +0000 (20:58 +0000)]
Tidied pv::MainWindow menu setup
Joel Holdsworth [Sun, 30 Dec 2012 20:47:40 +0000 (20:47 +0000)]
Removed status bar
Joel Holdsworth [Sat, 29 Dec 2012 13:49:59 +0000 (13:49 +0000)]
Set HwCap dialog title
Joel Holdsworth [Fri, 28 Dec 2012 11:44:42 +0000 (11:44 +0000)]
Added fallback toolbar icons
Joel Holdsworth [Fri, 28 Dec 2012 11:34:25 +0000 (11:34 +0000)]
Added Tango configure icon
Joel Holdsworth [Fri, 28 Dec 2012 10:03:51 +0000 (10:03 +0000)]
Implemented HwCap binding
Joel Holdsworth [Fri, 28 Dec 2012 10:17:50 +0000 (10:17 +0000)]
Added commit support to HwCap dialog
Joel Holdsworth [Fri, 28 Dec 2012 10:17:08 +0000 (10:17 +0000)]
Added commit support to Binding
Joel Holdsworth [Fri, 28 Dec 2012 10:15:54 +0000 (10:15 +0000)]
Added get/set support to Property and Enum
Joel Holdsworth [Fri, 28 Dec 2012 10:03:34 +0000 (10:03 +0000)]
Integrated property widgets with dialog
Joel Holdsworth [Fri, 28 Dec 2012 10:10:09 +0000 (10:10 +0000)]
Added Enum property
Joel Holdsworth [Fri, 28 Dec 2012 10:09:41 +0000 (10:09 +0000)]
Added Property
Joel Holdsworth [Fri, 28 Dec 2012 09:51:12 +0000 (09:51 +0000)]
Added empty HwCap dialog
Joel Holdsworth [Fri, 28 Dec 2012 09:52:56 +0000 (09:52 +0000)]
Added empty HwCap binding
Joel Holdsworth [Thu, 20 Dec 2012 21:34:43 +0000 (21:34 +0000)]
Moved data and snapshot classes into pv::data namespace
Joel Holdsworth [Thu, 20 Dec 2012 20:28:19 +0000 (20:28 +0000)]
Tidied include of view in mainwindow.cpp
Joel Holdsworth [Thu, 20 Dec 2012 20:27:54 +0000 (20:27 +0000)]
Moved pv::About into the pv::dialogs::About namespace
Alexandru Gagniuc [Sun, 16 Dec 2012 06:01:47 +0000 (00:01 -0600)]
Viewport: Allow horizontal scrolling via mouse wheel tilting
On mice with a horizontal scroll wheel, or tilting wheel, enable the user to
scroll horizontally.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Alexandru Gagniuc [Sun, 16 Dec 2012 01:16:32 +0000 (19:16 -0600)]
Viewport: Only zoom in/out at vertical wheel events
Viewport always zoomed the signals in and out on a wheel event. Moving the
scroll wheel up or down caused the intended effect of zooming in or zooming out,
respectively. This works flawlessly on mice with only a vertical wheel.
On mice with a horizontal or tilting wheel, horizontal scrolling or tilting was
still treated as zooming in and out. This created a non-intuitive experience,
as the user expects the signals to scroll left or right with this gesture.
Check to make sure the wheel event is a vertical one, and only then zoom in/out.
Do nothing if the wheel event is not vertical.
Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>