X-Git-Url: http://git.code-monkey.de/?a=blobdiff_plain;f=src%2Fmessages.c;h=d99548563c042cb04e417930ece49d2a6cc9db59;hb=82bb2989ad3f139f7acb3bf91d471644cbb2a8d1;hp=8b4c497e8679c638277e47ec8452f32d601b5161;hpb=8f46c2a3cb1e906c68cd658469974d1ab3761d4d;p=umurmur.git

diff --git a/src/messages.c b/src/messages.c
index 8b4c497..d995485 100644
--- a/src/messages.c
+++ b/src/messages.c
@@ -1,5 +1,5 @@
-/* Copyright (C) 2009, Martin Johansson <martin@fatbob.nu>
-   Copyright (C) 2005-2009, Thorvald Natvig <thorvald@natvig.com>
+/* Copyright (C) 2009-2014, Martin Johansson <martin@fatbob.nu>
+   Copyright (C) 2005-2014, Thorvald Natvig <thorvald@natvig.com>
 
    All rights reserved.
 
@@ -38,34 +38,40 @@
 #include "client.h"
 #include "pds.h"
 #include "log.h"
+#include "memory.h"
 
+#define PREAMBLE_SIZE 6
 
-void dumpmsg(uint8_t *data, int size);
+static message_t *Msg_create_nopayload(messageType_t messageType);
 
-void Msg_addPreamble(uint8_t *buffer, uint16_t type, uint32_t len)
+static void Msg_addPreamble(uint8_t *buffer, uint16_t type, uint32_t len)
 {
-	uint16_t *msgType = (uint16_t *) &buffer[0];
-	uint32_t *msgLen = (uint32_t *) &buffer[2];
-	
-	*msgType = htons(type);
-	*msgLen = htonl(len);
+	buffer[1] = (type) & 0xff;
+	buffer[0] = (type >> 8) & 0xff;
+
+	buffer[5] = (len) & 0xff;
+	buffer[4] = (len >> 8) & 0xff;
+	buffer[3] = (len >> 16) & 0xff;
+	buffer[2] = (len >> 24) & 0xff;
 }
 
 static void Msg_getPreamble(uint8_t *buffer, int *type, int *len)
 {
-	uint16_t *msgType = (uint16_t *) &buffer[0];
-	uint32_t *msgLen = (uint32_t *) &buffer[2];
-	
-	*type = (int)ntohs(*msgType);
-	*len = (int)ntohl(*msgLen);
+	uint16_t msgType;
+	uint32_t msgLen;
+
+	msgType = buffer[1] | (buffer[0] << 8);
+	msgLen = buffer[5] | (buffer[4] << 8) | (buffer[3] << 16) | (buffer[2] << 24);
+	*type = (int)msgType;
+	*len = (int)msgLen;
 }
 
-#define MAX_MSGSIZE (BUFSIZE - 6)
+#define MAX_MSGSIZE (BUFSIZE - PREAMBLE_SIZE)
 int Msg_messageToNetwork(message_t *msg, uint8_t *buffer)
 {
 	int len;
-	uint8_t *bufptr = buffer + 6;
-		
+	uint8_t *bufptr = buffer + PREAMBLE_SIZE;
+
 	Log_debug("To net: msg type %d", msg->messageType);
 	switch (msg->messageType) {
 	case Version:
@@ -75,18 +81,16 @@ int Msg_messageToNetwork(message_t *msg, uint8_t *buffer)
 			break;
 		}
 		Msg_addPreamble(buffer, msg->messageType, len);
-		Log_debug("To net: Version->release: %s Version->os: %s",
-				  msg->payload.version->release, msg->payload.version->os);
 		mumble_proto__version__pack(msg->payload.version, bufptr);
 		break;
-	case UDPTunnel:
-		len = mumble_proto__udptunnel__get_packed_size(msg->payload.UDPTunnel);
-		if (len > MAX_MSGSIZE) {
+	case UDPTunnel: /* Non-standard handling of tunneled voice traffic. */
+		if (msg->payload.UDPTunnel->packet.len > MAX_MSGSIZE) {
 			Log_warn("Too big tx message. Discarding");
 			break;
 		}
-		Msg_addPreamble(buffer, msg->messageType, len);
-		mumble_proto__udptunnel__pack(msg->payload.UDPTunnel, bufptr);		
+		len = msg->payload.UDPTunnel->packet.len;
+		Msg_addPreamble(buffer, msg->messageType, msg->payload.UDPTunnel->packet.len);
+		memcpy(bufptr, msg->payload.UDPTunnel->packet.data, msg->payload.UDPTunnel->packet.len);
 		break;
 	case Authenticate:
 		len = mumble_proto__authenticate__get_packed_size(msg->payload.authenticate);
@@ -169,6 +173,15 @@ int Msg_messageToNetwork(message_t *msg, uint8_t *buffer)
 		Msg_addPreamble(buffer, msg->messageType, len);
 		mumble_proto__user_state__pack(msg->payload.userState, bufptr);
 		break;
+	case UserRemove:
+		len = mumble_proto__user_remove__get_packed_size(msg->payload.userRemove);
+		if (len > MAX_MSGSIZE) {
+			Log_warn("Too big tx message. Discarding");
+			break;
+			}
+		Msg_addPreamble(buffer, msg->messageType, len);
+		mumble_proto__user_remove__pack(msg->payload.userRemove, bufptr);
+		break;
 	case ChannelState:
 		len = mumble_proto__channel_state__get_packed_size(msg->payload.channelState);
 		if (len > MAX_MSGSIZE) {
@@ -196,85 +209,163 @@ int Msg_messageToNetwork(message_t *msg, uint8_t *buffer)
 		Msg_addPreamble(buffer, msg->messageType, len);
 		mumble_proto__codec_version__pack(msg->payload.codecVersion, bufptr);
 		break;
+	case PermissionQuery:
+		len = mumble_proto__permission_query__get_packed_size(msg->payload.permissionQuery);
+		if (len > MAX_MSGSIZE) {
+			Log_warn("Too big tx message. Discarding");
+			break;
+			}
+		Msg_addPreamble(buffer, msg->messageType, len);
+		mumble_proto__permission_query__pack(msg->payload.permissionQuery, bufptr);
+		break;
+	case ChannelRemove:
+		len = mumble_proto__channel_remove__get_packed_size(msg->payload.channelRemove);
+		if (len > MAX_MSGSIZE) {
+			Log_warn("Too big tx message. Discarding");
+			break;
+			}
+		Msg_addPreamble(buffer, msg->messageType, len);
+		mumble_proto__channel_remove__pack(msg->payload.channelRemove, bufptr);
+		break;
+	case UserStats:
+	{
+		len = mumble_proto__user_stats__get_packed_size(msg->payload.userStats);
+		if (len > MAX_MSGSIZE) {
+			Log_warn("Too big tx message. Discarding");
+			break;
+			}
+		Msg_addPreamble(buffer, msg->messageType, len);
+		mumble_proto__user_stats__pack(msg->payload.userStats, bufptr);
+		break;
+	}
+	case ServerConfig:
+		len = mumble_proto__server_config__get_packed_size(msg->payload.serverConfig);
+		if (len > MAX_MSGSIZE) {
+			Log_warn("Too big tx message. Discarding");
+			break;
+			}
+		Msg_addPreamble(buffer, msg->messageType, len);
+		mumble_proto__server_config__pack(msg->payload.serverConfig, bufptr);
+		break;
 
+	case BanList:
+		len = mumble_proto__ban_list__get_packed_size(msg->payload.banList);
+		if (len > MAX_MSGSIZE) {
+			Log_warn("Too big tx message. Discarding");
+			break;
+			}
+		Msg_addPreamble(buffer, msg->messageType, len);
+		Log_debug("Msg_MessageToNetwork: BanList size %d", len);
+		mumble_proto__ban_list__pack(msg->payload.banList, bufptr);
+		break;
 	default:
-		Log_warn("Unsupported message %d", msg->messageType);
+		Log_warn("Msg_MessageToNetwork: Unsupported message %d", msg->messageType);
 		return 0;
 	}
-	return len + 6;
+	return len + PREAMBLE_SIZE;
 }
 
-message_t *Msg_create(messageType_t messageType)
+static message_t *Msg_create_nopayload(messageType_t messageType)
 {
-	message_t *msg = malloc(sizeof(message_t));
+	message_t *msg = Memory_safeCalloc(1, sizeof(message_t));
 
-	if (msg == NULL)
-		Log_fatal("Out of memory");
-	memset(msg, 0, sizeof(message_t));
 	msg->refcount = 1;
 	msg->messageType = messageType;
 	init_list_entry(&msg->node);
-	
+	return msg;
+}
+
+message_t *Msg_create(messageType_t messageType)
+{
+	message_t *msg = Msg_create_nopayload(messageType);
+	int i;
+
 	switch (messageType) {
 	case Version:
-		msg->payload.version = malloc(sizeof(MumbleProto__Version));
+		msg->payload.version = Memory_safeMalloc(1, sizeof(MumbleProto__Version));
 		mumble_proto__version__init(msg->payload.version);
 		break;
 	case UDPTunnel:
-		msg->payload.UDPTunnel = malloc(sizeof(MumbleProto__UDPTunnel));
+		msg->payload.UDPTunnel = Memory_safeMalloc(1, sizeof(MumbleProto__UDPTunnel));
 		mumble_proto__udptunnel__init(msg->payload.UDPTunnel);
 		break;
 	case Authenticate:
-		msg->payload.authenticate = malloc(sizeof(MumbleProto__Authenticate));
+		msg->payload.authenticate = Memory_safeMalloc(1, sizeof(MumbleProto__Authenticate));
 		mumble_proto__authenticate__init(msg->payload.authenticate);
 		break;
 	case Ping:
-		msg->payload.ping = malloc(sizeof(MumbleProto__Ping));
+		msg->payload.ping = Memory_safeMalloc(1, sizeof(MumbleProto__Ping));
 		mumble_proto__ping__init(msg->payload.ping);
 		break;
 	case Reject:
-		msg->payload.reject = malloc(sizeof(MumbleProto__Reject));
+		msg->payload.reject = Memory_safeMalloc(1, sizeof(MumbleProto__Reject));
 		mumble_proto__reject__init(msg->payload.reject);
 		break;
 	case ServerSync:
-		msg->payload.serverSync = malloc(sizeof(MumbleProto__ServerSync));
+		msg->payload.serverSync = Memory_safeMalloc(1, sizeof(MumbleProto__ServerSync));
 		mumble_proto__server_sync__init(msg->payload.serverSync);
 		break;
 	case TextMessage:
-		msg->payload.textMessage = malloc(sizeof(MumbleProto__TextMessage));
+		msg->payload.textMessage = Memory_safeMalloc(1, sizeof(MumbleProto__TextMessage));
 		mumble_proto__text_message__init(msg->payload.textMessage);
 		break;
 	case PermissionDenied:
-		msg->payload.permissionDenied = malloc(sizeof(MumbleProto__PermissionDenied));
+		msg->payload.permissionDenied = Memory_safeMalloc(1, sizeof(MumbleProto__PermissionDenied));
 		mumble_proto__permission_denied__init(msg->payload.permissionDenied);
 		break;
 	case CryptSetup:
-		msg->payload.cryptSetup = malloc(sizeof(MumbleProto__CryptSetup));
+		msg->payload.cryptSetup = Memory_safeMalloc(1, sizeof(MumbleProto__CryptSetup));
 		mumble_proto__crypt_setup__init(msg->payload.cryptSetup);
 		break;
 	case UserList:
-		msg->payload.userList = malloc(sizeof(MumbleProto__UserList));
+		msg->payload.userList = Memory_safeMalloc(1, sizeof(MumbleProto__UserList));
 		mumble_proto__user_list__init(msg->payload.userList);
 		break;
 	case UserState:
-		msg->payload.userState = malloc(sizeof(MumbleProto__UserState));
+		msg->payload.userState = Memory_safeMalloc(1, sizeof(MumbleProto__UserState));
 		mumble_proto__user_state__init(msg->payload.userState);
 		break;
+	case ChannelState:
+		msg->payload.channelState = Memory_safeMalloc(1, sizeof(MumbleProto__ChannelState));
+		mumble_proto__channel_state__init(msg->payload.channelState);
+		break;
 	case UserRemove:
-		msg->payload.userRemove = malloc(sizeof(MumbleProto__UserRemove));
+		msg->payload.userRemove = Memory_safeMalloc(1, sizeof(MumbleProto__UserRemove));
 		mumble_proto__user_remove__init(msg->payload.userRemove);
 		break;
 	case VoiceTarget:
-		msg->payload.voiceTarget = malloc(sizeof(MumbleProto__VoiceTarget));
+		msg->payload.voiceTarget = Memory_safeMalloc(1, sizeof(MumbleProto__VoiceTarget));
 		mumble_proto__voice_target__init(msg->payload.voiceTarget);
 		break;
 	case CodecVersion:
-		msg->payload.codecVersion = malloc(sizeof(MumbleProto__CodecVersion));
+		msg->payload.codecVersion = Memory_safeMalloc(1, sizeof(MumbleProto__CodecVersion));
 		mumble_proto__codec_version__init(msg->payload.codecVersion);
 		break;
-	case ChannelState:
-		msg->payload.channelState = malloc(sizeof(MumbleProto__ChannelState));
-		mumble_proto__channel_state__init(msg->payload.channelState);
+	case PermissionQuery:
+		msg->payload.permissionQuery = Memory_safeMalloc(1, sizeof(MumbleProto__PermissionQuery));
+		mumble_proto__permission_query__init(msg->payload.permissionQuery);
+		break;
+	case ChannelRemove:
+		msg->payload.channelRemove = Memory_safeMalloc(1, sizeof(MumbleProto__ChannelRemove));
+		mumble_proto__channel_remove__init(msg->payload.channelRemove);
+		break;
+	case UserStats:
+		msg->payload.userStats = Memory_safeMalloc(1, sizeof(MumbleProto__UserStats));
+		mumble_proto__user_stats__init(msg->payload.userStats);
+
+		msg->payload.userStats->from_client = Memory_safeMalloc(1, sizeof(MumbleProto__UserStats__Stats));
+		mumble_proto__user_stats__stats__init(msg->payload.userStats->from_client);
+
+		msg->payload.userStats->from_server = Memory_safeMalloc(1, sizeof(MumbleProto__UserStats__Stats));
+		mumble_proto__user_stats__stats__init(msg->payload.userStats->from_server);
+
+		msg->payload.userStats->version = Memory_safeMalloc(1, sizeof(MumbleProto__Version));
+		mumble_proto__version__init(msg->payload.userStats->version);
+
+		break;
+	case ServerConfig:
+		msg->payload.serverConfig = Memory_safeMalloc(1, sizeof(MumbleProto__ServerConfig));
+		mumble_proto__server_config__init(msg->payload.serverConfig);
 		break;
 
 	default:
@@ -285,6 +376,64 @@ message_t *Msg_create(messageType_t messageType)
 	return msg;
 }
 
+message_t *Msg_banList_create(int n_bans)
+{
+	message_t *msg = Msg_create_nopayload(BanList);
+	int i;
+
+	msg->payload.banList = Memory_safeCalloc(1, sizeof(MumbleProto__BanList));
+	mumble_proto__ban_list__init(msg->payload.banList);
+	msg->payload.banList->n_bans = n_bans;
+	msg->payload.banList->bans = Memory_safeMalloc(1, sizeof(MumbleProto__BanList__BanEntry *) * n_bans);
+	for (i = 0; i < n_bans; i++) {
+		msg->payload.banList->bans[i] = Memory_safeCalloc(1, sizeof(MumbleProto__BanList__BanEntry));
+		mumble_proto__ban_list__ban_entry__init(msg->payload.banList->bans[i]);
+	}
+	return msg;
+}
+
+void Msg_banList_addEntry(message_t *msg, int index, uint8_t *address, uint32_t mask,
+                          char *name, char *hash, char *reason, char *start, uint32_t duration)
+{
+	MumbleProto__BanList__BanEntry *entry = msg->payload.banList->bans[index];
+
+	entry->address.data = Memory_safeMalloc(1, 16);
+	memcpy(entry->address.data, address, 16);
+	entry->address.len = 16;
+	entry->mask = mask;
+	entry->name = strdup(name);
+	entry->hash = strdup(hash);
+	entry->reason = strdup(reason);
+	entry->start = strdup(start);
+	if (!entry->name || !entry->hash || !entry->reason || !entry->start)
+		Log_fatal("Out of memory");
+
+	if (duration > 0) {
+		entry->duration = duration;
+		entry->has_duration = true;
+	}
+	Log_debug("Msg_banList_addEntry: %s %s %s %s %s",
+		entry->name, entry->hash, entry->address.data, entry->reason, entry->start);
+}
+
+void Msg_banList_getEntry(message_t *msg, int index, uint8_t **address, uint32_t *mask,
+                          char **name, char **hash, char **reason, char **start, uint32_t *duration)
+{
+	MumbleProto__BanList__BanEntry *entry = msg->payload.banList->bans[index];
+
+	*address =  entry->address.data;
+	*mask = entry->mask;
+	*name = entry->name;
+	*hash = entry->hash;
+	*reason = entry->reason;
+	*start = entry->start;
+	if (entry->has_duration)
+		*duration = entry->duration;
+	else
+		*duration = 0;
+}
+
+
 void Msg_inc_ref(message_t *msg)
 {
 	msg->refcount++;
@@ -292,6 +441,8 @@ void Msg_inc_ref(message_t *msg)
 
 void Msg_free(message_t *msg)
 {
+	int i;
+
 	if (msg->refcount) msg->refcount--;
 	if (msg->refcount > 0)
 		return;
@@ -321,6 +472,8 @@ void Msg_free(message_t *msg)
 	case Authenticate:
 		if (msg->unpacked)
 			mumble_proto__authenticate__free_unpacked(msg->payload.authenticate, NULL);
+		else
+			free(msg->payload.authenticate);
 		break;
 	case Ping:
 		if (msg->unpacked)
@@ -349,6 +502,14 @@ void Msg_free(message_t *msg)
 		if (msg->unpacked)
 			mumble_proto__text_message__free_unpacked(msg->payload.textMessage, NULL);
 		else {
+			if (msg->payload.textMessage->message)
+				free(msg->payload.textMessage->message);
+			if (msg->payload.textMessage->session)
+				free(msg->payload.textMessage->session);
+			if (msg->payload.textMessage->channel_id)
+				free(msg->payload.textMessage->channel_id);
+			if (msg->payload.textMessage->tree_id)
+				free(msg->payload.textMessage->tree_id);
 			free(msg->payload.textMessage);
 		}
 		break;
@@ -382,6 +543,19 @@ void Msg_free(message_t *msg)
 			free(msg->payload.userState);
 		}
 		break;
+	case ChannelState:
+		if (msg->unpacked)
+			mumble_proto__channel_state__free_unpacked(msg->payload.channelState, NULL);
+		else {
+			if (msg->payload.channelState->name)
+				free(msg->payload.channelState->name);
+			if (msg->payload.channelState->description)
+				free(msg->payload.channelState->description);
+			if (msg->payload.channelState->links)
+				free(msg->payload.channelState->links);
+			free(msg->payload.channelState);
+		}
+		break;
 	case UserRemove:
 		if (msg->unpacked)
 			mumble_proto__user_remove__free_unpacked(msg->payload.userRemove, NULL);
@@ -403,14 +577,72 @@ void Msg_free(message_t *msg)
 			free(msg->payload.codecVersion);
 		}
 		break;
-	case ChannelState:
+	case PermissionQuery:
 		if (msg->unpacked)
-			mumble_proto__channel_state__free_unpacked(msg->payload.channelState, NULL);
+			mumble_proto__permission_query__free_unpacked(msg->payload.permissionQuery, NULL);
 		else {
-			if (msg->payload.channelState->description)
-				free(msg->payload.channelState->description);
-			free(msg->payload.channelState->name);
-			free(msg->payload.channelState);
+			free(msg->payload.permissionQuery);
+		}
+		break;
+	case ChannelRemove:
+		if (msg->unpacked)
+			mumble_proto__channel_remove__free_unpacked(msg->payload.channelRemove, NULL);
+		else {
+			free(msg->payload.channelRemove);
+		}
+		break;
+	case UserStats:
+		if (msg->unpacked)
+			mumble_proto__user_stats__free_unpacked(msg->payload.userStats, NULL);
+		else {
+			if (msg->payload.userStats->from_client)
+				free(msg->payload.userStats->from_client);
+			if (msg->payload.userStats->from_server)
+				free(msg->payload.userStats->from_server);
+			if (msg->payload.userStats->version) {
+				if (msg->payload.userStats->version->release)
+					free(msg->payload.userStats->version->release);
+				if (msg->payload.userStats->version->os)
+					free(msg->payload.userStats->version->os);
+				if (msg->payload.userStats->version->os_version)
+					free(msg->payload.userStats->version->os_version);
+
+				free(msg->payload.userStats->version);
+			}
+			if (msg->payload.userStats->celt_versions)
+				free(msg->payload.userStats->celt_versions);
+			if (msg->payload.userStats->certificates) {
+				if (msg->payload.userStats->certificates->data)
+					free(msg->payload.userStats->certificates->data);
+				free(msg->payload.userStats->certificates);
+			}
+			if (msg->payload.userStats->address.data)
+				free(msg->payload.userStats->address.data);
+
+			free(msg->payload.userStats);
+		}
+		break;
+	case ServerConfig:
+		if (msg->unpacked)
+			mumble_proto__server_config__free_unpacked(msg->payload.serverConfig, NULL);
+		else {
+			free(msg->payload.serverConfig);
+		}
+		break;
+	case BanList:
+		if (msg->unpacked)
+			mumble_proto__ban_list__free_unpacked(msg->payload.banList, NULL);
+		else {
+			for (i = 0; i < msg->payload.banList->n_bans; i++) {
+				free(msg->payload.banList->bans[i]->address.data);
+				free(msg->payload.banList->bans[i]->name);
+				free(msg->payload.banList->bans[i]->hash);
+				free(msg->payload.banList->bans[i]->reason);
+				free(msg->payload.banList->bans[i]->start);
+				free(msg->payload.banList->bans[i]);
+			}
+			free(msg->payload.banList->bans);
+			free(msg->payload.banList);
 		}
 		break;
 
@@ -421,21 +653,17 @@ void Msg_free(message_t *msg)
 	free(msg);
 }
 
-void dumpmsg(uint8_t *data, int size)
+message_t *Msg_CreateVoiceMsg(uint8_t *data, int size)
 {
-	int i, r = 0, offset = 0;
-	char buf[512];
-	
-	while (r * 8 + i < size) {
-		for (i = 0; i < 8 && r * 8 + i < size; i++) {
-			offset += sprintf(buf + offset, "%x ", data[r * 8 + i]);
-		}
-		sprintf(buf + offset, "\n");
-		printf(buf);
-		offset = 0;
-		r++;
-		i = 0;
-	} 
+	message_t *msg = NULL;
+
+	msg = Msg_create_nopayload(UDPTunnel);
+	msg->unpacked = false;
+	msg->payload.UDPTunnel = Memory_safeMalloc(1, sizeof(struct _MumbleProto__UDPTunnel));
+	msg->payload.UDPTunnel->packet.data = Memory_safeMalloc(1, size);
+	memcpy(msg->payload.UDPTunnel->packet.data, data, size);
+	msg->payload.UDPTunnel->packet.len = size;
+	return msg;
 }
 
 message_t *Msg_networkToMessage(uint8_t *data, int size)
@@ -447,104 +675,184 @@ message_t *Msg_networkToMessage(uint8_t *data, int size)
 	Msg_getPreamble(data, &messageType, &msgLen);
 
 	Log_debug("Message type %d size %d", messageType, msgLen);
-	dumpmsg(data, size);
-	
+	//dumpmsg(data, size);
+
 	switch (messageType) {
 	case Version:
 	{
-		msg = Msg_create(Version);
+		msg = Msg_create_nopayload(Version);
 		msg->unpacked = true;
 		msg->payload.version = mumble_proto__version__unpack(NULL, msgLen, msgData);
+		if (msg->payload.version == NULL)
+			goto err_out;
 		break;
 	}
-	case UDPTunnel:
+	case UDPTunnel: /* Non-standard handling of tunneled voice data */
 	{
-		msg = Msg_create(UDPTunnel);
-		msg->unpacked = true;
-		msg->payload.UDPTunnel = mumble_proto__udptunnel__unpack(NULL, msgLen, msgData);
+		msg = Msg_CreateVoiceMsg(msgData, msgLen);
 		break;
 	}
 	case Authenticate:
 	{
-		msg = Msg_create(Authenticate);
+		msg = Msg_create_nopayload(Authenticate);
 		msg->unpacked = true;
 		msg->payload.authenticate = mumble_proto__authenticate__unpack(NULL, msgLen, msgData);
+		if (msg->payload.authenticate == NULL)
+			goto err_out;
 		break;
 	}
 	case Ping:
 	{
-		msg = Msg_create(Ping);
+		msg = Msg_create_nopayload(Ping);
 		msg->unpacked = true;
 		msg->payload.ping = mumble_proto__ping__unpack(NULL, msgLen, msgData);
+		if (msg->payload.ping == NULL)
+			goto err_out;
 		break;
 	}
 	case Reject:
 	{
-		msg = Msg_create(Reject);
+		msg = Msg_create_nopayload(Reject);
 		msg->unpacked = true;
 		msg->payload.reject = mumble_proto__reject__unpack(NULL, msgLen, msgData);
+		if (msg->payload.reject == NULL)
+			goto err_out;
 		break;
 	}
 	case ServerSync:
 	{
-		msg = Msg_create(ServerSync);
+		msg = Msg_create_nopayload(ServerSync);
 		msg->unpacked = true;
 		msg->payload.serverSync = mumble_proto__server_sync__unpack(NULL, msgLen, msgData);
+		if (msg->payload.serverSync == NULL)
+			goto err_out;
 		break;
 	}
 	case TextMessage:
 	{
-		msg = Msg_create(TextMessage);
+		msg = Msg_create_nopayload(TextMessage);
 		msg->unpacked = true;
 		msg->payload.textMessage = mumble_proto__text_message__unpack(NULL, msgLen, msgData);
+		if (msg->payload.textMessage == NULL)
+			goto err_out;
 		break;
 	}
 	case PermissionDenied:
 	{
-		msg = Msg_create(PermissionDenied);
+		msg = Msg_create_nopayload(PermissionDenied);
 		msg->unpacked = true;
 		msg->payload.permissionDenied = mumble_proto__permission_denied__unpack(NULL, msgLen, msgData);
+		if (msg->payload.permissionDenied == NULL)
+			goto err_out;
 		break;
 	}
 	case CryptSetup:
 	{
-		msg = Msg_create(CryptSetup);
+		msg = Msg_create_nopayload(CryptSetup);
 		msg->unpacked = true;
 		msg->payload.cryptSetup = mumble_proto__crypt_setup__unpack(NULL, msgLen, msgData);
+		if (msg->payload.cryptSetup == NULL)
+			goto err_out;
 		break;
 	}
 	case UserList:
 	{
-		msg = Msg_create(UserList);
+		msg = Msg_create_nopayload(UserList);
 		msg->unpacked = true;
 		msg->payload.userList = mumble_proto__user_list__unpack(NULL, msgLen, msgData);
+		if (msg->payload.userList == NULL)
+			goto err_out;
 		break;
 	}
 	case UserState:
 	{
-		msg = Msg_create(UserState);
+		msg = Msg_create_nopayload(UserState);
 		msg->unpacked = true;
 		msg->payload.userState = mumble_proto__user_state__unpack(NULL, msgLen, msgData);
+		if (msg->payload.userState == NULL)
+			goto err_out;
+		break;
+	}
+	case ChannelState:
+	{
+		msg = Msg_create_nopayload(ChannelState);
+		msg->unpacked = true;
+		msg->payload.channelState = mumble_proto__channel_state__unpack(NULL, msgLen, msgData);
+		if (msg->payload.channelState == NULL)
+			goto err_out;
 		break;
 	}
 	case VoiceTarget:
 	{
-		msg = Msg_create(VoiceTarget);
+		msg = Msg_create_nopayload(VoiceTarget);
 		msg->unpacked = true;
 		msg->payload.voiceTarget = mumble_proto__voice_target__unpack(NULL, msgLen, msgData);
+		if (msg->payload.voiceTarget == NULL)
+			goto err_out;
 		break;
 	}
 	case CodecVersion:
 	{
-		msg = Msg_create(CodecVersion);
+		msg = Msg_create_nopayload(CodecVersion);
 		msg->unpacked = true;
 		msg->payload.codecVersion = mumble_proto__codec_version__unpack(NULL, msgLen, msgData);
+		if (msg->payload.codecVersion == NULL)
+			goto err_out;
+		break;
+	}
+	case PermissionQuery:
+	{
+		msg = Msg_create_nopayload(PermissionQuery);
+		msg->unpacked = true;
+		msg->payload.permissionQuery = mumble_proto__permission_query__unpack(NULL, msgLen, msgData);
+		if (msg->payload.permissionQuery == NULL)
+			goto err_out;
+		break;
+	}
+	case ChannelRemove:
+	{
+		msg = Msg_create_nopayload(ChannelRemove);
+		msg->unpacked = true;
+		msg->payload.channelRemove = mumble_proto__channel_remove__unpack(NULL, msgLen, msgData);
+		if (msg->payload.channelRemove == NULL)
+			goto err_out;
+		break;
+	}
+	case UserStats:
+	{
+		msg = Msg_create_nopayload(UserStats);
+		msg->unpacked = true;
+		msg->payload.userStats = mumble_proto__user_stats__unpack(NULL, msgLen, msgData);
+		if (msg->payload.userStats == NULL)
+			goto err_out;
+		break;
+	}
+	case UserRemove:
+	{
+		msg = Msg_create_nopayload(UserRemove);
+		msg->unpacked = true;
+		msg->payload.userRemove = mumble_proto__user_remove__unpack(NULL, msgLen, msgData);
+		if (msg->payload.userRemove == NULL)
+			goto err_out;
+		break;
+	}
+	case BanList:
+	{
+		msg = Msg_create_nopayload(BanList);
+		msg->unpacked = true;
+		msg->payload.banList = mumble_proto__ban_list__unpack(NULL, msgLen, msgData);
+		if (msg->payload.banList == NULL)
+			goto err_out;
 		break;
 	}
 
 	default:
-		Log_warn("Unsupported message %d", messageType);
+		Log_warn("Msg_networkToMessage: Unsupported message %d", messageType);
 		break;
 	}
 	return msg;
+
+err_out:
+	free(msg);
+	return NULL;
 }