X-Git-Url: http://git.code-monkey.de/?a=blobdiff_plain;f=pv%2Fview%2Fview.cpp;h=d48bbabebd4088e0b49128e00f5152577350b6b6;hb=be9e7b4bb29b6594ec2b64442748ab135b684bf8;hp=7a55bbb3fd2776fc7c38afae05864a5e2649b683;hpb=eae6e30af53f6b3e42dc5be212c82870078276b0;p=pulseview.git

diff --git a/pv/view/view.cpp b/pv/view/view.cpp
index 7a55bbb..d48bbab 100644
--- a/pv/view/view.cpp
+++ b/pv/view/view.cpp
@@ -22,9 +22,10 @@
 #include <libsigrokdecode/libsigrokdecode.h>
 #endif
 
-#include <assert.h>
-#include <limits.h>
-#include <math.h>
+#include <cassert>
+#include <climits>
+#include <cmath>
+#include <mutex>
 
 #include <QEvent>
 #include <QMouseEvent>
@@ -42,10 +43,13 @@
 #include "pv/data/logic.h"
 #include "pv/data/logicsnapshot.h"
 
+using boost::shared_lock;
+using boost::shared_mutex;
 using pv::data::SignalData;
 using std::back_inserter;
 using std::deque;
 using std::list;
+using std::lock_guard;
 using std::max;
 using std::make_pair;
 using std::min;
@@ -63,10 +67,6 @@ const double View::MinScale = 1e-15;
 
 const int View::MaxScrollValue = INT_MAX / 2;
 
-const int View::SignalHeight = 30;
-const int View::SignalMargin = 10;
-const int View::SignalSnapGridSize = 10;
-
 const QColor View::CursorAreaColour(220, 231, 243);
 
 const QSizeF View::LabelPadding(4, 0);
@@ -214,9 +214,6 @@ void View::zoom_one_to_one()
 {
 	using pv::data::SignalData;
 
-	const vector< shared_ptr<Signal> > sigs(
-		session().get_signals());
-
 	// Make a set of all the visible data objects
 	set< shared_ptr<SignalData> > visible_data = get_visible_data();
 	if (visible_data.empty())
@@ -251,52 +248,10 @@ void View::set_scale_offset(double scale, double offset)
 	scale_offset_changed();
 }
 
-vector< shared_ptr<RowItem> > View::child_items() const
-{
-	vector< shared_ptr<RowItem> > row_items;
-
-	const vector< shared_ptr<Signal> > sigs(
-		session().get_signals());
-	copy(sigs.begin(), sigs.end(), back_inserter(row_items));
-
-#ifdef ENABLE_DECODE
-	const vector< shared_ptr<DecodeTrace> > decode_sigs(
-		session().get_decode_signals());
-	copy(decode_sigs.begin(), decode_sigs.end(), back_inserter(row_items));
-#endif
-
-	stable_sort(row_items.begin(), row_items.end(),
-		[](const shared_ptr<RowItem> &a, const shared_ptr<RowItem> &b) {
-			return a->v_offset() < b->v_offset(); });
-
-	return row_items;
-}
-
-list<weak_ptr<SelectableItem> > View::selected_items() const
-{
-	list<weak_ptr<SelectableItem> > items;
-
-	// List the selected signals
-	const vector< shared_ptr<RowItem> > row_items(child_items());
-	for (shared_ptr<RowItem> r : row_items) {
-		assert(r);
-		if (r->selected())
-			items.push_back(r);
-	}
-
-	// List the selected cursors
-	if (_cursors.first()->selected())
-		items.push_back(_cursors.first());
-	if (_cursors.second()->selected())
-		items.push_back(_cursors.second());
-
-	return items;
-}
-
 set< shared_ptr<SignalData> > View::get_visible_data() const
 {
-	const vector< shared_ptr<Signal> > sigs(
-		session().get_signals());
+	shared_lock<shared_mutex> lock(session().signals_mutex());
+	const vector< shared_ptr<Signal> > &sigs(session().signals());
 
 	// Make a set of all the visible data objects
 	set< shared_ptr<SignalData> > visible_data;
@@ -365,22 +320,6 @@ const QPoint& View::hover_point() const
 	return _hover_point;
 }
 
-void View::normalize_layout()
-{
-	const vector< shared_ptr<RowItem> > row_items(child_items());
-
-	int v_min = INT_MAX;
-	for (const shared_ptr<RowItem> r : row_items)
-		v_min = min(r->v_offset(), v_min);
-
-	const int delta = -min(v_min, 0);
-	for (shared_ptr<RowItem> r : row_items)
-		r->set_v_offset(r->v_offset() + delta);
-
-	verticalScrollBar()->setSliderPosition(_v_offset + delta);
-	v_scroll_value_changed(verticalScrollBar()->sliderPosition());
-}
-
 void View::update_viewport()
 {
 	assert(_viewport);
@@ -430,9 +369,11 @@ void View::update_scroll()
 
 	// Set the vertical scrollbar
 	verticalScrollBar()->setPageStep(areaSize.height());
-	verticalScrollBar()->setRange(0,
-		_viewport->get_total_height() + SignalMargin -
-		areaSize.height());
+
+	const pair<int, int> extents = v_extents();
+	const int extra_scroll_height = (extents.second - extents.first) / 4;
+	verticalScrollBar()->setRange(extents.first - extra_scroll_height,
+		extents.first + extra_scroll_height);
 }
 
 void View::update_layout()
@@ -541,16 +482,37 @@ void View::v_scroll_value_changed(int value)
 
 void View::signals_changed()
 {
-	int offset = SignalMargin + SignalHeight;
-	const vector< shared_ptr<RowItem> > row_items(child_items());
-	for (shared_ptr<RowItem> r : row_items) {
-		r->set_owner(this);
-		r->set_v_offset(offset);
-		offset += SignalHeight + 2 * SignalMargin;
+	// Populate the traces
+	clear_child_items();
+
+	shared_lock<shared_mutex> lock(session().signals_mutex());
+	const vector< shared_ptr<Signal> > &sigs(session().signals());
+	for (auto s : sigs)
+		add_child_item(s);
+
+#ifdef ENABLE_DECODE
+	const vector< shared_ptr<DecodeTrace> > decode_sigs(
+		session().get_decode_signals());
+	for (auto s : decode_sigs)
+		add_child_item(s);
+#endif
+
+	// Create the initial layout
+	int offset = 0;
+	for (shared_ptr<RowItem> r : *this) {
+		const pair<int, int> extents = r->v_extents();
+		if (r->enabled())
+			offset += -extents.first;
+		r->force_to_v_offset(offset);
+		if (r->enabled())
+			offset += extents.second;
 	}
 
 	update_layout();
-	normalize_layout();
+
+	// Update the child widgets
+	_header->signals_updated();
+	_viewport->signals_updated();
 }
 
 void View::data_updated()
@@ -581,8 +543,7 @@ void View::on_geometry_updated()
 
 void View::on_hover_point_changed()
 {
-	const vector< shared_ptr<RowItem> > row_items(child_items());
-	for (shared_ptr<RowItem> r : row_items)
+	for (shared_ptr<RowItem> r : *this)
 		r->hover_point_changed();
 }