X-Git-Url: http://git.code-monkey.de/?a=blobdiff_plain;f=pv%2Fprop%2Fenum.cpp;h=473e3d5f1a3ad36582a3d5c770d4793f607b6124;hb=8dbbc7f0b9ea59d0f0d62225772f8a56eee125f5;hp=d4a04cbb748ae066fb66cebe29b244eca52c6a8f;hpb=819f4c25391a9c74d3d2f528d462142d5c4aad4d;p=pulseview.git diff --git a/pv/prop/enum.cpp b/pv/prop/enum.cpp index d4a04cb..473e3d5 100644 --- a/pv/prop/enum.cpp +++ b/pv/prop/enum.cpp @@ -31,56 +31,57 @@ namespace pv { namespace prop { Enum::Enum(QString name, - vector > values, + vector > values, Getter getter, Setter setter) : Property(name, getter, setter), - _values(values), - _selector(NULL) + values_(values), + selector_(NULL) { } Enum::~Enum() { - for (unsigned int i = 0; i < _values.size(); i++) - g_variant_unref(_values[i].first); } QWidget* Enum::get_widget(QWidget *parent, bool auto_commit) { - if (_selector) - return _selector; - - GVariant *const value = _getter ? _getter() : NULL; - - _selector = new QComboBox(parent); - for (unsigned int i = 0; i < _values.size(); i++) { - const pair &v = _values[i]; - _selector->addItem(v.second, qVariantFromValue((void*)v.first)); - if (value && g_variant_equal(v.first, value)) - _selector->setCurrentIndex(i); + if (selector_) + return selector_; + + if (!getter_) + return NULL; + + Glib::VariantBase variant = getter_(); + if (!variant.gobj()) + return NULL; + + selector_ = new QComboBox(parent); + for (unsigned int i = 0; i < values_.size(); i++) { + const pair &v = values_[i]; + selector_->addItem(v.second, qVariantFromValue(v.first)); + if (v.first.equal(variant)) + selector_->setCurrentIndex(i); } - g_variant_unref(value); - if (auto_commit) - connect(_selector, SIGNAL(currentIndexChanged(int)), + connect(selector_, SIGNAL(currentIndexChanged(int)), this, SLOT(on_current_item_changed(int))); - return _selector; + return selector_; } void Enum::commit() { - assert(_setter); + assert(setter_); - if (!_selector) + if (!selector_) return; - const int index = _selector->currentIndex(); + const int index = selector_->currentIndex(); if (index < 0) return; - _setter((GVariant*)_selector->itemData(index).value()); + setter_(selector_->itemData(index).value()); } void Enum::on_current_item_changed(int)