X-Git-Url: http://git.code-monkey.de/?a=blobdiff_plain;f=pv%2Fdialogs%2Fabout.cpp;h=4065de554b2e6bedf92f26855184dee0245b7dc1;hb=d52d8455db515a779b4451c223ba7aaded70951a;hp=a7778549b3438c47ab493bcb00f2516a5f9b6fae;hpb=acda14b82957d9a848a5083df6f9b98d05c29fba;p=pulseview.git

diff --git a/pv/dialogs/about.cpp b/pv/dialogs/about.cpp
index a777854..4065de5 100644
--- a/pv/dialogs/about.cpp
+++ b/pv/dialogs/about.cpp
@@ -18,21 +18,20 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
-extern "C" {
+#ifdef ENABLE_SIGROKDECODE
 #include <sigrokdecode.h>
-}
+#endif
 
 #include <QTextDocument>
 
 #include "about.h"
 #include <ui_about.h>
 
-extern "C" {
 /* __STDC_FORMAT_MACROS is required for PRIu64 and friends (in C++). */
 #define __STDC_FORMAT_MACROS
 #include <glib.h>
 #include <libsigrok/libsigrok.h>
-}
+
 
 namespace pv {
 namespace dialogs {
@@ -41,11 +40,14 @@ About::About(QWidget *parent) :
 	QDialog(parent),
 	ui(new Ui::About)
 {
-	GSList *l;
 	struct sr_dev_driver **drivers;
 	struct sr_input_format **inputs;
 	struct sr_output_format **outputs;
+
+#ifdef ENABLE_SIGROKDECODE
 	struct srd_decoder *dec;
+#endif
+
 	QString s;
 
 	ui->setupUi(this);
@@ -56,6 +58,7 @@ About::About(QWidget *parent) :
 				 .arg(QApplication::applicationVersion())
 				 .arg(tr("GNU GPL, version 2 or later"))
 				 .arg(QApplication::organizationDomain()));
+	ui->versionInfo->setOpenExternalLinks(true);
 
 	s.append("<table>");
 
@@ -90,15 +93,17 @@ About::About(QWidget *parent) :
 			.arg(QString(outputs[i]->description)));
 	}
 
+#ifdef ENABLE_SIGROKDECODE
 	s.append("<tr><td colspan=\"2\"><b>" +
 		tr("Supported protocol decoders:") +
 		"</b></td></tr>");
-	for (l = srd_decoder_list(); l; l = l->next) {
+	for (const GSList *l = srd_decoder_list(); l; l = l->next) {
 		dec = (struct srd_decoder *)l->data;
 		s.append(QString("<tr><td><i>%1</i></td><td>%2</td></tr>")
 			 .arg(QString(dec->id))
 			 .arg(QString(dec->longname)));
 	}
+#endif
 
 	s.append("</table>");