X-Git-Url: http://git.code-monkey.de/?a=blobdiff_plain;f=pv%2Fdata%2Fsegment.cpp;h=81e8dd6d356f1ae6784dd0773cf0f6cc2e2f5953;hb=fdfd5b3e246a4d4a8bcf7dbb25a6179cc86c9569;hp=a2a213afcdcbca59a6c0bba9a66632bdc78af7d8;hpb=eb8269e3b5eebdd77e6a82d42bcfdfbc3f7613a9;p=pulseview.git diff --git a/pv/data/segment.cpp b/pv/data/segment.cpp index a2a213a..81e8dd6 100644 --- a/pv/data/segment.cpp +++ b/pv/data/segment.cpp @@ -23,11 +23,10 @@ #include #include #include -#include using std::lock_guard; +using std::min; using std::recursive_mutex; -using std::vector; namespace pv { namespace data { @@ -47,8 +46,7 @@ Segment::Segment(uint64_t samplerate, unsigned int unit_size) : // Determine the number of samples we can fit in one chunk // without exceeding MaxChunkSize - chunk_size_ = std::min(MaxChunkSize, - (MaxChunkSize / unit_size_) * unit_size_); + chunk_size_ = min(MaxChunkSize, (MaxChunkSize / unit_size_) * unit_size_); // Create the initial chunk current_chunk_ = new uint8_t[chunk_size_]; @@ -119,8 +117,7 @@ void Segment::append_single_sample(void *data) // There will always be space for at least one sample in // the current chunk, so we do not need to test for space - memcpy(current_chunk_ + (used_samples_ * unit_size_), - data, unit_size_); + memcpy(current_chunk_ + (used_samples_ * unit_size_), data, unit_size_); used_samples_++; unused_samples_--; @@ -188,7 +185,7 @@ uint8_t* Segment::get_raw_samples(uint64_t start, uint64_t count) const while (count > 0) { const uint8_t* chunk = data_chunks_[chunk_num]; - uint64_t copy_size = std::min(count * unit_size_, + uint64_t copy_size = min(count * unit_size_, chunk_size_ - chunk_offs); memcpy(dest_ptr, chunk + chunk_offs, copy_size); @@ -222,16 +219,12 @@ SegmentRawDataIterator* Segment::begin_raw_sample_iteration(uint64_t start) void Segment::continue_raw_sample_iteration(SegmentRawDataIterator* it, uint64_t increase) { - lock_guard lock(mutex_); - + // Fail gracefully if we are asked to deliver data we don't have if (it->sample_index > sample_count_) - { - // Fail gracefully if we are asked to deliver data we don't have return; - } else { - it->sample_index += increase; - it->chunk_offs += (increase * unit_size_); - } + + it->sample_index += increase; + it->chunk_offs += (increase * unit_size_); if (it->chunk_offs > (chunk_size_ - 1)) { it->chunk_num++; @@ -254,6 +247,5 @@ void Segment::end_raw_sample_iteration(SegmentRawDataIterator* it) } } - } // namespace data } // namespace pv