X-Git-Url: http://git.code-monkey.de/?a=blobdiff_plain;f=ext%2Fext.c;h=12b850014f25ae4aa0fa5d8c023793583c7c91fb;hb=aea59ebcf8fdcc7acf839ff9322c697326d224ba;hp=a9f14db9fbc4fd279443949a7cc52d045cdd0c8c;hpb=1904581b325c485e96a25b43ca7bfbabe48b4c03;p=ruby-eet.git

diff --git a/ext/ext.c b/ext/ext.c
index a9f14db..12b8500 100644
--- a/ext/ext.c
+++ b/ext/ext.c
@@ -1,5 +1,5 @@
 /*
- * $Id: ext.c 64 2005-06-27 19:22:58Z tilman $
+ * $Id: ext.c 68 2005-06-29 16:50:47Z tilman $
  *
  * Copyright (c) 2005 Tilman Sauerbeck (tilman at code-monkey de)
  *
@@ -51,7 +51,7 @@ static VALUE cStream, cChunk,
              eBadElementError,
              sym_lossy, sym_level, sym_quality, sym_char, sym_short,
              sym_long_long, sym_double;
-static ID id_include, id_serialize, id_keys,
+static ID id_include, id_serialize, id_keys, id_pack,
           id_to_eet_chunks, id_to_eet_name, id_to_eet_properties,
           id_tag, id_data;
 
@@ -467,19 +467,22 @@ stream_serialize (VALUE self)
 static VALUE
 chunk_init (VALUE self, VALUE tag, VALUE data)
 {
-	unsigned long len;
+	long tag_len, data_len, tmp;
 
 	StringValue (tag);
 	StringValue (data);
 
-	if (rb_funcall (tag, id_include, 1, INT2FIX (0)) == Qtrue) \
+	if (rb_funcall (tag, id_include, 1, INT2FIX (0)) == Qtrue)
 		rb_raise (rb_eArgError, "tag must not contain binary zeroes");
 
 	/* libeet uses a signed 32bit integer to store the
 	 * chunk size, so make sure we don't overflow it
 	 */
-	len = RSTRING (tag)->len + 1 + RSTRING (data)->len;
-	if (len < 0 || len >= 2147483647L)
+	tag_len = RSTRING (tag)->len;
+	data_len = RSTRING (data)->len;
+	tmp = tag_len + 1 + data_len;
+
+	if (tmp < tag_len || tmp < data_len || tmp < 1 || tmp >= 2147483647L)
 		rb_raise (rb_eArgError, "tag or data too long");
 
 	rb_ivar_set (self, id_tag, rb_str_dup_frozen (tag));
@@ -497,11 +500,9 @@ chunk_serialize (VALUE self)
 	struct RString *tag, *data;
 
 	tmp = rb_ivar_get (self, id_tag);
-	StringValue (tmp);
 	tag = RSTRING (tmp);
 
 	tmp = rb_ivar_get (self, id_data);
-	StringValue (tmp);
 	data = RSTRING (tmp);
 
 	buf_len = 9 + tag->len + data->len;
@@ -620,7 +621,7 @@ int_to_eet_chunks (int argc, VALUE *argv, VALUE self)
 		cfmt = "q";
 
 	args[0] = tag;
-	args[1] = rb_funcall (ary, rb_intern ("pack"), 1, rb_str_new2 (cfmt));
+	args[1] = rb_funcall (ary, id_pack, 1, rb_str_new2 (cfmt));
 	chunk = rb_class_new_instance (2, args, cChunk);
 
 	return rb_ary_new3 (1, chunk);
@@ -700,6 +701,7 @@ Init_eet_ext ()
 	id_include = rb_intern ("include?");
 	id_serialize = rb_intern ("serialize");
 	id_keys = rb_intern ("keys");
+	id_pack = rb_intern ("pack");
 	id_to_eet_chunks = rb_intern ("to_eet_chunks");
 	id_to_eet_name = rb_intern ("to_eet_name");
 	id_to_eet_properties = rb_intern ("to_eet_properties");