X-Git-Url: http://git.code-monkey.de/?a=blobdiff_plain;f=bin%2Fembrace;h=bfd91c9187e631951842089f2910c4b569019d9a;hb=4a43ceec47783f0a66008d207a8479e324355d28;hp=5673f88c9a701cd72204b8cf822134d70c967e8a;hpb=8810045367f1f47685b9a80932bd58581e80482b;p=embrace.git

diff --git a/bin/embrace b/bin/embrace
index 5673f88..bfd91c9 100755
--- a/bin/embrace
+++ b/bin/embrace
@@ -110,6 +110,8 @@ module Embrace
 		def initialize(evas, label)
 			super(evas)
 
+			self.name = label
+
 			@slot = nil
 			@alpha_anim = nil
 
@@ -125,16 +127,12 @@ module Embrace
 			@img.set_file(ICON_FILE)
 			@img.set_fill(0, 0, *@img.get_size)
 
-			@label.text = label
+			@label.text = name
 			@label.set_font("VeraBd", 10)
 
 			resize(*@img.get_size)
 		end
 
-		def label
-			@label.text
-		end
-
 		# smart callbacks
 		def on_show
 			@objects.each { |o| o.show }
@@ -170,35 +168,11 @@ module Embrace
 		end
 	end
 
-	class FixedSizeArray < Array
-		def initialize(siz)
-			super
-		end
-
-		def each
-			super { |item| yield item unless item.nil? }
-		end
-
-		def delete_at(i)
-			self[i] = nil
-		end
-
-		undef :push
-		undef :<<
-		undef :unshift
-
-		undef :pop
-		undef :shift
-		undef :delete
-	end
-
 	class Container < Evas::Smart
 		class ContainerError < StandardError; end
 		class ContainerFullError < ContainerError; end
 		class ContainerLockedError < ContainerError; end
 
-		include Enumerable
-
 		def initialize(evas)
 			super
 
@@ -207,20 +181,24 @@ module Embrace
 
 			add_member(@bg)
 
-			@icons = FixedSizeArray.new(MAX_ICONS)
-			@about_to_add = []
+			@icons = []
 			@animators = []
 
-			@lock_count = 0
+			@about_to_add = 0
+			@add_lock_count = 0
+		end
+
+		def can_add?
+			!slots_left.zero? && @add_lock_count.zero?
 		end
 
-		def each
-			@icons.each { |i| yield i unless i.nil? }
+		def can_delete?
+			@about_to_add.zero? && @add_lock_count.zero?
 		end
 
 		def <<(i)
 			Kernel.raise(ContainerFullError) if slots_left.zero?
-			Kernel.raise(ContainerLockedError) if @lock_count > 0
+			Kernel.raise(ContainerLockedError) unless @add_lock_count.zero?
 
 			i.move_relative(self, 0, 0)
 			i.slot = next_slot
@@ -235,7 +213,7 @@ module Embrace
 
 			movement = Main.instance.icon_height * (slots_left - 1)
 
-			@about_to_add << i
+			@about_to_add += 1
 
 			move_time = 0.25 * slots_left
 			@animators << MoveAnimator.new(move_time, movement, i)
@@ -244,15 +222,11 @@ module Embrace
 				@animators.delete(ani)
 				@icons[i.slot] = i
 
-				# FIXME check whether we can always shift the array instead
-				#puts "really added #{i.label} now (slot #{i.slot})"
-				@about_to_add.delete(i)
+				@about_to_add -= 1
 			end
 		end
 
 		def delete(icon)
-			# icons that are placed above the one that's deleted need
-			# to be moved
 			i = @icons.index(icon)
 			return (block_given? ? yield : nil) if i.nil?
 
@@ -260,18 +234,24 @@ module Embrace
 		end
 
 		def delete_at(i)
+			Kernel.raise(ContainerLockedError) unless @about_to_add.zero?
+			Kernel.raise(ContainerLockedError) unless @add_lock_count.zero?
+
+			# icons that are placed above the one that's deleted need
+			# to be moved
+			ar = @icons[(i + 1)..-1]
+
 			@icons[i].delete
 			@icons.delete_at(i)
 
-			ar = @icons[i..-1].reject { |i| i.nil? }
-			return if ar.nil?
+			return if ar.empty?
 
-			@lock_count += 1
+			@add_lock_count += 1
 
 			@animators << MoveAnimator.new(2, Main.instance.icon_height, *ar)
 			@animators.last.on_finished do |ani|
 				@animators.delete(ani)
-				@lock_count -= 1
+				@add_lock_count -= 1
 			end
 		end
 
@@ -299,11 +279,11 @@ module Embrace
 
 		private
 		def slots_left
-			MAX_ICONS - @icons.nitems - @about_to_add.length
+			MAX_ICONS - @icons.nitems - @about_to_add
 		end
 
 		def next_slot
-			@icons.nitems + @about_to_add.length
+			@icons.nitems + @about_to_add
 		end
 	end
 
@@ -358,10 +338,6 @@ module Embrace
 		end
 
 		private
-		def add_icon(name)
-			@container << MailboxIcon.new(evas, name)
-		end
-
 		def on_timer
 			return unless @server.nil?
 
@@ -378,24 +354,12 @@ module Embrace
 				lbl = md.captures.first
 			end
 
-			found = @container.find { |i| i.label == lbl }
-
-			begin
-				if ev.count.zero?
-					unless found.nil?
-						#puts "removing icon #{lbl}"
-						@container.delete(found)
-					else
-						#puts "count == 0, but icon not found (#{lbl})"
-					end
-				elsif found.nil?
-					#puts "adding icon #{lbl}"
-					add_icon(lbl)
-				else
-					#puts "count > 0, but already there (#{lbl})"
-				end
-			rescue Exception => e
-				puts e.message
+			found = evas.find_object(lbl)
+
+			if ev.count.zero? && !found.nil? && @container.can_delete?
+				@container.delete(found)
+			elsif !ev.count.zero? && found.nil? && @container.can_add?
+				@container << MailboxIcon.new(evas, lbl)
 			end
 
 			false