Fix unsafe client removal from list at timeout.
[umurmur.git] / src / client.c
index 79300ca94a323930d62ffeeb0af82109b7edb39b..9f7576eff20051feb3d96ca36fa53ae8c19799c2 100644 (file)
@@ -1,5 +1,5 @@
-/* Copyright (C) 2009, Martin Johansson <martin@fatbob.nu>
-   Copyright (C) 2005-2009, Thorvald Natvig <thorvald@natvig.com>
+/* Copyright (C) 2009-2012, Martin Johansson <martin@fatbob.nu>
+   Copyright (C) 2005-2012, Thorvald Natvig <thorvald@natvig.com>
 
    All rights reserved.
 
 */
 #include <sys/poll.h>
 #include <sys/socket.h>
+#include <fcntl.h>
 #include <errno.h>
+#include <limits.h>
+#include <stdlib.h>
+#include <string.h>
 #include "log.h"
 #include "list.h"
 #include "client.h"
 #include "messagehandler.h"
 #include "conf.h"
 #include "channel.h"
+#include "version.h"
+#include "voicetarget.h"
+#include "ban.h"
 
-/* Version 0.2.0 XXX fixme */
-const uint32_t versionBlob = 1<<16 | 2<<8 | 0;
+extern char system_string[], version_string[];
 
 static int Client_read(client_t *client);
 static int Client_write(client_t *client);
@@ -50,11 +56,10 @@ void Client_free(client_t *client);
 
 declare_list(clients);
 static int clientcount; /* = 0 */
-static int session = 1;
 static int maxBandwidth;
 
-static int iCodecAlpha, iCodecBeta;
-static bool_t bPreferAlpha;
+int iCodecAlpha, iCodecBeta;
+bool_t bPreferAlpha;
 
 extern int udpsock;
 
@@ -86,52 +91,156 @@ int Client_getfds(struct pollfd *pollfds)
 
 void Client_janitor()
 {
-       struct dlist *itr;
+       struct dlist *itr, *save;
        int bwTop = maxBandwidth + maxBandwidth / 4;
-       list_iterate(itr, &clients) {
+       list_iterate_safe(itr, save, &clients) {
                client_t *c;
                c = list_get_entry(itr, client_t, node);
-               Log_debug("Client %s BW available %d", c->playerName, c->availableBandwidth);
+               Log_debug("Client %s BW available %d", c->username, c->availableBandwidth);
                c->availableBandwidth += maxBandwidth;
                if (c->availableBandwidth > bwTop)
                        c->availableBandwidth = bwTop;
                
                if (Timer_isElapsed(&c->lastActivity, 1000000LL * INACTICITY_TIMEOUT)) {
                        /* No activity from client - assume it is lost and close. */
-                       Log_info("Session ID %d timeout - closing", c->sessionId);
+                       Log_info_client(c, "Timeout, closing.");
                        Client_free(c);
                }
        }
+       Ban_pruneBanned();
+}
+
+void Client_codec_add(client_t *client, int codec)
+{
+       codec_t *cd = malloc(sizeof(codec_t));
+       if (cd == NULL)
+               Log_fatal("Out of memory");
+       init_list_entry(&cd->node);
+       cd->codec = codec;
+       list_add_tail(&cd->node, &client->codecs);
+}
+
+void Client_codec_free(client_t *client)
+{
+       struct dlist *itr, *save;
+       list_iterate_safe(itr, save, &client->codecs) {
+               list_del(&list_get_entry(itr, codec_t, node)->node);
+               free(list_get_entry(itr, codec_t, node));
+       }
+}
+
+codec_t *Client_codec_iterate(client_t *client, codec_t **codec_itr)
+{
+       codec_t *cd = *codec_itr;
+
+       if (list_empty(&client->codecs))
+               return NULL;
+       
+       if (cd == NULL) {
+               cd = list_get_entry(list_get_first(&client->codecs), codec_t, node);
+       } else {
+               if (list_get_next(&cd->node) == &client->codecs)
+                       cd = NULL;
+               else
+                       cd = list_get_entry(list_get_next(&cd->node), codec_t, node);
+       }
+       *codec_itr = cd;
+       return cd;
+}
+
+void Client_token_add(client_t *client, char *token_string)
+{
+       token_t *token;
+
+       if (client->tokencount >= MAX_TOKENS)
+               return;
+       token = malloc(sizeof(token_t));
+       if (token == NULL)
+               Log_fatal("Out of memory");
+       init_list_entry(&token->node);
+       token->token = strdup(token_string);
+       if (token->token == NULL)
+               Log_fatal("Out of memory");
+       list_add_tail(&token->node, &client->tokens);
+       client->tokencount++;
+}
+
+bool_t Client_token_match(client_t *client, char *str)
+{
+       token_t *token;
+       struct dlist *itr;
+       
+       if (list_empty(&client->tokens))
+               return false;
+       list_iterate(itr, &client->tokens) {
+               token = list_get_entry(itr, token_t, node);
+               if (strncasecmp(token->token, str, MAX_TOKENSIZE) == 0)
+                       return true;
+       }
+       return false;
+}
+
+void Client_token_free(client_t *client)
+{
+       struct dlist *itr, *save;
+       token_t *token;
+       
+       list_iterate_safe(itr, save, &client->tokens) {
+               token = list_get_entry(itr, token_t, node);
+               list_del(&token->node);
+               free(token->token);
+               free(token);
+       }
+       client->tokencount = 0;
 }
 
 void recheckCodecVersions()
 {
-       int codec_map[MAX_CODECS][2];
-       client_t *itr;
-       int i, codecindex, max = 0, version, current_version;
+       client_t *client_itr = NULL;
+       int max = 0, version, current_version;
        message_t *sendmsg;
+       struct dlist codec_list, *itr, *save;
+       codec_t *codec_itr, *cd;
+       bool_t found;
        
-       memset(codec_map, 0, MAX_CODECS * 2 * sizeof(int));
-       while (Client_iterate(&itr) != NULL) {
-               for (i = 0; i < itr->codec_count; i++) {
-                       for (codecindex = 0; codecindex < MAX_CODECS; codecindex++) {
-                               if (codec_map[codecindex][0] == 0)
-                                       codec_map[codecindex][0] = itr->codecs[i];
-                               if (itr->codecs[i] == codec_map[codecindex][0])
-                                       codec_map[codecindex][1]++;
+       init_list_entry(&codec_list);
+       
+       while (Client_iterate(&client_itr) != NULL) {
+               codec_itr = NULL;
+               while (Client_codec_iterate(client_itr, &codec_itr) != NULL) {
+                       found = false;
+                       list_iterate(itr, &codec_list) {
+                               cd = list_get_entry(itr, codec_t, node);
+                               if (cd->codec == codec_itr->codec) {
+                                       cd->count++;
+                                       found = true;
+                               }
+                       }
+                       if (!found) {
+                               cd = malloc(sizeof(codec_t));
+                               if (!cd)
+                                       Log_fatal("Out of memory");
+                               memset(cd, 0, sizeof(codec_t));
+                               init_list_entry(&cd->node);
+                               cd->codec = codec_itr->codec;
+                               cd->count = 1;
+                               list_add_tail(&cd->node, &codec_list);
                        }
                }
        }
-       if (codec_map[codecindex][0] == 0)
-               return;
-       for (codecindex = 0; codecindex < MAX_CODECS; codecindex++) {
-               if (codec_map[codecindex][0] == 0)
-                       break;
-               if (codec_map[codecindex][1] > max) {
-                       max = codec_map[codecindex][1];
-                       version = codec_map[codecindex][0];
+       
+       list_iterate(itr, &codec_list) {
+               cd = list_get_entry(itr, codec_t, node);
+               if (cd->count > max) {
+                       max = cd->count;
+                       version = cd->codec;
                }
        }
+       list_iterate_safe(itr, save, &codec_list) {
+               list_del(&list_get_entry(itr, codec_t, node)->node);
+               free(list_get_entry(itr, codec_t, node));
+       }
+       
        current_version = bPreferAlpha ? iCodecAlpha : iCodecBeta;
        if (current_version == version)
                return;
@@ -139,7 +248,7 @@ void recheckCodecVersions()
        // it as alpha and announce it. If another codec now got the
        // majority set it as the opposite of the currently valid bPreferAlpha
        // and announce it.
-       if (version == (uint32_t)0x8000000a)
+       if (version == (uint32_t)0x8000000b)
                bPreferAlpha = true;
        else
                bPreferAlpha = ! bPreferAlpha;
@@ -150,18 +259,42 @@ void recheckCodecVersions()
                iCodecBeta = version;
        
        sendmsg = Msg_create(CodecVersion);
-       sendmsg->payload.codecVersion->alpha = version;
-       sendmsg->payload.codecVersion->beta = version;
-       sendmsg->payload.codecVersion->beta = bPreferAlpha;
+       sendmsg->payload.codecVersion->alpha = iCodecAlpha;
+       sendmsg->payload.codecVersion->beta = iCodecBeta;
+       sendmsg->payload.codecVersion->prefer_alpha = bPreferAlpha;
        Client_send_message_except(NULL, sendmsg);
+       
+       Log_info("CELT codec switch 0x%x 0x%x (prefer 0x%x)", iCodecAlpha, iCodecBeta,
+                        bPreferAlpha ? iCodecAlpha : iCodecBeta);
+       
+}
 
+static int findFreeSessionId()
+{
+       int id;
+       client_t *itr = NULL;
+
+       for (id = 1; id < INT_MAX; id++) {
+               itr = NULL;
+               while ((itr = Client_iterate(&itr)) != NULL) {
+                       if (itr->sessionId == id)
+                               break;
+               }
+               if (itr == NULL) /* Found free id */
+                       return id;
+       }
+       return -1;
 }
 
 int Client_add(int fd, struct sockaddr_in *remote)
 {
        client_t *newclient;
        message_t *sendmsg;
-       
+
+       if (Ban_isBannedAddr((in_addr_t *)&remote->sin_addr)) {
+               Log_info("Address %s banned. Disconnecting", inet_ntoa(remote->sin_addr));
+               return -1;
+       }
        newclient = malloc(sizeof(client_t));
        if (newclient == NULL)
                Log_fatal("Out of memory");
@@ -169,19 +302,27 @@ int Client_add(int fd, struct sockaddr_in *remote)
 
        newclient->tcpfd = fd;
        memcpy(&newclient->remote_tcp, remote, sizeof(struct sockaddr_in));
-       newclient->ssl = SSL_newconnection(newclient->tcpfd, &newclient->SSLready);
+       newclient->ssl = SSLi_newconnection(&newclient->tcpfd, &newclient->SSLready);
        if (newclient->ssl == NULL) {
-               Log_warn("SSL negotiation failed");
+               Log_warn("SSL negotiation failed with %s:%d", inet_ntoa(remote->sin_addr),
+                                ntohs(remote->sin_port));
                free(newclient);
                return -1;
        }
        newclient->availableBandwidth = maxBandwidth;
        Timer_init(&newclient->lastActivity);
-       newclient->sessionId = session++; /* XXX - more elaborate? */
+       Timer_init(&newclient->connectTime);
+       Timer_init(&newclient->idleTime);
+       newclient->sessionId = findFreeSessionId();
+       if (newclient->sessionId < 0)
+               Log_fatal("Could not find a free session ID");
        
        init_list_entry(&newclient->txMsgQueue);
        init_list_entry(&newclient->chan_node);
        init_list_entry(&newclient->node);
+       init_list_entry(&newclient->voicetargets);
+       init_list_entry(&newclient->codecs);
+       init_list_entry(&newclient->tokens);
        
        list_add_tail(&newclient->node, &clients);
        clientcount++;
@@ -189,10 +330,10 @@ int Client_add(int fd, struct sockaddr_in *remote)
        /* Send version message to client */
        sendmsg = Msg_create(Version);
        sendmsg->payload.version->has_version = true;
-       sendmsg->payload.version->version = (1 << 16) | (2 << 8) | 0; /* XXX fix */
-       sendmsg->payload.version->release = strdup("1.2.0");
-       sendmsg->payload.version->os = strdup("Linux/OpenWRT");
-               
+       sendmsg->payload.version->version = PROTOCOL_VERSION;
+       sendmsg->payload.version->release = strdup(UMURMUR_VERSION);
+       sendmsg->payload.version->os = strdup(system_string);
+       sendmsg->payload.version->os_version = strdup(version_string);
        Client_send_message(newclient, sendmsg);
 
        return 0;
@@ -203,11 +344,14 @@ void Client_free(client_t *client)
        struct dlist *itr, *save;
        message_t *sendmsg;
 
-       Log_info("Disconnect client ID %d addr %s port %d", client->sessionId,
-                        inet_ntoa(client->remote_tcp.sin_addr),
-                        ntohs(client->remote_tcp.sin_port));
-
        if (client->authenticated) {
+               int leave_id;
+               leave_id = Chan_userLeave(client);
+               if (leave_id > 0) { /* Remove temp channel */
+                       sendmsg = Msg_create(ChannelRemove);
+                       sendmsg->payload.channelRemove->channel_id = leave_id;
+                       Client_send_message_except(client, sendmsg);
+               }
                sendmsg = Msg_create(UserRemove);
                sendmsg->payload.userRemove->session = client->sessionId;
                Client_send_message_except(client, sendmsg);
@@ -216,23 +360,31 @@ void Client_free(client_t *client)
                list_del(&list_get_entry(itr, message_t, node)->node);
                Msg_free(list_get_entry(itr, message_t, node));
        }
-               
+       Client_codec_free(client);
+       Voicetarget_free_all(client);
+       Client_token_free(client);
+       
        list_del(&client->node);
-       list_del(&client->chan_node);
        if (client->ssl)
-               SSL_free(client->ssl);
+               SSLi_free(client->ssl);
        close(client->tcpfd);
        clientcount--;
        if (client->release)
                free(client->release);
        if (client->os)
                free(client->os);                       
+       if (client->os_version)
+               free(client->os_version);                       
+       if (client->username)
+               free(client->username);
+       if (client->context)
+               free(client->context);
        free(client);
 }
 
 void Client_close(client_t *client)
 {
-       SSL_shutdown(client->ssl);
+       SSLi_shutdown(client->ssl);
        client->shutdown_wait = true;
 }
 
@@ -251,15 +403,15 @@ int Client_read_fd(int fd)
        client_t *client = NULL;
        
        list_iterate(itr, &clients) {
-               if(fd == list_get_entry(itr, client_t, node)->tcpfd) {
+               if (fd == list_get_entry(itr, client_t, node)->tcpfd) {
                        client = list_get_entry(itr, client_t, node);
                        break;
                }
        }
-       if (client == NULL)
-               Log_fatal("No client found for fd %d", fd);
-       
-       return Client_read(client);
+       if (client != NULL)
+               return Client_read(client);
+       else
+               return -1;
 }
 
 int Client_read(client_t *client)
@@ -280,7 +432,7 @@ int Client_read(client_t *client)
        }
        if (!client->SSLready) {
                int rc;
-               rc = SSL_nonblockaccept(client->ssl, &client->SSLready);
+               rc = SSLi_nonblockaccept(client->ssl, &client->SSLready);
                if (rc < 0) {
                        Client_free(client);
                        return -1;
@@ -290,63 +442,65 @@ int Client_read(client_t *client)
        do {
                errno = 0;
                if (!client->msgsize) 
-                       rc = SSL_read(client->ssl, client->rxbuf, 6 - client->rxcount);
-               else if (client->drainleft > 0)
-                       rc = SSL_read(client->ssl, client->rxbuf, client->drainleft > BUFSIZE ? BUFSIZE : client->drainleft);
+                       rc = SSLi_read(client->ssl, &client->rxbuf[client->rxcount], 6 - client->rxcount);
                else
-                       rc = SSL_read(client->ssl, &client->rxbuf[client->rxcount], client->msgsize);
+                       rc = SSLi_read(client->ssl, &client->rxbuf[client->rxcount], client->msgsize);
                if (rc > 0) {
                        message_t *msg;
-                       if (client->drainleft > 0)
-                               client->drainleft -= rc;
-                       else {
-                               client->rxcount += rc;
-                               if (!client->msgsize && client->rxcount >= 6) {
-                                       uint32_t *msgLen = (uint32_t *) &client->rxbuf[2];
-                                       client->msgsize = ntohl(*msgLen);
-                               }
-                               if (client->msgsize > BUFSIZE - 6 && client->drainleft == 0) {
-                                       Log_warn("Too big message received (%d). Discarding.", client->msgsize);
-                                       client->rxcount = client->msgsize = 0;
-                                       client->drainleft = client->msgsize;
-                               }
-                               else if (client->rxcount == client->msgsize + 6) { /* Got all of the message */
-                                       msg = Msg_networkToMessage(client->rxbuf, client->msgsize + 6);
-                                       /* pass messsage to handler */
-                                       if (msg)
-                                                       Mh_handle_message(client, msg);
-                                       client->rxcount = client->msgsize = 0;
-                               }
+                       client->rxcount += rc;
+                       if (!client->msgsize && client->rxcount >= 6) {
+                               uint32_t msgLen;
+                               memcpy(&msgLen, &client->rxbuf[2], sizeof(uint32_t));
+                               client->msgsize = ntohl(msgLen);
+                       }
+                       if (client->msgsize > BUFSIZE - 6) {
+                               /* XXX - figure out how to handle this. A large size here can represent two cases:
+                                * 1. A valid size. The only message that is this big is UserState message with a big texture
+                                * 2. An invalid size = protocol error, e.g. connecting with a 1.1.x client
+                                */
+                               Log_warn("Too big message received (%d bytes). Playing safe and disconnecting client %s:%d",
+                                                client->msgsize, inet_ntoa(client->remote_tcp.sin_addr), ntohs(client->remote_tcp.sin_port));
+                               Client_free(client);
+                               return -1;
+                               /* client->rxcount = client->msgsize = 0; */
+                       }
+                       else if (client->rxcount == client->msgsize + 6) { /* Got all of the message */
+                               msg = Msg_networkToMessage(client->rxbuf, client->msgsize + 6);
+                               /* pass messsage to handler */
+                               if (msg)
+                                       Mh_handle_message(client, msg);
+                               client->rxcount = client->msgsize = 0;
                        }
                } else /* rc <= 0 */ {
-                       if (SSL_get_error(client->ssl, rc) == SSL_ERROR_WANT_READ) {
+                       if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_WANT_READ) {
                                return 0;
                        }
-                       else if (SSL_get_error(client->ssl, rc) == SSL_ERROR_WANT_WRITE) {
+                       else if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_WANT_WRITE) {
                                client->readBlockedOnWrite = true;
                                return 0;
                        }
-                       else if (SSL_get_error(client->ssl, rc) == SSL_ERROR_ZERO_RETURN) {
-                               Log_warn("Error: Zero return - closing");
+                       else if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_ZERO_RETURN) {
+                               Log_info_client(client, "Connection closed by peer");
                                if (!client->shutdown_wait)
                                        Client_close(client);
                        }
                        else {
-                               if (SSL_get_error(client->ssl, rc) == SSL_ERROR_SYSCALL) {
-                                       /* Hmm. This is where we end up when the client closes its connection.
-                                        * Kind of strange...
-                                        */
-                                       Log_info("Connection closed by peer");
+                               if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_SYSCALL) {
+                                       Log_info_client(client,"Error: %s  - Closing connection", strerror(errno));
+                               }
+                               else if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_CONNRESET) {
+                                       Log_info_client(client, "Connection reset by peer");
                                }
                                else {
-                                       Log_warn("SSL error: %d - Closing connection.", SSL_get_error(client->ssl, rc));
+                                       Log_info_client(client, "SSL error: %d - Closing connection", SSLi_get_error(client->ssl, rc));
                                }
                                Client_free(client);
                                return -1;
                        }
                }
-       } while (SSL_pending(client->ssl));
-       return 0;       
+       } while (SSLi_data_pending(client->ssl));
+       
+       return 0;
 }
 
 int Client_write_fd(int fd)
@@ -360,10 +514,10 @@ int Client_write_fd(int fd)
                        break;
                }
        }
-       if (client == NULL)
-               Log_fatal("No client found for fd %d", fd);
-       Client_write(client);
-       return 0;
+       if (client != NULL)
+               return Client_write(client);
+       else
+               return -1;
 }
 
 int Client_write(client_t *client)
@@ -375,25 +529,30 @@ int Client_write(client_t *client)
                Log_debug("Client_write: readBlockedOnWrite == true");
                return Client_read(client);
        }
-       rc = SSL_write(client->ssl, &client->txbuf[client->txcount], client->txsize - client->txcount);
+       rc = SSLi_write(client->ssl, &client->txbuf[client->txcount], client->txsize - client->txcount);
        if (rc > 0) {
                client->txcount += rc;
                if (client->txcount == client->txsize)
                        client->txsize = client->txcount = 0;
        }
        else if (rc < 0) {
-               if (SSL_get_error(client->ssl, rc) == SSL_ERROR_WANT_READ) {
+               if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_WANT_READ) {
                        client->writeBlockedOnRead = true;
                        return 0;
                }
-               else if (SSL_get_error(client->ssl, rc) == SSL_ERROR_WANT_WRITE) {
+               else if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_WANT_WRITE) {
                        return 0;
                }
                else {
-                       if (SSL_get_error(client->ssl, rc) == SSL_ERROR_SYSCALL)
-                               Log_warn("Client_write: Error: %s  - Closing connection", strerror(errno));
-                       else
-                               Log_warn("Client_write: SSL error: %d - Closing connection.", SSL_get_error(client->ssl, rc));
+                       if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_SYSCALL) {
+                               Log_info_client(client, "Error: %s  - Closing connection", strerror(errno));
+                       }
+                       else if (SSLi_get_error(client->ssl, rc) == SSLI_ERROR_CONNRESET) {
+                               Log_info_client(client, "Connection reset by peer");
+                       }
+                       else {
+                               Log_info_client(client, "SSL error: %d - Closing connection.", SSLi_get_error(client->ssl, rc));
+                       }
                        Client_free(client);
                        return -1;
                }
@@ -408,6 +567,15 @@ int Client_write(client_t *client)
        return 0;
 }
 
+int Client_send_message_ver(client_t *client, message_t *msg, uint32_t version)
+{
+       if ((version == 0) || (client->version >= version) ||
+               ((version & 0x80000000) && (client->version < (~version))))
+               return Client_send_message(client, msg);
+       else
+               Msg_free(msg);
+}
+
 int Client_send_message(client_t *client, message_t *msg)
 {
        if (!client->authenticated && msg->messageType != Version) {
@@ -426,7 +594,6 @@ int Client_send_message(client_t *client, message_t *msg)
                Log_debug("Queueing message");
        } else {
                int len;
-               memset(client->txbuf, 0, BUFSIZE);
                len = Msg_messageToNetwork(msg, client->txbuf);
                doAssert(len < BUFSIZE);
 
@@ -468,7 +635,7 @@ int Client_send_message_except(client_t *client, message_t *msg)
                if (itr != client) {
                        if (count++ > 0)
                                Msg_inc_ref(msg); /* One extra reference for each new copy */
-                       Log_debug("Msg %d to %s refcount %d",  msg->messageType, itr->playerName, msg->refcount);
+                       Log_debug("Msg %d to %s refcount %d",  msg->messageType, itr->username, msg->refcount);
                        Client_send_message(itr, msg);
                }
        }
@@ -481,6 +648,29 @@ int Client_send_message_except(client_t *client, message_t *msg)
        return 0;
 }
 
+int Client_send_message_except_ver(client_t *client, message_t *msg, uint32_t version)
+{
+       client_t *itr = NULL;
+       int count = 0;
+       
+       Msg_inc_ref(msg); /* Make sure a reference is held during the whole iteration. */
+       while (Client_iterate(&itr) != NULL) {
+               if (itr != client) {
+                       if (count++ > 0)
+                               Msg_inc_ref(msg); /* One extra reference for each new copy */
+                       Log_debug("Msg %d to %s refcount %d",  msg->messageType, itr->username, msg->refcount);
+                       Client_send_message_ver(itr, msg, version);
+               }
+       }
+       Msg_free(msg); /* Free our reference to the message */
+       
+       if (count == 0)
+               Msg_free(msg); /* If only 1 client is connected then no message is passed
+                                               * to Client_send_message(). Free it here. */
+               
+       return 0;
+}
+
 static bool_t checkDecrypt(client_t *client, const uint8_t *encrypted, uint8_t *plain, unsigned int len)
 {
        if (CryptState_isValid(&client->cryptState) &&
@@ -493,7 +683,7 @@ static bool_t checkDecrypt(client_t *client, const uint8_t *encrypted, uint8_t *
                        Timer_restart(&client->cryptState.tLastRequest);
                        
                        sendmsg = Msg_create(CryptSetup);
-                       Log_info("Requesting voice channel crypt resync");
+                       Log_info_client(client, "Requesting voice channel crypt resync");               
                        Client_send_message(client, sendmsg);
                }
        }
@@ -533,11 +723,11 @@ int Client_read_udp()
        /* Ping packet */
        if (len == 12 && *encrypted == 0) {
                uint32_t *ping = (uint32_t *)encrypted;
-               ping[0] = htons(versionBlob);
+               ping[0] = htonl((uint32_t)PROTOCOL_VERSION);
                // 1 and 2 will be the timestamp, which we return unmodified.
-               ping[3] = htons((uint32_t)clientcount);
-               ping[4] = htons((uint32_t)getIntConf(MAX_CLIENTS));
-               ping[5] = htons((uint32_t)getIntConf(MAX_BANDWIDTH));
+               ping[3] = htonl((uint32_t)clientcount);
+               ping[4] = htonl((uint32_t)getIntConf(MAX_CLIENTS));
+               ping[5] = htonl((uint32_t)getIntConf(MAX_BANDWIDTH));
                
                sendto(udpsock, encrypted, 6 * sizeof(uint32_t), 0, (struct sockaddr *)&from, fromlen);
                return 0;
@@ -558,37 +748,51 @@ int Client_read_udp()
                        if (itr->remote_tcp.sin_addr.s_addr == from.sin_addr.s_addr) {
                                if (checkDecrypt(itr, encrypted, buffer, len)) {
                                        itr->key = key;
-                                       Log_info("New UDP connection from %s port %d sessionId %d", inet_ntoa(from.sin_addr), ntohs(from.sin_port), itr->sessionId);
+                                       Log_info_client(itr, "New UDP connection port %d", ntohs(from.sin_port));
                                        memcpy(&itr->remote_udp, &from, sizeof(struct sockaddr_in));
                                        break;
                                }
-                               else Log_warn("Bad cryptstate from peer");
                        }
                } /* while */
        }
-       if (itr == NULL) {
+       if (itr == NULL) { /* Couldn't find this peer among connected clients */
                goto out;
        }
        
+       itr->bUDP = true;
+       len -= 4; /* Adjust for crypt header */
        msgType = (UDPMessageType_t)((buffer[0] >> 5) & 0x7);
        switch (msgType) {
        case UDPVoiceSpeex:
        case UDPVoiceCELTAlpha:
        case UDPVoiceCELTBeta:
-               // u->bUdp = true;
                Client_voiceMsg(itr, buffer, len);
                break;
        case UDPPing:
+               Log_debug("UDP Ping reply len %d", len);
                Client_send_udp(itr, buffer, len);
                break;
        default:
                Log_debug("Unknown UDP message type from %s port %d", inet_ntoa(from.sin_addr), ntohs(from.sin_port));
                break;
        }
+       
 out:
        return 0;
 }
 
+static inline void Client_send_voice(client_t *src, client_t *dst, uint8_t *data, int len, int poslen)
+{
+       if (IS_AUTH(dst) && dst != src && !dst->deaf && !dst->self_deaf) {
+               if (poslen > 0 && /* Has positional data */
+                       src->context != NULL && dst->context != NULL && /* ...both source and destination has context */
+                       strcmp(src->context, dst->context) == 0) /* ...and the contexts match */
+                       Client_send_udp(dst, data, len);
+               else 
+                       Client_send_udp(dst, data, len - poslen);
+       }
+}
+
 /* Handle decrypted voice message */
 int Client_voiceMsg(client_t *client, uint8_t *data, int len)
 {
@@ -599,11 +803,12 @@ int Client_voiceMsg(client_t *client, uint8_t *data, int len)
        unsigned int target = data[0] & 0x1f;
        unsigned int poslen, counter;
        int offset, packetsize;
-
+       voicetarget_t *vt;
+       
        channel_t *ch = (channel_t *)client->channel;
        struct dlist *itr;
        
-       if (!client->authenticated || client->mute)
+       if (!client->authenticated || client->mute || client->self_mute)
                goto out;
        
        packetsize = 20 + 8 + 4 + len;
@@ -611,18 +816,20 @@ int Client_voiceMsg(client_t *client, uint8_t *data, int len)
                goto out; /* Discard */
        client->availableBandwidth -= packetsize;
        
+       Timer_restart(&client->idleTime);
+       
        counter = Pds_get_numval(pdi); /* step past session id */
        do {
                counter = Pds_next8(pdi);
                offset = Pds_skip(pdi, counter & 0x7f);
        } while ((counter & 0x80) && offset > 0);
 
-       poslen = pdi->maxsize - pdi->offset; /* XXX - Add stripping of positional audio */
+       poslen = pdi->maxsize - pdi->offset; /* For stripping of positional info */
        
        Pds_add_numval(pds, client->sessionId);
        Pds_append_data_nosize(pds, data + 1, len - 1);
        
-       if (target & 0x1f) { /* Loopback */
+       if (target == 0x1f) { /* Loopback */
                buffer[0] = (uint8_t) type;
                Client_send_udp(client, buffer, pds->offset + 1);
        }
@@ -635,12 +842,68 @@ int Client_voiceMsg(client_t *client, uint8_t *data, int len)
                list_iterate(itr, &ch->clients) {
                        client_t *c;
                        c = list_get_entry(itr, client_t, chan_node);
-                       if (c != client && !c->deaf) {
-                               Client_send_udp(c, buffer, pds->offset + 1);
+                       Client_send_voice(client, c, buffer, pds->offset + 1, poslen);
+               }
+       } else if ((vt = Voicetarget_get_id(client, target)) != NULL) { /* Targeted whisper */
+               int i;
+               channel_t *ch;
+               /* Channels */
+               for (i = 0; i < TARGET_MAX_CHANNELS && vt->channels[i].channel != -1; i++) {
+                       buffer[0] = (uint8_t) (type | 1);
+                       Log_debug("Whisper channel %d", vt->channels[i]);
+                       ch = Chan_fromId(vt->channels[i].channel);
+                       if (ch == NULL)
+                               continue;
+                       list_iterate(itr, &ch->clients) {
+                               client_t *c;
+                               c = list_get_entry(itr, client_t, chan_node);
+                               Client_send_voice(client, c, buffer, pds->offset + 1, poslen);
+                       }
+                       /* Channel links */
+                       if (vt->channels[i].linked && !list_empty(&ch->channel_links)) {
+                               struct dlist *ch_itr;
+                               list_iterate(ch_itr, &ch->channel_links) {
+                                       channel_t *ch_link;
+                                       ch_link = list_get_entry(ch_itr, channel_t, link_node);
+                                       list_iterate(itr, &ch_link->clients) {
+                                               client_t *c;
+                                               c = list_get_entry(itr, client_t, chan_node);
+                                               Log_debug("Linked voice from %s -> %s", ch->name, ch_link->name);
+                                               Client_send_voice(client, c, buffer, pds->offset + 1, poslen);
+                                       }
+                               }
+                       }
+                       /* children */
+                       if (vt->channels[i].children) {
+                               struct dlist chanlist, *ch_itr;
+                               init_list_entry(&chanlist);
+                               Chan_buildTreeList(ch, &chanlist);
+                               list_iterate(ch_itr, &chanlist) {
+                                       channel_t *sub;
+                                       sub = list_get_entry(ch_itr, channellist_t, node)->chan;
+                                       list_iterate(itr, &sub->clients) {
+                                               client_t *c;
+                                               c = list_get_entry(itr, client_t, chan_node);
+                                               Log_debug("Child voice from %s -> %s", ch->name, sub->name);
+                                               Client_send_voice(client, c, buffer, pds->offset + 1, poslen);
+                                       }
+                               }
+                               Chan_freeTreeList(&chanlist);
+                       }
+               }                       
+               /* Sessions */
+               for (i = 0; i < TARGET_MAX_SESSIONS && vt->sessions[i] != -1; i++) {
+                       client_t *c;
+                       buffer[0] = (uint8_t) (type | 2);
+                       Log_debug("Whisper session %d", vt->sessions[i]);
+                       while (Client_iterate(&c) != NULL) {
+                               if (c->sessionId == vt->sessions[i]) {
+                                       Client_send_voice(client, c, buffer, pds->offset + 1, poslen);
+                                       break;
+                               }
                        }
                }
        }
-       /* XXX - Add targeted whisper here */
 out:
        Pds_free(pds);
        Pds_free(pdi);
@@ -653,7 +916,8 @@ static int Client_send_udp(client_t *client, uint8_t *data, int len)
 {
        uint8_t *buf, *mbuf;
 
-       if (client->remote_udp.sin_port != 0 && CryptState_isValid(&client->cryptState)) {
+       if (client->remote_udp.sin_port != 0 && CryptState_isValid(&client->cryptState) &&
+               client->bUDP) {
 #if defined(__LP64__)
                buf = mbuf = malloc(len + 4 + 16);
                buf += 4;
@@ -670,12 +934,7 @@ static int Client_send_udp(client_t *client, uint8_t *data, int len)
                free(mbuf);
        } else {
                message_t *msg;
-               buf = malloc(len);
-               memcpy(buf, data, len);
-               msg = Msg_create(UDPTunnel);
-               
-               msg->payload.UDPTunnel->packet.data = buf;
-               msg->payload.UDPTunnel->packet.len = len;
+               msg = Msg_CreateVoiceMsg(data, len);
                Client_send_message(client, msg);
        }
        return 0;