* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
*/
#include <QApplication>
#include <QMouseEvent>
#include <QTouchEvent>
-#include "rowitem.hpp"
+#include "tracetreeitem.hpp"
#include "view.hpp"
#include "viewwidget.hpp"
using std::vector;
namespace pv {
-namespace view {
+namespace views {
+namespace TraceView {
ViewWidget::ViewWidget(View &parent) :
QWidget(&parent),
const auto items = this->items();
for (auto &i : items)
i->select(false);
- update();
+}
+
+void ViewWidget::item_hover(const shared_ptr<ViewItem> &item)
+{
+ (void)item;
}
void ViewWidget::item_clicked(const shared_ptr<ViewItem> &item)
bool ViewWidget::accept_drag() const
{
const vector< shared_ptr<TimeItem> > items(view_.time_items());
+ const vector< shared_ptr<TraceTreeItem> > trace_tree_items(
+ view_.list_by_type<TraceTreeItem>());
- const bool any_row_items_selected = any_of(view_.begin(), view_.end(),
- [](const shared_ptr<RowItem> &r) { return r->selected(); });
+ const bool any_row_items_selected = any_of(
+ trace_tree_items.begin(), trace_tree_items.end(),
+ [](const shared_ptr<TraceTreeItem> &r) { return r->selected(); });
const bool any_time_items_selected = any_of(items.begin(), items.end(),
[](const shared_ptr<TimeItem> &i) { return i->selected(); });
- if (any_row_items_selected && !any_time_items_selected)
- {
+ if (any_row_items_selected && !any_time_items_selected) {
// Check all the drag items share a common owner
- RowItemOwner *item_owner = nullptr;
- for (shared_ptr<RowItem> r : view_)
+ TraceTreeItemOwner *item_owner = nullptr;
+ for (shared_ptr<TraceTreeItem> r : trace_tree_items)
if (r->dragging()) {
if (!item_owner)
item_owner = r->owner();
- else if(item_owner != r->owner())
+ else if (item_owner != r->owner())
return false;
}
return true;
- }
- else if (any_time_items_selected && !any_row_items_selected)
- {
+ } else if (any_time_items_selected && !any_row_items_selected) {
return true;
}
bool item_dragged = false;
// Drag the row items
- RowItemOwner *item_owner = nullptr;
- for (std::shared_ptr<RowItem> r : view_)
+ const vector< shared_ptr<RowItem> > row_items(
+ view_.list_by_type<RowItem>());
+ for (shared_ptr<RowItem> r : row_items)
if (r->dragging()) {
- item_owner = r->owner();
r->drag_by(delta);
// Ensure the trace is selected
r->select();
+
+ item_dragged = true;
}
+ // If an item is being dragged, update the stacking
+ TraceTreeItemOwner *item_owner = nullptr;
+ const vector< shared_ptr<TraceTreeItem> > trace_tree_items(
+ view_.list_by_type<TraceTreeItem>());
+ for (shared_ptr<TraceTreeItem> i : trace_tree_items)
+ if (i->dragging())
+ item_owner = i->owner();
+
if (item_owner) {
- item_dragged = true;
item_owner->restack_items();
- for (const auto &r : *item_owner)
- r->animate_to_layout_v_offset();
+ for (shared_ptr<TraceTreeItem> i : trace_tree_items)
+ i->animate_to_layout_v_offset();
}
// Drag the time items
drag();
selection_changed();
- update();
}
void ViewWidget::mouse_left_release_event(QMouseEvent *event)
i->drag_release();
if (item_dragging_)
- view_.restack_all_row_items();
- else
- {
+ view_.restack_all_trace_tree_items();
+ else {
if (!ctrl_pressed) {
for (shared_ptr<ViewItem> i : items)
if (mouse_down_item_ != i)
item_dragging_ = false;
}
-bool ViewWidget::touch_event(QTouchEvent *e)
+bool ViewWidget::touch_event(QTouchEvent *event)
{
- (void)e;
+ (void)event;
+
return false;
}
{
assert(event);
- mouse_down_point_ = event->pos();
- mouse_down_item_ = get_mouse_over_item(event->pos());
-
- if (event->button() & Qt::LeftButton)
+ /* Ignore right click events as they will open context menus when
+ * used on trace labels. Those menus prevent ViewWidget::mouseReleaseEvent()
+ * to be triggered upon button release, making mouse_down_item_
+ * hold the last reference to a view item that might have been deleted
+ * from the context menu, preventing it from being freed as intended.
+ */
+ if (event->button() & Qt::LeftButton) {
+ mouse_down_point_ = event->pos();
+ mouse_down_item_ = get_mouse_over_item(event->pos());
mouse_left_press_event(event);
+ }
}
void ViewWidget::mouseReleaseEvent(QMouseEvent *event)
{
assert(event);
+
if (event->button() & Qt::LeftButton)
mouse_left_release_event(event);
assert(event);
mouse_point_ = event->pos();
- if (!(event->buttons() & Qt::LeftButton))
- return;
-
- if ((event->pos() - mouse_down_point_).manhattanLength() <
- QApplication::startDragDistance())
- return;
+ if (!event->buttons())
+ item_hover(get_mouse_over_item(event->pos()));
+ else if (event->buttons() & Qt::LeftButton) {
+ if (!item_dragging_) {
+ if ((event->pos() - mouse_down_point_).manhattanLength() <
+ QApplication::startDragDistance())
+ return;
- if (!accept_drag())
- return;
+ if (!accept_drag())
+ return;
- // Do the drag
- item_dragging_ = true;
- drag_items(event->pos() - mouse_down_point_);
+ item_dragging_ = true;
+ }
- update();
+ // Do the drag
+ drag_items(event->pos() - mouse_down_point_);
+ }
}
void ViewWidget::leaveEvent(QEvent*)
update();
}
-} // namespace view
+} // namespace TraceView
+} // namespace views
} // namespace pv