DecodeTrace: Tidied up get_sample_range

[pulseview.git] / pv / view / decodetrace.cpp

diff --git a/pv/view/decodetrace.cpp b/pv/view/decodetrace.cpp
index b0e08f6f1cfa16fb957284b99232f4206b7eea67..fb4b7c29844fa5be0cc35b23fd45db6f50d8ea45 100644 (file)
--- a/pv/view/decodetrace.cpp
+++ b/pv/view/decodetrace.cpp
@@ -33,6 +33,7 @@ extern "C" {
 #include <QLabel>
 #include <QMenu>
 #include <QPushButton>
+#include <QToolTip>
 
 #include "decodetrace.h"
 
@@ -44,6 +45,7 @@ extern "C" {
 #include <pv/data/decode/annotation.h>
 #include <pv/view/logicsignal.h>
 #include <pv/view/view.h>
+#include <pv/view/viewport.h>
 #include <pv/widgets/decodergroupbox.h>
 #include <pv/widgets/decodermenu.h>
 
@@ -183,7 +185,7 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
        assert(_decoder_stack);
        const vector<Row> rows(_decoder_stack->get_visible_rows());
 
-       _cur_row_headings.clear();
+       _visible_rows.clear();
        for (size_t i = 0; i < rows.size(); i++)
        {
                const Row &row = rows[i];
@@ -204,7 +206,7 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
                                        base_colour);
                        y += _row_height;
 
-                       _cur_row_headings.push_back(row.title());
+                       _visible_rows.push_back(rows[i]);
                }
        }
 
@@ -220,7 +222,7 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
 
        assert(_row_height);
 
-       for (size_t i = 0; i < _cur_row_headings.size(); i++)
+       for (size_t i = 0; i < _visible_rows.size(); i++)
        {
                const int y = i * _row_height + get_y();
 
@@ -239,7 +241,7 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
 
                const QRect r(left + ArrowSize * 2, y - _row_height / 2,
                        right - left, _row_height);
-               const QString h(_cur_row_headings[i]);
+               const QString h(_visible_rows[i].title());
                const int f = Qt::AlignLeft | Qt::AlignVCenter |
                        Qt::TextDontClip;
 
@@ -530,24 +532,92 @@ double DecodeTrace::get_samples_per_pixel() const
        return samplerate * scale;
 }
 
-pair<uint64_t, uint64_t> DecodeTrace::get_sample_range(int x_start, int x_end) const
+pair<uint64_t, uint64_t> DecodeTrace::get_sample_range(
+       int x_start, int x_end) const
 {
-       assert(_view);
-       assert(_decoder_stack);
-
        const double samples_per_pixel = get_samples_per_pixel();
        const double pixels_offset = get_pixels_offset();
 
-       uint64_t start, end;
-
-       start = (uint64_t)max((x_start + pixels_offset) * samples_per_pixel, 0.0);
-       end = (uint64_t)max((x_end + pixels_offset) * samples_per_pixel, 0.0);
+       const uint64_t start = (uint64_t)max(
+               (x_start + pixels_offset) * samples_per_pixel, 0.0);
+       const uint64_t end = (uint64_t)max(
+               (x_end + pixels_offset) * samples_per_pixel, 0.0);
 
        return make_pair(start, end);
 }
 
+int DecodeTrace::get_row_at_point(const QPoint &point)
+{
+       if (!_row_height)
+               return -1;
+
+       const int row = (point.y() - get_y() + _row_height / 2) / _row_height;
+       if (row < 0 || row >= (int)_visible_rows.size())
+               return -1;
+
+       return row;
+}
+
+const QString DecodeTrace::get_annotation_at_point(const QPoint &point)
+{
+       using namespace pv::data::decode;
+
+       if (!enabled())
+               return QString();
+
+       const pair<uint64_t, uint64_t> sample_range =
+               get_sample_range(point.x(), point.x() + 1);
+       const int row = get_row_at_point(point);
+       if (row < 0)
+               return QString();
+
+       vector<pv::data::decode::Annotation> annotations;
+
+       assert(_decoder_stack);
+       _decoder_stack->get_annotation_subset(annotations, _visible_rows[row],
+               sample_range.first, sample_range.second);
+
+       return (annotations.empty()) ?
+               QString() : annotations[0].annotations().front();
+}
+
+void DecodeTrace::hide_hover_annotation()
+{
+       QToolTip::hideText();
+}
+
 void DecodeTrace::hover_point_changed()
 {
+       QPoint hp = _view->hover_point();
+       QString ann = get_annotation_at_point(hp);
+
+       assert(_view);
+       assert(_row_height);
+
+       if (ann.isEmpty()) {
+               hide_hover_annotation();
+               return;
+       }
+
+       const int hover_row = get_row_at_point(hp);
+
+       QFontMetrics m(QToolTip::font());
+       const QRect text_size = m.boundingRect(QRect(), 0, ann);
+
+       // This is OS-specific and unfortunately we can't query it, so
+       // use an approximation to at least try to minimize the error.
+       const int padding = 8;
+
+       // Make sure the tool tip doesn't overlap with the mouse cursor.
+       // If it did, the tool tip would constantly hide and re-appear.
+       // We also push it up by one row so that it appears above the
+       // decode trace, not below.
+       hp.setX(hp.x() - (text_size.width() / 2) - padding);
+
+       hp.setY(get_y() - (_row_height / 2) + (hover_row * _row_height)
+               - _row_height - text_size.height());
+
+       QToolTip::showText(_view->viewport()->mapToGlobal(hp), ann);
 }
 
 void DecodeTrace::create_decoder_form(int index,