Fix bug #477 by keeping track of visible rows, not just titles

[pulseview.git] / pv / view / decodetrace.cpp

diff --git a/pv/view/decodetrace.cpp b/pv/view/decodetrace.cpp
index f450f45b819207f1871aeb4f3dbf574e84d5d325..e290e55fe2ae68fa72c0f9cfefae29e371c5d72c 100644 (file)
--- a/pv/view/decodetrace.cpp
+++ b/pv/view/decodetrace.cpp
@@ -33,6 +33,7 @@ extern "C" {
 #include <QLabel>
 #include <QMenu>
 #include <QPushButton>
+#include <QToolTip>
 
 #include "decodetrace.h"
 
@@ -183,7 +184,7 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
        assert(_decoder_stack);
        const vector<Row> rows(_decoder_stack->get_visible_rows());
 
-       _cur_row_headings.clear();
+       _visible_rows.clear();
        for (size_t i = 0; i < rows.size(); i++)
        {
                const Row &row = rows[i];
@@ -204,7 +205,7 @@ void DecodeTrace::paint_mid(QPainter &p, int left, int right)
                                        base_colour);
                        y += _row_height;
 
-                       _cur_row_headings.push_back(row.title());
+                       _visible_rows.push_back(rows[i]);
                }
        }
 
@@ -220,7 +221,7 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
 
        assert(_row_height);
 
-       for (size_t i = 0; i < _cur_row_headings.size(); i++)
+       for (size_t i = 0; i < _visible_rows.size(); i++)
        {
                const int y = i * _row_height + get_y();
 
@@ -239,7 +240,7 @@ void DecodeTrace::paint_fore(QPainter &p, int left, int right)
 
                const QRect r(left + ArrowSize * 2, y - _row_height / 2,
                        right - left, _row_height);
-               const QString h(_cur_row_headings[i]);
+               const QString h(_visible_rows[i].title());
                const int f = Qt::AlignLeft | Qt::AlignVCenter |
                        Qt::TextDontClip;
 
@@ -546,6 +547,94 @@ pair<uint64_t, uint64_t> DecodeTrace::get_sample_range(int x_start, int x_end) c
        return make_pair(start, end);
 }
 
+bool DecodeTrace::hover_point_is_over_trace()
+{
+       assert(_view);
+       assert(_row_height);
+
+       // Note: if _row_height is valid then _cur_row_headings is valid, too,
+       // as both are set in paint_mid().
+
+       // Note: hp.x will be 0 if the cursor is above the header area,
+       // so we set trace.left to 1 to exclude this.
+
+       QRect trace(1, get_y() - (_row_height/2),
+               _view->width(), _row_height * _visible_rows.size());
+
+       // Note: We don't need to check for _row_height being 0 here but
+       // we do it anyway to be more robust.
+
+       return _row_height && enabled() && trace.contains(_view->hover_point());
+}
+
+int DecodeTrace::get_row_at_hover_point()
+{
+       assert(_view);
+       assert(_row_height);
+       assert(_decoder_stack);
+
+       QPoint hp = _view->hover_point();
+       int hover_row = (hp.y() - get_y() + (_row_height/2)) / _row_height;
+
+       return min(hover_row, (int)_visible_rows.size() - 1);
+}
+
+const QString DecodeTrace::get_annotation_at_hover_point()
+{
+       using namespace pv::data::decode;
+
+       assert(_view);
+       QPoint hp = _view->hover_point();
+
+       pair<uint64_t, uint64_t> sample_range = get_sample_range(hp.x(), hp.x() + 1);
+
+       const int hover_row = get_row_at_hover_point();
+
+       vector<pv::data::decode::Annotation> annotations;
+
+       assert(_decoder_stack);
+       _decoder_stack->get_annotation_subset(annotations, _visible_rows[hover_row],
+               sample_range.first, sample_range.second);
+
+       return (annotations.empty()) ?
+               QString() : annotations[0].annotations().front();
+}
+
+void DecodeTrace::show_hover_annotation()
+{
+       QString ann = get_annotation_at_hover_point();
+
+       assert(_view);
+       assert(_row_height);
+       assert(_text_height);
+
+       if (!ann.isEmpty()) {
+               const int hover_row = get_row_at_hover_point();
+
+               // Make sure the tool tip doesn't overlap with the mouse cursor.
+               // If it did, the tool tip would constantly hide and re-appear.
+               QPoint hp = _view->hover_point();
+               hp.setY(get_y() - (_row_height/2) +
+                       (hover_row * _row_height) - _text_height);
+
+               QToolTip::showText(_view->mapToGlobal(hp), ann);
+       } else
+               hide_hover_annotation();
+}
+
+void DecodeTrace::hide_hover_annotation()
+{
+       QToolTip::hideText();
+}
+
+void DecodeTrace::hover_point_changed()
+{
+       if (hover_point_is_over_trace())
+               show_hover_annotation();
+       else
+               hide_hover_annotation();
+}
+
 void DecodeTrace::create_decoder_form(int index,
        shared_ptr<data::decode::Decoder> &dec, QWidget *parent,
        QFormLayout *form)