#include <extdef.h>
+#include <tuple>
+
#include <boost/functional/hash.hpp>
#include <QAction>
#include <pv/data/decode/annotation.h>
#include <pv/view/logicsignal.h>
#include <pv/view/view.h>
+#include <pv/view/viewport.h>
#include <pv/widgets/decodergroupbox.h>
#include <pv/widgets/decodermenu.h>
using std::min;
using std::pair;
using std::shared_ptr;
+using std::tie;
using std::vector;
namespace pv {
QPainter &p, QColor text_color, int h, int left, int right, int y,
size_t base_colour) const
{
- const double samples_per_pixel = get_samples_per_pixel();
- const double pixels_offset = get_pixels_offset();
+ double samples_per_pixel, pixels_offset;
+ tie(pixels_offset, samples_per_pixel) =
+ get_pixels_offset_samples_per_pixel();
const double start = a.start_sample() / samples_per_pixel -
pixels_offset;
using namespace pv::data;
using pv::data::decode::Decoder;
+ double samples_per_pixel, pixels_offset;
+
assert(_decoder_stack);
shared_ptr<Logic> data;
const int y = get_y();
- const double samples_per_pixel = get_samples_per_pixel();
- const double pixels_offset = get_pixels_offset();
+ tie(pixels_offset, samples_per_pixel) =
+ get_pixels_offset_samples_per_pixel();
const double start = max(samples_decoded /
samples_per_pixel - pixels_offset, left - 1.0);
p.drawRect(no_decode_rect);
}
-double DecodeTrace::get_pixels_offset() const
+pair<double, double> DecodeTrace::get_pixels_offset_samples_per_pixel() const
{
assert(_view);
assert(_decoder_stack);
const double scale = _view->scale();
assert(scale > 0);
- return (_view->offset() - _decoder_stack->get_start_time()) / scale;
-}
-
-double DecodeTrace::get_samples_per_pixel() const
-{
- assert(_view);
- assert(_decoder_stack);
-
- const double scale = _view->scale();
- assert(scale > 0);
+ const double pixels_offset =
+ (_view->offset() - _decoder_stack->get_start_time()) / scale;
double samplerate = _decoder_stack->samplerate();
if (samplerate == 0.0)
samplerate = 1.0;
- return samplerate * scale;
+ return make_pair(pixels_offset, samplerate * scale);
}
-pair<uint64_t, uint64_t> DecodeTrace::get_sample_range(int x_start, int x_end) const
+pair<uint64_t, uint64_t> DecodeTrace::get_sample_range(
+ int x_start, int x_end) const
{
- assert(_view);
- assert(_decoder_stack);
-
- const double samples_per_pixel = get_samples_per_pixel();
- const double pixels_offset = get_pixels_offset();
-
- uint64_t start, end;
+ double samples_per_pixel, pixels_offset;
+ tie(pixels_offset, samples_per_pixel) =
+ get_pixels_offset_samples_per_pixel();
- start = (uint64_t)max((x_start + pixels_offset) * samples_per_pixel, 0.0);
- end = (uint64_t)max((x_end + pixels_offset) * samples_per_pixel, 0.0);
+ const uint64_t start = (uint64_t)max(
+ (x_start + pixels_offset) * samples_per_pixel, 0.0);
+ const uint64_t end = (uint64_t)max(
+ (x_end + pixels_offset) * samples_per_pixel, 0.0);
return make_pair(start, end);
}
-bool DecodeTrace::hover_point_is_over_trace()
+int DecodeTrace::get_row_at_point(const QPoint &point)
{
- assert(_view);
- assert(_row_height);
-
- // Note: if _row_height is valid then _cur_row_headings is valid, too,
- // as both are set in paint_mid().
-
- // Note: hp.x will be 0 if the cursor is above the header area,
- // so we set trace.left to 1 to exclude this.
+ if (!_row_height)
+ return -1;
- QRect trace(1, get_y() - (_row_height/2),
- _view->width(), _row_height * _visible_rows.size());
+ const int row = (point.y() - get_y() + _row_height / 2) / _row_height;
+ if (row < 0 || row >= (int)_visible_rows.size())
+ return -1;
- // Note: We don't need to check for _row_height being 0 here but
- // we do it anyway to be more robust.
-
- return _row_height && enabled() && trace.contains(_view->hover_point());
+ return row;
}
-int DecodeTrace::get_row_at_hover_point()
-{
- assert(_view);
- assert(_row_height);
- assert(_decoder_stack);
-
- QPoint hp = _view->hover_point();
- int hover_row = (hp.y() - get_y() + (_row_height/2)) / _row_height;
-
- return min(hover_row, (int)_visible_rows.size() - 1);
-}
-
-const QString DecodeTrace::get_annotation_at_hover_point()
+const QString DecodeTrace::get_annotation_at_point(const QPoint &point)
{
using namespace pv::data::decode;
- assert(_view);
- QPoint hp = _view->hover_point();
-
- pair<uint64_t, uint64_t> sample_range = get_sample_range(hp.x(), hp.x() + 1);
+ if (!enabled())
+ return QString();
- const int hover_row = get_row_at_hover_point();
+ const pair<uint64_t, uint64_t> sample_range =
+ get_sample_range(point.x(), point.x() + 1);
+ const int row = get_row_at_point(point);
+ if (row < 0)
+ return QString();
vector<pv::data::decode::Annotation> annotations;
assert(_decoder_stack);
- _decoder_stack->get_annotation_subset(annotations, _visible_rows[hover_row],
+ _decoder_stack->get_annotation_subset(annotations, _visible_rows[row],
sample_range.first, sample_range.second);
return (annotations.empty()) ?
QString() : annotations[0].annotations().front();
}
-void DecodeTrace::show_hover_annotation()
+void DecodeTrace::hide_hover_annotation()
{
- QString ann = get_annotation_at_hover_point();
+ QToolTip::hideText();
+}
+
+void DecodeTrace::hover_point_changed()
+{
+ QPoint hp = _view->hover_point();
+ QString ann = get_annotation_at_point(hp);
assert(_view);
assert(_row_height);
- assert(_text_height);
- if (!ann.isEmpty()) {
- const int hover_row = get_row_at_hover_point();
+ if (ann.isEmpty()) {
+ hide_hover_annotation();
+ return;
+ }
+
+ const int hover_row = get_row_at_point(hp);
- // Make sure the tool tip doesn't overlap with the mouse cursor.
- // If it did, the tool tip would constantly hide and re-appear.
- QPoint hp = _view->hover_point();
- hp.setY(get_y() - (_row_height/2) +
- (hover_row * _row_height) - _text_height);
+ QFontMetrics m(QToolTip::font());
+ const QRect text_size = m.boundingRect(QRect(), 0, ann);
- QToolTip::showText(_view->mapToGlobal(hp), ann);
- } else
- hide_hover_annotation();
-}
+ // This is OS-specific and unfortunately we can't query it, so
+ // use an approximation to at least try to minimize the error.
+ const int padding = 8;
-void DecodeTrace::hide_hover_annotation()
-{
- QToolTip::hideText();
-}
+ // Make sure the tool tip doesn't overlap with the mouse cursor.
+ // If it did, the tool tip would constantly hide and re-appear.
+ // We also push it up by one row so that it appears above the
+ // decode trace, not below.
+ hp.setX(hp.x() - (text_size.width() / 2) - padding);
-void DecodeTrace::hover_point_changed()
-{
- if (hover_point_is_over_trace())
- show_hover_annotation();
- else
- hide_hover_annotation();
+ hp.setY(get_y() - (_row_height / 2) + (hover_row * _row_height)
+ - _row_height - text_size.height());
+
+ QToolTip::showText(_view->viewport()->mapToGlobal(hp), ann);
}
void DecodeTrace::create_decoder_form(int index,