#include "config.h"
#include <glib.h>
-#include <boost/version.hpp>
#include <QApplication>
#include <QComboBox>
#include <QMainWindow>
#include <QMessageBox>
#include <QPushButton>
+#include <QScrollBar>
#include <QSpinBox>
#include <QString>
#include <QTextBrowser>
#include "settings.hpp"
+#include "pv/application.hpp"
#include "pv/devicemanager.hpp"
#include "pv/globalsettings.hpp"
#include "pv/logging.hpp"
+#include "pv/widgets/colorbutton.hpp"
#include <libsigrokcxx/libsigrokcxx.hpp>
#include <libsigrokdecode/libsigrokdecode.h>
#endif
-using std::shared_ptr;
+using pv::widgets::ColorButton;
namespace pv {
namespace dialogs {
+/**
+ * Special version of a QListView that has the width of the first column as minimum size.
+ *
+ * @note Inspired by https://github.com/qt-creator/qt-creator/blob/master/src/plugins/coreplugin/dialogs/settingsdialog.cpp
+ */
+class PageListWidget: public QListWidget
+{
+public:
+ PageListWidget() :
+ QListWidget()
+ {
+ setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Expanding);
+ }
+
+ QSize sizeHint() const final
+ {
+ int width = sizeHintForColumn(0) + frameWidth() * 2 + 5;
+ if (verticalScrollBar()->isVisible())
+ width += verticalScrollBar()->width();
+ return QSize(width, 100);
+ }
+};
+
Settings::Settings(DeviceManager &device_manager, QWidget *parent) :
QDialog(parent, nullptr),
device_manager_(device_manager)
{
- const int icon_size = 64;
-
resize(600, 400);
// Create log view
log_view_ = create_log_view();
// Create pages
- page_list = new QListWidget;
- page_list->setViewMode(QListView::IconMode);
- page_list->setIconSize(QSize(icon_size, icon_size));
+ page_list = new PageListWidget();
+ page_list->setViewMode(QListView::ListMode);
page_list->setMovement(QListView::Static);
- page_list->setMaximumWidth(icon_size + (icon_size / 2));
- page_list->setSpacing(12);
+ page_list->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
pages = new QStackedWidget;
create_pages();
page_list->setCurrentIndex(page_list->model()->index(0, 0));
+ // Create the rest of the dialog
QHBoxLayout *tab_layout = new QHBoxLayout;
tab_layout->addWidget(page_list);
tab_layout->addWidget(pages, Qt::AlignLeft);
void Settings::create_pages()
{
+ // General page
+ pages->addWidget(get_general_settings_form(pages));
+
+ QListWidgetItem *generalButton = new QListWidgetItem(page_list);
+ generalButton->setIcon(QIcon(":/icons/settings-general.png"));
+ generalButton->setText(tr("General"));
+ generalButton->setTextAlignment(Qt::AlignVCenter);
+ generalButton->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
+
// View page
pages->addWidget(get_view_settings_form(pages));
QListWidgetItem *viewButton = new QListWidgetItem(page_list);
viewButton->setIcon(QIcon(":/icons/settings-views.svg"));
viewButton->setText(tr("Views"));
- viewButton->setTextAlignment(Qt::AlignHCenter);
+ viewButton->setTextAlignment(Qt::AlignVCenter);
viewButton->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
#ifdef ENABLE_DECODE
QListWidgetItem *decoderButton = new QListWidgetItem(page_list);
decoderButton->setIcon(QIcon(":/icons/add-decoder.svg"));
decoderButton->setText(tr("Decoders"));
- decoderButton->setTextAlignment(Qt::AlignHCenter);
+ decoderButton->setTextAlignment(Qt::AlignVCenter);
decoderButton->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
#endif
QListWidgetItem *aboutButton = new QListWidgetItem(page_list);
aboutButton->setIcon(QIcon(":/icons/information.svg"));
aboutButton->setText(tr("About"));
- aboutButton->setTextAlignment(Qt::AlignHCenter);
+ aboutButton->setTextAlignment(Qt::AlignVCenter);
aboutButton->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
// Logging page
QListWidgetItem *loggingButton = new QListWidgetItem(page_list);
loggingButton->setIcon(QIcon(":/icons/information.svg"));
loggingButton->setText(tr("Logging"));
- loggingButton->setTextAlignment(Qt::AlignHCenter);
+ loggingButton->setTextAlignment(Qt::AlignVCenter);
loggingButton->setFlags(Qt::ItemIsSelectable | Qt::ItemIsEnabled);
}
return log_view;
}
+QWidget *Settings::get_general_settings_form(QWidget *parent) const
+{
+ GlobalSettings settings;
+
+ QWidget *form = new QWidget(parent);
+ QVBoxLayout *form_layout = new QVBoxLayout(form);
+
+ // General settings
+ QGroupBox *general_group = new QGroupBox(tr("General"));
+ form_layout->addWidget(general_group);
+
+ QFormLayout *general_layout = new QFormLayout();
+ general_group->setLayout(general_layout);
+
+ QComboBox *theme_cb = new QComboBox();
+ for (const pair<QString, QString>& entry : Themes)
+ theme_cb->addItem(entry.first, entry.second);
+
+ theme_cb->setCurrentIndex(
+ settings.value(GlobalSettings::Key_General_Theme).toInt());
+ connect(theme_cb, SIGNAL(currentIndexChanged(int)),
+ this, SLOT(on_general_theme_changed_changed(int)));
+ general_layout->addRow(tr("User interface theme"), theme_cb);
+
+ QLabel *description_1 = new QLabel(tr("(You may need to restart PulseView for all UI elements to update)"));
+ description_1->setAlignment(Qt::AlignRight);
+ general_layout->addRow(description_1);
+
+ return form;
+}
+
QWidget *Settings::get_view_settings_form(QWidget *parent) const
{
GlobalSettings settings;
QFormLayout *trace_view_layout = new QFormLayout();
trace_view_group->setLayout(trace_view_layout);
- cb = create_checkbox(GlobalSettings::Key_View_ColouredBG,
- SLOT(on_view_colouredBG_changed(int)));
- trace_view_layout->addRow(tr("Use coloured trace &background"), cb);
+ cb = create_checkbox(GlobalSettings::Key_View_ColoredBG,
+ SLOT(on_view_coloredBG_changed(int)));
+ trace_view_layout->addRow(tr("Use colored trace &background"), cb);
cb = create_checkbox(GlobalSettings::Key_View_ZoomToFitDuringAcq,
SLOT(on_view_zoomToFitDuringAcq_changed(int)));
SLOT(on_view_showSamplingPoints_changed(int)));
trace_view_layout->addRow(tr("Show data &sampling points"), cb);
+ cb = create_checkbox(GlobalSettings::Key_View_FillSignalHighAreas,
+ SLOT(on_view_fillSignalHighAreas_changed(int)));
+ trace_view_layout->addRow(tr("Fill high areas of logic signals"), cb);
+
+ ColorButton* high_fill_cb = new ColorButton(parent);
+ high_fill_cb->set_color(QColor::fromRgba(
+ settings.value(GlobalSettings::Key_View_FillSignalHighAreaColor).value<uint32_t>()));
+ connect(high_fill_cb, SIGNAL(selected(QColor)),
+ this, SLOT(on_view_fillSignalHighAreaColor_changed(QColor)));
+ trace_view_layout->addRow(tr("Fill high areas of logic signals"), high_fill_cb);
+
cb = create_checkbox(GlobalSettings::Key_View_ShowAnalogMinorGrid,
SLOT(on_view_showAnalogMinorGrid_changed(int)));
trace_view_layout->addRow(tr("Show analog minor grid in addition to div grid"), cb);
+ cb = create_checkbox(GlobalSettings::Key_View_ShowHoverMarker,
+ SLOT(on_view_showHoverMarker_changed(int)));
+ trace_view_layout->addRow(tr("Highlight mouse cursor using a vertical marker line"), cb);
+
+ QSpinBox *snap_distance_sb = new QSpinBox();
+ snap_distance_sb->setRange(0, 1000);
+ snap_distance_sb->setSuffix(tr(" pixels"));
+ snap_distance_sb->setValue(
+ settings.value(GlobalSettings::Key_View_SnapDistance).toInt());
+ connect(snap_distance_sb, SIGNAL(valueChanged(int)), this,
+ SLOT(on_view_snapDistance_changed(int)));
+ trace_view_layout->addRow(tr("Maximum distance from edges before cursors snap to them"), snap_distance_sb);
+
QComboBox *thr_disp_mode_cb = new QComboBox();
thr_disp_mode_cb->addItem(tr("None"), GlobalSettings::ConvThrDispMode_None);
thr_disp_mode_cb->addItem(tr("Background"), GlobalSettings::ConvThrDispMode_Background);
return form;
}
-QWidget *Settings::get_decoder_settings_form(QWidget *parent) const
+QWidget *Settings::get_decoder_settings_form(QWidget *parent)
{
#ifdef ENABLE_DECODE
+ GlobalSettings settings;
QCheckBox *cb;
QWidget *form = new QWidget(parent);
SLOT(on_dec_initialStateConfigurable_changed(int)));
decoder_layout->addRow(tr("Allow configuration of &initial signal state"), cb);
+ // Annotation export settings
+ ann_export_format_ = new QLineEdit();
+ ann_export_format_->setText(
+ settings.value(GlobalSettings::Key_Dec_ExportFormat).toString());
+ connect(ann_export_format_, SIGNAL(textChanged(const QString&)),
+ this, SLOT(on_dec_exportFormat_changed(const QString&)));
+ decoder_layout->addRow(tr("Annotation export format"), ann_export_format_);
+ QLabel *description_1 = new QLabel(tr("%s = sample range; %d: decoder name; %c: row name; %q: use quotations marks"));
+ description_1->setAlignment(Qt::AlignRight);
+ decoder_layout->addRow(description_1);
+ QLabel *description_2 = new QLabel(tr("%1: longest annotation text; %a: all annotation texts"));
+ description_2->setAlignment(Qt::AlignRight);
+ decoder_layout->addRow(description_2);
+
return form;
#else
(void)parent;
#endif
}
-#ifdef ENABLE_DECODE
-static gint sort_pds(gconstpointer a, gconstpointer b)
-{
- const struct srd_decoder *sda, *sdb;
-
- sda = (const struct srd_decoder *)a;
- sdb = (const struct srd_decoder *)b;
- return strcmp(sda->id, sdb->id);
-}
-#endif
-
QWidget *Settings::get_about_page(QWidget *parent) const
{
-#ifdef ENABLE_DECODE
- struct srd_decoder *dec;
-#endif
+ Application* a = qobject_cast<Application*>(QApplication::instance());
QLabel *icon = new QLabel();
icon->setPixmap(QPixmap(QString::fromUtf8(":/icons/pulseview.svg")));
- /* Setup the version field */
- QLabel *version_info = new QLabel();
- version_info->setText(tr("%1 %2<br />%3<br /><a href=\"http://%4\">%4</a>")
- .arg(QApplication::applicationName(),
- QApplication::applicationVersion(),
+ // Setup the license field with the project homepage link
+ QLabel *gpl_home_info = new QLabel();
+ gpl_home_info->setText(tr("%1<br /><a href=\"http://%2\">%2</a>").arg(
tr("GNU GPL, version 3 or later"),
QApplication::organizationDomain()));
- version_info->setOpenExternalLinks(true);
-
- shared_ptr<sigrok::Context> context = device_manager_.context();
+ gpl_home_info->setOpenExternalLinks(true);
QString s;
s.append("<table>");
- /* Library info */
s.append("<tr><td colspan=\"2\"><b>" +
- tr("Libraries and features:") + "</b></td></tr>");
-
- s.append(QString("<tr><td><i>%1</i></td><td>%2</td></tr>")
- .arg(QString("Qt"), qVersion()));
- s.append(QString("<tr><td><i>%1</i></td><td>%2</td></tr>")
- .arg(QString("glibmm"), PV_GLIBMM_VERSION));
- s.append(QString("<tr><td><i>%1</i></td><td>%2</td></tr>")
- .arg(QString("Boost"), BOOST_LIB_VERSION));
-
- s.append(QString("<tr><td><i>%1</i></td><td>%2/%3 (rt: %4/%5)</td></tr>")
- .arg(QString("libsigrok"), SR_PACKAGE_VERSION_STRING,
- SR_LIB_VERSION_STRING, sr_package_version_string_get(),
- sr_lib_version_string_get()));
-
- GSList *l_orig = sr_buildinfo_libs_get();
- for (GSList *l = l_orig; l; l = l->next) {
- GSList *m = (GSList *)l->data;
- const char *lib = (const char *)m->data;
- const char *version = (const char *)m->next->data;
- s.append(QString("<tr><td><i>- %1</i></td><td>%2</td></tr>")
- .arg(QString(lib), QString(version)));
- g_slist_free_full(m, g_free);
- }
- g_slist_free(l_orig);
-
- char *host = sr_buildinfo_host_get();
- s.append(QString("<tr><td><i>- Host</i></td><td>%1</td></tr>")
- .arg(QString(host)));
- g_free(host);
-
- char *scpi_backends = sr_buildinfo_scpi_backends_get();
- s.append(QString("<tr><td><i>- SCPI backends</i></td><td>%1</td></tr>")
- .arg(QString(scpi_backends)));
- g_free(scpi_backends);
-
-#ifdef ENABLE_DECODE
- s.append(QString("<tr><td><i>%1</i></td><td>%2/%3 (rt: %4/%5)</td></tr>")
- .arg(QString("libsigrokdecode"), SRD_PACKAGE_VERSION_STRING,
- SRD_LIB_VERSION_STRING, srd_package_version_string_get(),
- srd_lib_version_string_get()));
-
- l_orig = srd_buildinfo_libs_get();
- for (GSList *l = l_orig; l; l = l->next) {
- GSList *m = (GSList *)l->data;
- const char *lib = (const char *)m->data;
- const char *version = (const char *)m->next->data;
- s.append(QString("<tr><td><i>- %1</i></td><td>%2</td></tr>")
- .arg(QString(lib), QString(version)));
- g_slist_free_full(m, g_free);
- }
- g_slist_free(l_orig);
-
- host = srd_buildinfo_host_get();
- s.append(QString("<tr><td><i>- Host</i></td><td>%1</td></tr>")
- .arg(QString(host)));
- g_free(host);
-#endif
+ tr("Versions, libraries and features:") + "</b></td></tr>");
+ for (pair<QString, QString> &entry : a->get_version_info())
+ s.append(QString("<tr><td><i>%1</i></td><td>%2</td></tr>")
+ .arg(entry.first, entry.second));
s.append("<tr><td colspan=\"2\"></td></tr>");
s.append("<tr><td colspan=\"2\"><b>" +
tr("Firmware search paths:") + "</b></td></tr>");
-
- l_orig = sr_resourcepaths_get(SR_RESOURCE_FIRMWARE);
- for (GSList *l = l_orig; l; l = l->next)
- s.append(QString("<tr><td colspan=\"2\">%1</td></tr>").arg(
- QString((char*)l->data)));
- g_slist_free_full(l_orig, g_free);
+ for (QString &entry : a->get_fw_path_list())
+ s.append(QString("<tr><td colspan=\"2\">%1</td></tr>").arg(entry));
#ifdef ENABLE_DECODE
s.append("<tr><td colspan=\"2\"></td></tr>");
s.append("<tr><td colspan=\"2\"><b>" +
tr("Protocol decoder search paths:") + "</b></td></tr>");
-
- l_orig = srd_searchpaths_get();
- for (GSList *l = l_orig; l; l = l->next)
- s.append(QString("<tr><td colspan=\"2\">%1</td></tr>").arg(
- QString((char*)l->data)));
- g_slist_free_full(l_orig, g_free);
+ for (QString &entry : a->get_pd_path_list())
+ s.append(QString("<tr><td colspan=\"2\">%1</td></tr>").arg(entry));
#endif
- /* Set up the supported field */
s.append("<tr><td colspan=\"2\"></td></tr>");
s.append("<tr><td colspan=\"2\"><b>" +
tr("Supported hardware drivers:") + "</b></td></tr>");
- for (auto entry : context->drivers()) {
+ for (pair<QString, QString> &entry : a->get_driver_list())
s.append(QString("<tr><td class=\"id\"><i>%1</i></td><td>%2</td></tr>")
- .arg(QString::fromUtf8(entry.first.c_str()),
- QString::fromUtf8(entry.second->long_name().c_str())));
- }
+ .arg(entry.first, entry.second));
s.append("<tr><td colspan=\"2\"></td></tr>");
s.append("<tr><td colspan=\"2\"><b>" +
tr("Supported input formats:") + "</b></td></tr>");
- for (auto entry : context->input_formats()) {
+ for (pair<QString, QString> &entry : a->get_input_format_list())
s.append(QString("<tr><td class=\"id\"><i>%1</i></td><td>%2</td></tr>")
- .arg(QString::fromUtf8(entry.first.c_str()),
- QString::fromUtf8(entry.second->description().c_str())));
- }
+ .arg(entry.first, entry.second));
s.append("<tr><td colspan=\"2\"></td></tr>");
s.append("<tr><td colspan=\"2\"><b>" +
tr("Supported output formats:") + "</b></td></tr>");
- for (auto entry : context->output_formats()) {
+ for (pair<QString, QString> &entry : a->get_output_format_list())
s.append(QString("<tr><td class=\"id\"><i>%1</i></td><td>%2</td></tr>")
- .arg(QString::fromUtf8(entry.first.c_str()),
- QString::fromUtf8(entry.second->description().c_str())));
- }
+ .arg(entry.first, entry.second));
#ifdef ENABLE_DECODE
s.append("<tr><td colspan=\"2\"></td></tr>");
s.append("<tr><td colspan=\"2\"><b>" +
tr("Supported protocol decoders:") + "</b></td></tr>");
- GSList *sl = g_slist_copy((GSList *)srd_decoder_list());
- sl = g_slist_sort(sl, sort_pds);
- for (const GSList *l = sl; l; l = l->next) {
- dec = (struct srd_decoder *)l->data;
+ for (pair<QString, QString> &entry : a->get_pd_list())
s.append(QString("<tr><td class=\"id\"><i>%1</i></td><td>%2</td></tr>")
- .arg(QString::fromUtf8(dec->id),
- QString::fromUtf8(dec->longname)));
- }
- g_slist_free(sl);
+ .arg(entry.first, entry.second));
#endif
s.append("</table>");
QTextBrowser *support_list = new QTextBrowser();
support_list->setDocument(supported_doc);
- QGridLayout *layout = new QGridLayout();
- layout->addWidget(icon, 0, 0, 1, 1);
- layout->addWidget(version_info, 0, 1, 1, 1);
- layout->addWidget(support_list, 1, 1, 1, 1);
+ QHBoxLayout *h_layout = new QHBoxLayout();
+ h_layout->setAlignment(Qt::AlignLeft);
+ h_layout->addWidget(icon);
+ h_layout->addWidget(gpl_home_info);
+
+ QVBoxLayout *layout = new QVBoxLayout();
+ layout->addLayout(h_layout);
+ layout->addWidget(support_list);
QWidget *page = new QWidget(parent);
page->setLayout(layout);
// Background buffer size
QSpinBox *buffersize_sb = new QSpinBox();
buffersize_sb->setSuffix(tr(" lines"));
+ buffersize_sb->setMinimum(Logging::MIN_BUFFER_SIZE);
buffersize_sb->setMaximum(Logging::MAX_BUFFER_SIZE);
buffersize_sb->setValue(
settings.value(GlobalSettings::Key_Log_BufferSize).toInt());
pages->setCurrentIndex(page_list->row(current));
}
+void Settings::on_general_theme_changed_changed(int state)
+{
+ GlobalSettings settings;
+ settings.setValue(GlobalSettings::Key_General_Theme, state);
+ settings.apply_theme();
+}
+
void Settings::on_view_zoomToFitDuringAcq_changed(int state)
{
GlobalSettings settings;
settings.setValue(GlobalSettings::Key_View_TriggerIsZeroTime, state ? true : false);
}
-void Settings::on_view_colouredBG_changed(int state)
+void Settings::on_view_coloredBG_changed(int state)
{
GlobalSettings settings;
- settings.setValue(GlobalSettings::Key_View_ColouredBG, state ? true : false);
+ settings.setValue(GlobalSettings::Key_View_ColoredBG, state ? true : false);
}
void Settings::on_view_stickyScrolling_changed(int state)
settings.setValue(GlobalSettings::Key_View_ShowSamplingPoints, state ? true : false);
}
+void Settings::on_view_fillSignalHighAreas_changed(int state)
+{
+ GlobalSettings settings;
+ settings.setValue(GlobalSettings::Key_View_FillSignalHighAreas, state ? true : false);
+}
+
+void Settings::on_view_fillSignalHighAreaColor_changed(QColor color)
+{
+ GlobalSettings settings;
+ settings.setValue(GlobalSettings::Key_View_FillSignalHighAreaColor, color.rgba());
+}
+
void Settings::on_view_showAnalogMinorGrid_changed(int state)
{
GlobalSettings settings;
settings.setValue(GlobalSettings::Key_View_ShowAnalogMinorGrid, state ? true : false);
}
+void Settings::on_view_showHoverMarker_changed(int state)
+{
+ GlobalSettings settings;
+ settings.setValue(GlobalSettings::Key_View_ShowHoverMarker, state ? true : false);
+}
+
+void Settings::on_view_snapDistance_changed(int value)
+{
+ GlobalSettings settings;
+ settings.setValue(GlobalSettings::Key_View_SnapDistance, value);
+}
+
void Settings::on_view_conversionThresholdDispMode_changed(int state)
{
GlobalSettings settings;
settings.setValue(GlobalSettings::Key_View_DefaultLogicHeight, value);
}
+#ifdef ENABLE_DECODE
void Settings::on_dec_initialStateConfigurable_changed(int state)
{
GlobalSettings settings;
settings.setValue(GlobalSettings::Key_Dec_InitialStateConfigurable, state ? true : false);
}
+void Settings::on_dec_exportFormat_changed(const QString &text)
+{
+ GlobalSettings settings;
+ settings.setValue(GlobalSettings::Key_Dec_ExportFormat, text);
+}
+#endif
+
void Settings::on_log_logLevel_changed(int value)
{
logging.set_log_level(value);
(void)checked;
// Create the window as a sub-window so it closes when the main window closes
- QMainWindow *window = new QMainWindow(0, Qt::SubWindow);
+ QMainWindow *window = new QMainWindow(nullptr, Qt::SubWindow);
window->setObjectName(QString::fromUtf8("Log Window"));
window->setWindowTitle(tr("%1 Log").arg(PV_TITLE));