projects
/
pulseview.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
DecodeTrace: Don't dereference iterator pointing at end of container.
[pulseview.git]
/
pv
/
view
/
trace.cpp
diff --git
a/pv/view/trace.cpp
b/pv/view/trace.cpp
index df5a954b43a216f66d7cb11c5799464d882a3fe4..2e15ca958a1da81af2ebba507328da0b9cb801b6 100644
(file)
--- a/
pv/view/trace.cpp
+++ b/
pv/view/trace.cpp
@@
-21,7
+21,7
@@
#include <extdef.h>
#include <assert.h>
#include <extdef.h>
#include <assert.h>
-#include <
math.
h>
+#include <
cmat
h>
#include <QApplication>
#include <QFormLayout>
#include <QApplication>
#include <QFormLayout>
@@
-43,8
+43,8
@@
const int Trace::LabelHitPadding = 2;
Trace::Trace(QString name) :
name_(name),
Trace::Trace(QString name) :
name_(name),
- popup_(
NULL
),
- popup_form_(
NULL
)
+ popup_(
nullptr
),
+ popup_form_(
nullptr
)
{
}
{
}
@@
-134,6
+134,8
@@
pv::widgets::Popup* Trace::create_popup(QWidget *parent)
using pv::widgets::Popup;
popup_ = new Popup(parent);
using pv::widgets::Popup;
popup_ = new Popup(parent);
+ popup_->set_position(parent->mapToGlobal(
+ point(parent->rect())), Popup::Right);
create_popup_form();
create_popup_form();
@@
-161,6
+163,13
@@
QRectF Trace::label_rect(const QRectF &rect) const
label_size.height());
}
label_size.height());
}
+QRectF Trace::hit_box_rect(const ViewItemPaintParams &pp) const
+{
+ const float h = QFontMetrics(QApplication::font()).height();
+ return QRectF(pp.left(), get_visual_y() - h / 2.0f,
+ pp.width(), h);
+}
+
void Trace::paint_axis(QPainter &p, const ViewItemPaintParams &pp, int y)
{
p.setPen(AxisPen);
void Trace::paint_axis(QPainter &p, const ViewItemPaintParams &pp, int y)
{
p.setPen(AxisPen);
@@
-210,8
+219,8
@@
void Trace::populate_popup_form(QWidget *parent, QFormLayout *form)
void Trace::on_popup_closed()
{
void Trace::on_popup_closed()
{
- popup_ =
NULL
;
- popup_form_ =
NULL
;
+ popup_ =
nullptr
;
+ popup_form_ =
nullptr
;
}
void Trace::on_text_changed(const QString &text)
}
void Trace::on_text_changed(const QString &text)