projects
/
pulseview.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Make member variable underscores a suffix instead of a prefix
[pulseview.git]
/
pv
/
view
/
analogsignal.cpp
diff --git
a/pv/view/analogsignal.cpp
b/pv/view/analogsignal.cpp
index 64633717fb4b8098637901813421df24f83c3d30..3509a040d201c84c896df69db0d6208aeb8f30bd 100644
(file)
--- a/
pv/view/analogsignal.cpp
+++ b/
pv/view/analogsignal.cpp
@@
-20,19
+20,29
@@
#include <extdef.h>
#include <extdef.h>
-#include <math.h>
+#include <cassert>
+#include <cmath>
#include "analogsignal.h"
#include "pv/data/analog.h"
#include "pv/data/analogsnapshot.h"
#include "pv/view/view.h"
#include "analogsignal.h"
#include "pv/data/analog.h"
#include "pv/data/analogsnapshot.h"
#include "pv/view/view.h"
-using namespace boost;
-using namespace std;
+#include <libsigrok/libsigrok.hpp>
+
+using std::max;
+using std::make_pair;
+using std::min;
+using std::shared_ptr;
+using std::deque;
+
+using sigrok::Channel;
namespace pv {
namespace view {
namespace pv {
namespace view {
+const int AnalogSignal::NominalHeight = 80;
+
const QColor AnalogSignal::SignalColours[4] = {
QColor(0xC4, 0xA0, 0x00), // Yellow
QColor(0x87, 0x20, 0x7A), // Magenta
const QColor AnalogSignal::SignalColours[4] = {
QColor(0xC4, 0xA0, 0x00), // Yellow
QColor(0x87, 0x20, 0x7A), // Magenta
@@
-42,53
+52,68
@@
const QColor AnalogSignal::SignalColours[4] = {
const float AnalogSignal::EnvelopeThreshold = 256.0f;
const float AnalogSignal::EnvelopeThreshold = 256.0f;
-AnalogSignal::AnalogSignal(pv::SigSession &session, sr_probe *const probe,
+AnalogSignal::AnalogSignal(
+ pv::SigSession &session,
+ shared_ptr<Channel> channel,
shared_ptr<data::Analog> data) :
shared_ptr<data::Analog> data) :
- Signal(session,
probe
),
-
_data
(data),
-
_scale
(1.0f)
+ Signal(session,
channel
),
+
data_
(data),
+
scale_
(1.0f)
{
{
-
_colour = SignalColours[probe->index
% countof(SignalColours)];
+
colour_ = SignalColours[channel_->index()
% countof(SignalColours)];
}
AnalogSignal::~AnalogSignal()
{
}
}
AnalogSignal::~AnalogSignal()
{
}
-boost::shared_ptr<pv::data::SignalData> AnalogSignal::data() const
+shared_ptr<pv::data::SignalData> AnalogSignal::data() const
+{
+ return data_;
+}
+
+shared_ptr<pv::data::Analog> AnalogSignal::analog_data() const
{
{
- return
_data
;
+ return
data_
;
}
void AnalogSignal::set_scale(float scale)
{
}
void AnalogSignal::set_scale(float scale)
{
- _scale = scale;
+ scale_ = scale;
+}
+
+std::pair<int, int> AnalogSignal::v_extents() const
+{
+ return make_pair(-NominalHeight / 2, NominalHeight / 2);
}
void AnalogSignal::paint_back(QPainter &p, int left, int right)
{
}
void AnalogSignal::paint_back(QPainter &p, int left, int right)
{
- if (
_probe->enabled
)
- paint_axis(p, get_y(), left, right);
+ if (
channel_->enabled()
)
+ paint_axis(p, get_
visual_
y(), left, right);
}
void AnalogSignal::paint_mid(QPainter &p, int left, int right)
{
}
void AnalogSignal::paint_mid(QPainter &p, int left, int right)
{
- assert(
_data
);
+ assert(
data_
);
assert(right >= left);
assert(right >= left);
+ assert(owner_);
+
+ const int y = get_visual_y();
-
assert(_view
);
-
const int y = _v_offset - _view->v_offset(
);
+
const View *const view = owner_->view(
);
+
assert(view
);
- const double scale =
_
view->scale();
+ const double scale = view->scale();
assert(scale > 0);
assert(scale > 0);
- const double offset =
_
view->offset();
+ const double offset = view->offset();
- if (!
_probe->enabled
)
+ if (!
channel_->enabled()
)
return;
const deque< shared_ptr<pv::data::AnalogSnapshot> > &snapshots =
return;
const deque< shared_ptr<pv::data::AnalogSnapshot> > &snapshots =
-
_data
->get_snapshots();
+
data_
->get_snapshots();
if (snapshots.empty())
return;
if (snapshots.empty())
return;
@@
-96,8
+121,8
@@
void AnalogSignal::paint_mid(QPainter &p, int left, int right)
snapshots.front();
const double pixels_offset = offset / scale;
snapshots.front();
const double pixels_offset = offset / scale;
- const double samplerate =
_data
->samplerate();
- const double start_time =
_data
->get_start_time();
+ const double samplerate =
data_
->samplerate();
+ const double start_time =
data_
->get_start_time();
const int64_t last_sample = snapshot->get_sample_count() - 1;
const double samples_per_pixel = samplerate * scale;
const double start = samplerate * (offset - start_time);
const int64_t last_sample = snapshot->get_sample_count() - 1;
const double samples_per_pixel = samplerate * scale;
const double start = samplerate * (offset - start_time);
@@
-128,7
+153,7
@@
void AnalogSignal::paint_trace(QPainter &p,
const float *const samples = snapshot->get_samples(start, end);
assert(samples);
const float *const samples = snapshot->get_samples(start, end);
assert(samples);
- p.setPen(
_colour
);
+ p.setPen(
colour_
);
QPointF *points = new QPointF[sample_count];
QPointF *point = points;
QPointF *points = new QPointF[sample_count];
QPointF *point = points;
@@
-137,7
+162,7
@@
void AnalogSignal::paint_trace(QPainter &p,
const float x = (sample / samples_per_pixel -
pixels_offset) + left;
*point++ = QPointF(x,
const float x = (sample / samples_per_pixel -
pixels_offset) + left;
*point++ = QPointF(x,
- y - samples[sample - start] *
_scale
);
+ y - samples[sample - start] *
scale_
);
}
p.drawPolyline(points, point - points);
}
p.drawPolyline(points, point - points);
@@
-151,7
+176,6
@@
void AnalogSignal::paint_envelope(QPainter &p,
int y, int left, const int64_t start, const int64_t end,
const double pixels_offset, const double samples_per_pixel)
{
int y, int left, const int64_t start, const int64_t end,
const double pixels_offset, const double samples_per_pixel)
{
- using namespace Qt;
using pv::data::AnalogSnapshot;
AnalogSnapshot::EnvelopeSection e;
using pv::data::AnalogSnapshot;
AnalogSnapshot::EnvelopeSection e;
@@
-160,8
+184,8
@@
void AnalogSignal::paint_envelope(QPainter &p,
if (e.length < 2)
return;
if (e.length < 2)
return;
- p.setPen(QPen(NoPen));
- p.setBrush(
_colour
);
+ p.setPen(QPen(
Qt::
NoPen));
+ p.setBrush(
colour_
);
QRectF *const rects = new QRectF[e.length];
QRectF *rect = rects;
QRectF *const rects = new QRectF[e.length];
QRectF *rect = rects;
@@
-174,8
+198,8
@@
void AnalogSignal::paint_envelope(QPainter &p,
// We overlap this sample with the next so that vertical
// gaps do not appear during steep rising or falling edges
// We overlap this sample with the next so that vertical
// gaps do not appear during steep rising or falling edges
- const float b = y - max(s->max, (s+1)->min) *
_scale
;
- const float t = y - min(s->min, (s+1)->max) *
_scale
;
+ const float b = y - max(s->max, (s+1)->min) *
scale_
;
+ const float t = y - min(s->min, (s+1)->max) *
scale_
;
float h = b - t;
if(h >= 0.0f && h <= 1.0f)
float h = b - t;
if(h >= 0.0f && h <= 1.0f)