projects
/
pulseview.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Enum: Use an iterator instead of iterating by indexes
[pulseview.git]
/
pv
/
prop
/
enum.cpp
diff --git
a/pv/prop/enum.cpp
b/pv/prop/enum.cpp
index d4a04cbb748ae066fb66cebe29b244eca52c6a8f..71cd431548da771ff5e3a9289480f62c5d5b71d2 100644
(file)
--- a/
pv/prop/enum.cpp
+++ b/
pv/prop/enum.cpp
@@
-41,8
+41,9
@@
Enum::Enum(QString name,
Enum::~Enum()
{
Enum::~Enum()
{
- for (unsigned int i = 0; i < _values.size(); i++)
- g_variant_unref(_values[i].first);
+ for (vector< pair<GVariant*, QString> >::const_iterator i =
+ _values.begin(); i != _values.end(); i++)
+ g_variant_unref((*i).first);
}
QWidget* Enum::get_widget(QWidget *parent, bool auto_commit)
}
QWidget* Enum::get_widget(QWidget *parent, bool auto_commit)
@@
-51,6
+52,8
@@
QWidget* Enum::get_widget(QWidget *parent, bool auto_commit)
return _selector;
GVariant *const value = _getter ? _getter() : NULL;
return _selector;
GVariant *const value = _getter ? _getter() : NULL;
+ if (!value)
+ return NULL;
_selector = new QComboBox(parent);
for (unsigned int i = 0; i < _values.size(); i++) {
_selector = new QComboBox(parent);
for (unsigned int i = 0; i < _values.size(); i++) {