AnalogSignal: Set initial value for the "value at cursor" variable
[pulseview.git] / pv / views / trace / analogsignal.cpp
1 /*
2  * This file is part of the PulseView project.
3  *
4  * Copyright (C) 2012 Joel Holdsworth <joel@airwebreathe.org.uk>
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, see <http://www.gnu.org/licenses/>.
18  */
19
20 #include <extdef.h>
21
22 #include <cassert>
23 #include <cmath>
24 #include <cstdlib>
25 #include <limits>
26 #include <vector>
27
28 #include <QApplication>
29 #include <QCheckBox>
30 #include <QComboBox>
31 #include <QDebug>
32 #include <QFormLayout>
33 #include <QGridLayout>
34 #include <QLabel>
35 #include <QString>
36
37 #include "analogsignal.hpp"
38 #include "logicsignal.hpp"
39 #include "view.hpp"
40
41 #include "pv/util.hpp"
42 #include "pv/data/analog.hpp"
43 #include "pv/data/analogsegment.hpp"
44 #include "pv/data/logic.hpp"
45 #include "pv/data/logicsegment.hpp"
46 #include "pv/data/signalbase.hpp"
47 #include "pv/globalsettings.hpp"
48
49 #include <libsigrokcxx/libsigrokcxx.hpp>
50
51 using std::deque;
52 using std::div;
53 using std::div_t;
54 // Note that "using std::isnan;" is _not_ put here since that would break
55 // compilation on some platforms. Use "std::isnan()" instead in checks below.
56 using std::max;
57 using std::make_pair;
58 using std::min;
59 using std::numeric_limits;
60 using std::out_of_range;
61 using std::pair;
62 using std::shared_ptr;
63 using std::vector;
64
65 using pv::data::SignalBase;
66 using pv::util::SIPrefix;
67
68 namespace pv {
69 namespace views {
70 namespace trace {
71
72 const QColor AnalogSignal::SignalColors[4] = {
73         QColor(0xC4, 0xA0, 0x00),       // Yellow
74         QColor(0x87, 0x20, 0x7A),       // Magenta
75         QColor(0x20, 0x4A, 0x87),       // Blue
76         QColor(0x4E, 0x9A, 0x06)        // Green
77 };
78
79 const QPen AnalogSignal::AxisPen(QColor(0, 0, 0, 30 * 256 / 100), 2);
80 const QColor AnalogSignal::GridMajorColor = QColor(0, 0, 0, 40 * 256 / 100);
81 const QColor AnalogSignal::GridMinorColor = QColor(0, 0, 0, 20 * 256 / 100);
82
83 const QColor AnalogSignal::SamplingPointColor(0x77, 0x77, 0x77);
84 const QColor AnalogSignal::SamplingPointColorLo = QColor(200, 0, 0, 80 * 256 / 100);
85 const QColor AnalogSignal::SamplingPointColorNe = QColor(0,   0, 0, 80 * 256 / 100);
86 const QColor AnalogSignal::SamplingPointColorHi = QColor(0, 200, 0, 80 * 256 / 100);
87
88 const QColor AnalogSignal::ThresholdColor = QColor(0, 0, 0, 30 * 256 / 100);
89 const QColor AnalogSignal::ThresholdColorLo = QColor(255, 0, 0, 8 * 256 / 100);
90 const QColor AnalogSignal::ThresholdColorNe = QColor(0,   0, 0, 10 * 256 / 100);
91 const QColor AnalogSignal::ThresholdColorHi = QColor(0, 255, 0, 8 * 256 / 100);
92
93 const int64_t AnalogSignal::TracePaintBlockSize = 1024 * 1024;  // 4 MiB (due to float)
94 const float AnalogSignal::EnvelopeThreshold = 64.0f;
95
96 const int AnalogSignal::MaximumVDivs = 10;
97 const int AnalogSignal::MinScaleIndex = -6;
98 const int AnalogSignal::MaxScaleIndex = 7;
99
100 const int AnalogSignal::InfoTextMarginRight = 20;
101 const int AnalogSignal::InfoTextMarginBottom = 5;
102
103 AnalogSignal::AnalogSignal(
104         pv::Session &session,
105         shared_ptr<data::SignalBase> base) :
106         Signal(session, base),
107         scale_index_(4), // 20 per div
108         pos_vdivs_(1),
109         neg_vdivs_(1),
110         resolution_(0),
111         display_type_(DisplayBoth),
112         autoranging_(true),
113         value_at_hover_pos_(std::numeric_limits<float>::quiet_NaN())
114 {
115         axis_pen_ = AxisPen;
116
117         pv::data::Analog* analog_data =
118                 dynamic_cast<pv::data::Analog*>(data().get());
119
120         connect(analog_data, SIGNAL(min_max_changed(float, float)),
121                 this, SLOT(on_min_max_changed(float, float)));
122
123         GlobalSettings gs;
124         conversion_threshold_disp_mode_ =
125                 gs.value(GlobalSettings::Key_View_ConversionThresholdDispMode).toInt();
126
127         div_height_ = gs.value(GlobalSettings::Key_View_DefaultDivHeight).toInt();
128
129         base_->set_color(SignalColors[base_->index() % countof(SignalColors)]);
130         update_scale();
131 }
132
133 shared_ptr<pv::data::SignalData> AnalogSignal::data() const
134 {
135         return base_->analog_data();
136 }
137
138 void AnalogSignal::save_settings(QSettings &settings) const
139 {
140         settings.setValue("pos_vdivs", pos_vdivs_);
141         settings.setValue("neg_vdivs", neg_vdivs_);
142         settings.setValue("scale_index", scale_index_);
143         settings.setValue("display_type", display_type_);
144         settings.setValue("autoranging", autoranging_);
145         settings.setValue("div_height", div_height_);
146 }
147
148 void AnalogSignal::restore_settings(QSettings &settings)
149 {
150         if (settings.contains("pos_vdivs"))
151                 pos_vdivs_ = settings.value("pos_vdivs").toInt();
152
153         if (settings.contains("neg_vdivs"))
154                 neg_vdivs_ = settings.value("neg_vdivs").toInt();
155
156         if (settings.contains("scale_index")) {
157                 scale_index_ = settings.value("scale_index").toInt();
158                 update_scale();
159         }
160
161         if (settings.contains("display_type"))
162                 display_type_ = (DisplayType)(settings.value("display_type").toInt());
163
164         if (settings.contains("autoranging"))
165                 autoranging_ = settings.value("autoranging").toBool();
166
167         if (settings.contains("div_height")) {
168                 const int old_height = div_height_;
169                 div_height_ = settings.value("div_height").toInt();
170
171                 if ((div_height_ != old_height) && owner_) {
172                         // Call order is important, otherwise the lazy event handler won't work
173                         owner_->extents_changed(false, true);
174                         owner_->row_item_appearance_changed(false, true);
175                 }
176         }
177 }
178
179 pair<int, int> AnalogSignal::v_extents() const
180 {
181         const int ph = pos_vdivs_ * div_height_;
182         const int nh = neg_vdivs_ * div_height_;
183         return make_pair(-ph, nh);
184 }
185
186 void AnalogSignal::on_setting_changed(const QString &key, const QVariant &value)
187 {
188         Signal::on_setting_changed(key, value);
189
190         if (key == GlobalSettings::Key_View_ConversionThresholdDispMode)
191                 on_settingViewConversionThresholdDispMode_changed(value);
192 }
193
194 void AnalogSignal::paint_back(QPainter &p, ViewItemPaintParams &pp)
195 {
196         if (!base_->enabled())
197                 return;
198
199         bool paint_thr_bg =
200                 conversion_threshold_disp_mode_ == GlobalSettings::ConvThrDispMode_Background;
201
202         const vector<double> thresholds = base_->get_conversion_thresholds();
203
204         // Only display thresholds if we have some and we show analog samples
205         if ((thresholds.size() > 0) && paint_thr_bg &&
206                 ((display_type_ == DisplayAnalog) || (display_type_ == DisplayBoth))) {
207
208                 const int visual_y = get_visual_y();
209                 const pair<int, int> extents = v_extents();
210                 const int top = visual_y + extents.first;
211                 const int btm = visual_y + extents.second;
212
213                 // Draw high/neutral/low areas
214                 if (thresholds.size() == 2) {
215                         int thr_lo = visual_y - thresholds[0] * scale_;
216                         int thr_hi = visual_y - thresholds[1] * scale_;
217                         thr_lo = min(max(thr_lo, top), btm);
218                         thr_hi = min(max(thr_hi, top), btm);
219
220                         p.fillRect(QRectF(pp.left(), top, pp.width(), thr_hi - top),
221                                 QBrush(ThresholdColorHi));
222                         p.fillRect(QRectF(pp.left(), thr_hi, pp.width(), thr_lo - thr_hi),
223                                 QBrush(ThresholdColorNe));
224                         p.fillRect(QRectF(pp.left(), thr_lo, pp.width(), btm - thr_lo),
225                                 QBrush(ThresholdColorLo));
226                 } else {
227                         int thr = visual_y - thresholds[0] * scale_;
228                         thr = min(max(thr, top), btm);
229
230                         p.fillRect(QRectF(pp.left(), top, pp.width(), thr - top),
231                                 QBrush(ThresholdColorHi));
232                         p.fillRect(QRectF(pp.left(), thr, pp.width(), btm - thr),
233                                 QBrush(ThresholdColorLo));
234                 }
235
236                 paint_axis(p, pp, get_visual_y());
237         } else {
238                 Trace::paint_back(p, pp);
239                 paint_axis(p, pp, get_visual_y());
240         }
241 }
242
243 void AnalogSignal::paint_mid(QPainter &p, ViewItemPaintParams &pp)
244 {
245         assert(base_->analog_data());
246         assert(owner_);
247
248         const int y = get_visual_y();
249
250         if (!base_->enabled())
251                 return;
252
253         if ((display_type_ == DisplayAnalog) || (display_type_ == DisplayBoth)) {
254                 paint_grid(p, y, pp.left(), pp.right());
255
256                 shared_ptr<pv::data::AnalogSegment> segment = get_analog_segment_to_paint();
257                 if (!segment || (segment->get_sample_count() == 0))
258                         return;
259
260                 const double pixels_offset = pp.pixels_offset();
261                 const double samplerate = max(1.0, segment->samplerate());
262                 const pv::util::Timestamp& start_time = segment->start_time();
263                 const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
264                 const double samples_per_pixel = samplerate * pp.scale();
265                 const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
266                 const pv::util::Timestamp end = start + samples_per_pixel * pp.width();
267
268                 const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
269                         (int64_t)0), last_sample);
270                 const int64_t end_sample = min(max((ceil(end) + 1).convert_to<int64_t>(),
271                         (int64_t)0), last_sample);
272
273                 if (samples_per_pixel < EnvelopeThreshold)
274                         paint_trace(p, segment, y, pp.left(), start_sample, end_sample,
275                                 pixels_offset, samples_per_pixel);
276                 else
277                         paint_envelope(p, segment, y, pp.left(), start_sample, end_sample,
278                                 pixels_offset, samples_per_pixel);
279         }
280
281         if ((display_type_ == DisplayConverted) || (display_type_ == DisplayBoth))
282                 paint_logic_mid(p, pp);
283 }
284
285 void AnalogSignal::paint_fore(QPainter &p, ViewItemPaintParams &pp)
286 {
287         if (!enabled())
288                 return;
289
290         if ((display_type_ == DisplayAnalog) || (display_type_ == DisplayBoth)) {
291                 const int y = get_visual_y();
292
293                 QString infotext;
294
295                 // Show the info section on the right side of the trace, including
296                 // the value at the hover point when the hover marker is enabled
297                 // and we have corresponding data available
298                 if (show_hover_marker_ && !std::isnan(value_at_hover_pos_)) {
299                         infotext = QString("[%1] %2 V/div")
300                                 .arg(format_value_si(value_at_hover_pos_, SIPrefix::unspecified, 0, "V", false))
301                                 .arg(resolution_);
302                 } else
303                         infotext = QString("%1 V/div").arg(resolution_);
304
305                 p.setPen(base_->color());
306                 p.setFont(QApplication::font());
307
308                 const QRectF bounding_rect = QRectF(pp.left(),
309                                 y + v_extents().first,
310                                 pp.width() - InfoTextMarginRight,
311                                 v_extents().second - v_extents().first - InfoTextMarginBottom);
312
313                 p.drawText(bounding_rect, Qt::AlignRight | Qt::AlignBottom, infotext);
314         }
315
316         if (show_hover_marker_)
317                 paint_hover_marker(p);
318 }
319
320 void AnalogSignal::paint_grid(QPainter &p, int y, int left, int right)
321 {
322         p.setRenderHint(QPainter::Antialiasing, false);
323
324         GlobalSettings settings;
325         const bool show_analog_minor_grid =
326                 settings.value(GlobalSettings::Key_View_ShowAnalogMinorGrid).toBool();
327
328         if (pos_vdivs_ > 0) {
329                 p.setPen(QPen(GridMajorColor, 1, Qt::DashLine));
330                 for (int i = 1; i <= pos_vdivs_; i++) {
331                         const float dy = i * div_height_;
332                         p.drawLine(QLineF(left, y - dy, right, y - dy));
333                 }
334         }
335
336         if ((pos_vdivs_ > 0) && show_analog_minor_grid) {
337                 p.setPen(QPen(GridMinorColor, 1, Qt::DashLine));
338                 for (int i = 0; i < pos_vdivs_; i++) {
339                         const float dy = i * div_height_;
340                         const float dy25 = dy + (0.25 * div_height_);
341                         const float dy50 = dy + (0.50 * div_height_);
342                         const float dy75 = dy + (0.75 * div_height_);
343                         p.drawLine(QLineF(left, y - dy25, right, y - dy25));
344                         p.drawLine(QLineF(left, y - dy50, right, y - dy50));
345                         p.drawLine(QLineF(left, y - dy75, right, y - dy75));
346                 }
347         }
348
349         if (neg_vdivs_ > 0) {
350                 p.setPen(QPen(GridMajorColor, 1, Qt::DashLine));
351                 for (int i = 1; i <= neg_vdivs_; i++) {
352                         const float dy = i * div_height_;
353                         p.drawLine(QLineF(left, y + dy, right, y + dy));
354                 }
355         }
356
357         if ((pos_vdivs_ > 0) && show_analog_minor_grid) {
358                 p.setPen(QPen(GridMinorColor, 1, Qt::DashLine));
359                 for (int i = 0; i < neg_vdivs_; i++) {
360                         const float dy = i * div_height_;
361                         const float dy25 = dy + (0.25 * div_height_);
362                         const float dy50 = dy + (0.50 * div_height_);
363                         const float dy75 = dy + (0.75 * div_height_);
364                         p.drawLine(QLineF(left, y + dy25, right, y + dy25));
365                         p.drawLine(QLineF(left, y + dy50, right, y + dy50));
366                         p.drawLine(QLineF(left, y + dy75, right, y + dy75));
367                 }
368         }
369
370         p.setRenderHint(QPainter::Antialiasing, true);
371 }
372
373 void AnalogSignal::paint_trace(QPainter &p,
374         const shared_ptr<pv::data::AnalogSegment> &segment,
375         int y, int left, const int64_t start, const int64_t end,
376         const double pixels_offset, const double samples_per_pixel)
377 {
378         if (end <= start)
379                 return;
380
381         bool paint_thr_dots =
382                 (base_->get_conversion_type() != data::SignalBase::NoConversion) &&
383                 (conversion_threshold_disp_mode_ == GlobalSettings::ConvThrDispMode_Dots);
384
385         vector<double> thresholds;
386         if (paint_thr_dots)
387                 thresholds = base_->get_conversion_thresholds();
388
389         // Calculate and paint the sampling points if enabled and useful
390         GlobalSettings settings;
391         const bool show_sampling_points =
392                 (settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool() ||
393                 paint_thr_dots) && (samples_per_pixel < 0.25);
394
395         p.setPen(base_->color());
396
397         const int64_t points_count = end - start + 1;
398
399         QPointF *points = new QPointF[points_count];
400         QPointF *point = points;
401
402         vector<QRectF> sampling_points[3];
403
404         int64_t sample_count = min(points_count, TracePaintBlockSize);
405         int64_t block_sample = 0;
406         float *sample_block = new float[TracePaintBlockSize];
407         segment->get_samples(start, start + sample_count, sample_block);
408
409         if (show_hover_marker_)
410                 reset_pixel_values();
411
412         const int w = 2;
413         for (int64_t sample = start; sample <= end; sample++, block_sample++) {
414
415                 // Fetch next block of samples if we finished the current one
416                 if (block_sample == TracePaintBlockSize) {
417                         block_sample = 0;
418                         sample_count = min(points_count - sample, TracePaintBlockSize);
419                         segment->get_samples(sample, sample + sample_count, sample_block);
420                 }
421
422                 const float abs_x = sample / samples_per_pixel - pixels_offset;
423                 const float x = left + abs_x;
424
425                 *point++ = QPointF(x, y - sample_block[block_sample] * scale_);
426
427                 // Generate the pixel<->value lookup table for the mouse hover
428                 if (show_hover_marker_)
429                         process_next_sample_value(abs_x, sample_block[block_sample]);
430
431                 // Create the sampling points if needed
432                 if (show_sampling_points) {
433                         int idx = 0;  // Neutral
434
435                         if (paint_thr_dots) {
436                                 if (thresholds.size() == 1)
437                                         idx = (sample_block[block_sample] >= thresholds[0]) ? 2 : 1;
438                                 else if (thresholds.size() == 2) {
439                                         if (sample_block[block_sample] > thresholds[1])
440                                                 idx = 2;  // High
441                                         else if (sample_block[block_sample] < thresholds[0])
442                                                 idx = 1;  // Low
443                                 }
444                         }
445
446                         sampling_points[idx].emplace_back(x - (w / 2), y - sample_block[block_sample] * scale_ - (w / 2), w, w);
447                 }
448         }
449         delete[] sample_block;
450
451         p.drawPolyline(points, points_count);
452
453         if (show_sampling_points) {
454                 if (paint_thr_dots) {
455                         p.setPen(SamplingPointColorNe);
456                         p.drawRects(sampling_points[0].data(), sampling_points[0].size());
457                         p.setPen(SamplingPointColorLo);
458                         p.drawRects(sampling_points[1].data(), sampling_points[1].size());
459                         p.setPen(SamplingPointColorHi);
460                         p.drawRects(sampling_points[2].data(), sampling_points[2].size());
461                 } else {
462                         p.setPen(SamplingPointColor);
463                         p.drawRects(sampling_points[0].data(), sampling_points[0].size());
464                 }
465         }
466
467         delete[] points;
468 }
469
470 void AnalogSignal::paint_envelope(QPainter &p,
471         const shared_ptr<pv::data::AnalogSegment> &segment,
472         int y, int left, const int64_t start, const int64_t end,
473         const double pixels_offset, const double samples_per_pixel)
474 {
475         using pv::data::AnalogSegment;
476
477         // Note: Envelope painting currently doesn't generate a pixel<->value lookup table
478         if (show_hover_marker_)
479                 reset_pixel_values();
480
481         AnalogSegment::EnvelopeSection e;
482         segment->get_envelope_section(e, start, end, samples_per_pixel);
483
484         if (e.length < 2)
485                 return;
486
487         p.setPen(QPen(Qt::NoPen));
488         p.setBrush(base_->color());
489
490         QRectF *const rects = new QRectF[e.length];
491         QRectF *rect = rects;
492
493         for (uint64_t sample = 0; sample < e.length - 1; sample++) {
494                 const float x = ((e.scale * sample + e.start) /
495                         samples_per_pixel - pixels_offset) + left;
496
497                 const AnalogSegment::EnvelopeSample *const s = e.samples + sample;
498
499                 // We overlap this sample with the next so that vertical
500                 // gaps do not appear during steep rising or falling edges
501                 const float b = y - max(s->max, (s + 1)->min) * scale_;
502                 const float t = y - min(s->min, (s + 1)->max) * scale_;
503
504                 float h = b - t;
505                 if (h >= 0.0f && h <= 1.0f)
506                         h = 1.0f;
507                 if (h <= 0.0f && h >= -1.0f)
508                         h = -1.0f;
509
510                 *rect++ = QRectF(x, t, 1.0f, h);
511         }
512
513         p.drawRects(rects, e.length);
514
515         delete[] rects;
516         delete[] e.samples;
517 }
518
519 void AnalogSignal::paint_logic_mid(QPainter &p, ViewItemPaintParams &pp)
520 {
521         QLineF *line;
522
523         vector< pair<int64_t, bool> > edges;
524
525         assert(base_);
526
527         const int y = get_visual_y();
528
529         if (!base_->enabled() || !base_->logic_data())
530                 return;
531
532         const int signal_margin =
533                 QFontMetrics(QApplication::font()).height() / 2;
534
535         const int ph = min(pos_vdivs_, 1) * div_height_;
536         const int nh = min(neg_vdivs_, 1) * div_height_;
537         const float high_offset = y - ph + signal_margin + 0.5f;
538         const float low_offset = y + nh - signal_margin - 0.5f;
539
540         shared_ptr<pv::data::LogicSegment> segment = get_logic_segment_to_paint();
541         if (!segment || (segment->get_sample_count() == 0))
542                 return;
543
544         double samplerate = segment->samplerate();
545
546         // Show sample rate as 1Hz when it is unknown
547         if (samplerate == 0.0)
548                 samplerate = 1.0;
549
550         const double pixels_offset = pp.pixels_offset();
551         const pv::util::Timestamp& start_time = segment->start_time();
552         const int64_t last_sample = (int64_t)segment->get_sample_count() - 1;
553         const double samples_per_pixel = samplerate * pp.scale();
554         const double pixels_per_sample = 1 / samples_per_pixel;
555         const pv::util::Timestamp start = samplerate * (pp.offset() - start_time);
556         const pv::util::Timestamp end = start + samples_per_pixel * pp.width();
557
558         const int64_t start_sample = min(max(floor(start).convert_to<int64_t>(),
559                 (int64_t)0), last_sample);
560         const uint64_t end_sample = min(max(ceil(end).convert_to<int64_t>(),
561                 (int64_t)0), last_sample);
562
563         segment->get_subsampled_edges(edges, start_sample, end_sample,
564                 samples_per_pixel / LogicSignal::Oversampling, 0);
565         assert(edges.size() >= 2);
566
567         // Check whether we need to paint the sampling points
568         GlobalSettings settings;
569         const bool show_sampling_points =
570                 settings.value(GlobalSettings::Key_View_ShowSamplingPoints).toBool() &&
571                 (samples_per_pixel < 0.25);
572
573         vector<QRectF> sampling_points;
574         float sampling_point_x = 0.0f;
575         int64_t sampling_point_sample = start_sample;
576         const int w = 2;
577
578         if (show_sampling_points) {
579                 sampling_points.reserve(end_sample - start_sample + 1);
580                 sampling_point_x = (edges.cbegin()->first / samples_per_pixel - pixels_offset) + pp.left();
581         }
582
583         // Paint the edges
584         const unsigned int edge_count = edges.size() - 2;
585         QLineF *const edge_lines = new QLineF[edge_count];
586         line = edge_lines;
587
588         for (auto i = edges.cbegin() + 1; i != edges.cend() - 1; i++) {
589                 const float x = ((*i).first / samples_per_pixel -
590                         pixels_offset) + pp.left();
591                 *line++ = QLineF(x, high_offset, x, low_offset);
592
593                 if (show_sampling_points)
594                         while (sampling_point_sample < (*i).first) {
595                                 const float y = (*i).second ? low_offset : high_offset;
596                                 sampling_points.emplace_back(
597                                         QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
598                                 sampling_point_sample++;
599                                 sampling_point_x += pixels_per_sample;
600                         };
601         }
602
603         // Calculate the sample points from the last edge to the end of the trace
604         if (show_sampling_points)
605                 while ((uint64_t)sampling_point_sample <= end_sample) {
606                         // Signal changed after the last edge, so the level is inverted
607                         const float y = (edges.cend() - 1)->second ? high_offset : low_offset;
608                         sampling_points.emplace_back(
609                                 QRectF(sampling_point_x - (w / 2), y - (w / 2), w, w));
610                         sampling_point_sample++;
611                         sampling_point_x += pixels_per_sample;
612                 };
613
614         p.setPen(LogicSignal::EdgeColor);
615         p.drawLines(edge_lines, edge_count);
616         delete[] edge_lines;
617
618         // Paint the caps
619         const unsigned int max_cap_line_count = edges.size();
620         QLineF *const cap_lines = new QLineF[max_cap_line_count];
621
622         p.setPen(LogicSignal::HighColor);
623         paint_logic_caps(p, cap_lines, edges, true, samples_per_pixel,
624                 pixels_offset, pp.left(), high_offset);
625         p.setPen(LogicSignal::LowColor);
626         paint_logic_caps(p, cap_lines, edges, false, samples_per_pixel,
627                 pixels_offset, pp.left(), low_offset);
628
629         delete[] cap_lines;
630
631         // Paint the sampling points
632         if (show_sampling_points) {
633                 p.setPen(SamplingPointColor);
634                 p.drawRects(sampling_points.data(), sampling_points.size());
635         }
636 }
637
638 void AnalogSignal::paint_logic_caps(QPainter &p, QLineF *const lines,
639         vector< pair<int64_t, bool> > &edges, bool level,
640         double samples_per_pixel, double pixels_offset, float x_offset,
641         float y_offset)
642 {
643         QLineF *line = lines;
644
645         for (auto i = edges.begin(); i != (edges.end() - 1); i++)
646                 if ((*i).second == level) {
647                         *line++ = QLineF(
648                                 ((*i).first / samples_per_pixel -
649                                         pixels_offset) + x_offset, y_offset,
650                                 ((*(i+1)).first / samples_per_pixel -
651                                         pixels_offset) + x_offset, y_offset);
652                 }
653
654         p.drawLines(lines, line - lines);
655 }
656
657 shared_ptr<pv::data::AnalogSegment> AnalogSignal::get_analog_segment_to_paint() const
658 {
659         shared_ptr<pv::data::AnalogSegment> segment;
660
661         const deque< shared_ptr<pv::data::AnalogSegment> > &segments =
662                 base_->analog_data()->analog_segments();
663
664         if (!segments.empty()) {
665                 if (segment_display_mode_ == ShowLastSegmentOnly)
666                         segment = segments.back();
667
668                 if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
669                                 (segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
670                         try {
671                                 segment = segments.at(current_segment_);
672                         } catch (out_of_range&) {
673                                 qDebug() << "Current analog segment out of range for signal" << base_->name() << ":" << current_segment_;
674                         }
675                 }
676         }
677
678         return segment;
679 }
680
681 shared_ptr<pv::data::LogicSegment> AnalogSignal::get_logic_segment_to_paint() const
682 {
683         shared_ptr<pv::data::LogicSegment> segment;
684
685         const deque< shared_ptr<pv::data::LogicSegment> > &segments =
686                 base_->logic_data()->logic_segments();
687
688         if (!segments.empty()) {
689                 if (segment_display_mode_ == ShowLastSegmentOnly)
690                         segment = segments.back();
691
692                 if ((segment_display_mode_ == ShowSingleSegmentOnly) ||
693                                 (segment_display_mode_ == ShowLastCompleteSegmentOnly)) {
694                         try {
695                                 segment = segments.at(current_segment_);
696                         } catch (out_of_range&) {
697                                 qDebug() << "Current logic segment out of range for signal" << base_->name() << ":" << current_segment_;
698                         }
699                 }
700         }
701
702         return segment;
703 }
704
705 float AnalogSignal::get_resolution(int scale_index)
706 {
707         const float seq[] = {1.0f, 2.0f, 5.0f};
708
709         const int offset = numeric_limits<int>::max() / (2 * countof(seq));
710         const div_t d = div((int)(scale_index + countof(seq) * offset),
711                 countof(seq));
712
713         return powf(10.0f, d.quot - offset) * seq[d.rem];
714 }
715
716 void AnalogSignal::update_scale()
717 {
718         resolution_ = get_resolution(scale_index_);
719         scale_ = div_height_ / resolution_;
720 }
721
722 void AnalogSignal::update_conversion_widgets()
723 {
724         SignalBase::ConversionType conv_type = base_->get_conversion_type();
725
726         // Enable or disable widgets depending on conversion state
727         conv_threshold_cb_->setEnabled(conv_type != SignalBase::NoConversion);
728         display_type_cb_->setEnabled(conv_type != SignalBase::NoConversion);
729
730         conv_threshold_cb_->clear();
731
732         vector < pair<QString, int> > presets = base_->get_conversion_presets();
733
734         // Prevent the combo box from firing the "edit text changed" signal
735         // as that would involuntarily select the first entry
736         conv_threshold_cb_->blockSignals(true);
737
738         // Set available options depending on chosen conversion
739         for (pair<QString, int> preset : presets)
740                 conv_threshold_cb_->addItem(preset.first, preset.second);
741
742         map < QString, QVariant > options = base_->get_conversion_options();
743
744         if (conv_type == SignalBase::A2LConversionByThreshold) {
745                 const vector<double> thresholds = base_->get_conversion_thresholds(
746                                 SignalBase::A2LConversionByThreshold, true);
747                 conv_threshold_cb_->addItem(
748                                 QString("%1V").arg(QString::number(thresholds[0], 'f', 1)), -1);
749         }
750
751         if (conv_type == SignalBase::A2LConversionBySchmittTrigger) {
752                 const vector<double> thresholds = base_->get_conversion_thresholds(
753                                 SignalBase::A2LConversionBySchmittTrigger, true);
754                 conv_threshold_cb_->addItem(QString("%1V/%2V").arg(
755                                 QString::number(thresholds[0], 'f', 1),
756                                 QString::number(thresholds[1], 'f', 1)), -1);
757         }
758
759         int preset_id = base_->get_current_conversion_preset();
760         conv_threshold_cb_->setCurrentIndex(
761                         conv_threshold_cb_->findData(preset_id));
762
763         conv_threshold_cb_->blockSignals(false);
764 }
765
766 void AnalogSignal::perform_autoranging(bool keep_divs, bool force_update)
767 {
768         const deque< shared_ptr<pv::data::AnalogSegment> > &segments =
769                 base_->analog_data()->analog_segments();
770
771         if (segments.empty())
772                 return;
773
774         static double prev_min = 0, prev_max = 0;
775         double min = 0, max = 0;
776
777         for (shared_ptr<pv::data::AnalogSegment> segment : segments) {
778                 pair<double, double> mm = segment->get_min_max();
779                 min = std::min(min, mm.first);
780                 max = std::max(max, mm.second);
781         }
782
783         if ((min == prev_min) && (max == prev_max) && !force_update)
784                 return;
785
786         prev_min = min;
787         prev_max = max;
788
789         // If we're allowed to alter the div assignment...
790         if (!keep_divs) {
791                 // Use all divs for the positive range if there are no negative values
792                 if ((min == 0) && (neg_vdivs_ > 0)) {
793                         pos_vdivs_ += neg_vdivs_;
794                         neg_vdivs_ = 0;
795                 }
796
797                 // Split up the divs if there are negative values but no negative divs
798                 if ((min < 0) && (neg_vdivs_ == 0)) {
799                         neg_vdivs_ = pos_vdivs_ / 2;
800                         pos_vdivs_ -= neg_vdivs_;
801                 }
802         }
803
804         // If there is still no positive div when we need it, add one
805         // (this can happen when pos_vdivs==neg_vdivs==0)
806         if ((max > 0) && (pos_vdivs_ == 0)) {
807                 pos_vdivs_ = 1;
808                 owner_->extents_changed(false, true);
809         }
810
811         // If there is still no negative div when we need it, add one
812         // (this can happen when pos_vdivs was 0 or 1 when trying to split)
813         if ((min < 0) && (neg_vdivs_ == 0)) {
814                 neg_vdivs_ = 1;
815                 owner_->extents_changed(false, true);
816         }
817
818         double min_value_per_div;
819         if ((pos_vdivs_ > 0) && (neg_vdivs_ >  0))
820                 min_value_per_div = std::max(max / pos_vdivs_, -min / neg_vdivs_);
821         else if (pos_vdivs_ > 0)
822                 min_value_per_div = max / pos_vdivs_;
823         else
824                 min_value_per_div = -min / neg_vdivs_;
825
826         // Find first scale value that is bigger than the value we need
827         for (int i = MinScaleIndex; i < MaxScaleIndex; i++)
828                 if (get_resolution(i) > min_value_per_div) {
829                         scale_index_ = i;
830                         break;
831                 }
832
833         update_scale();
834 }
835
836 void AnalogSignal::reset_pixel_values()
837 {
838         value_at_pixel_pos_.clear();
839         current_pixel_pos_ = -1;
840         prev_value_at_pixel_ = std::numeric_limits<float>::quiet_NaN();
841 }
842
843 void AnalogSignal::process_next_sample_value(float x, float value)
844 {
845         // Note: NAN is used to indicate the non-existance of a value at this pixel
846
847         if (std::isnan(prev_value_at_pixel_)) {
848                 if (x < 0) {
849                         min_value_at_pixel_ = value;
850                         max_value_at_pixel_ = value;
851                         prev_value_at_pixel_ = value;
852                         current_pixel_pos_ = x;
853                 } else
854                         prev_value_at_pixel_ = std::numeric_limits<float>::quiet_NaN();
855         }
856
857         const int pixel_pos = (int)(x + 0.5);
858
859         if (pixel_pos > current_pixel_pos_) {
860                 if (pixel_pos - current_pixel_pos_ == 1) {
861                         if (std::isnan(prev_value_at_pixel_)) {
862                                 value_at_pixel_pos_.push_back(prev_value_at_pixel_);
863                         } else {
864                                 // Average the min/max range to create one value for the previous pixel
865                                 const float avg = (min_value_at_pixel_ + max_value_at_pixel_) / 2;
866                                 value_at_pixel_pos_.push_back(avg);
867                         }
868                 } else {
869                         // Interpolate values to create values for the intermediate pixels
870                         const float start_value = prev_value_at_pixel_;
871                         const float end_value = value;
872                         const int steps = fabs(pixel_pos - current_pixel_pos_);
873                         const double gradient = (end_value - start_value) / steps;
874                         for (int i = 0; i < steps; i++) {
875                                 if (current_pixel_pos_ + i < 0)
876                                         continue;
877                                 value_at_pixel_pos_.push_back(start_value + i * gradient);
878                         }
879                 }
880
881                 min_value_at_pixel_ = value;
882                 max_value_at_pixel_ = value;
883                 prev_value_at_pixel_ = value;
884                 current_pixel_pos_ = pixel_pos;
885         } else {
886                 // Another sample for the same pixel
887                 if (value < min_value_at_pixel_)
888                         min_value_at_pixel_ = value;
889                 if (value > max_value_at_pixel_)
890                         max_value_at_pixel_ = value;
891         }
892 }
893
894 void AnalogSignal::populate_popup_form(QWidget *parent, QFormLayout *form)
895 {
896         // Add the standard options
897         Signal::populate_popup_form(parent, form);
898
899         QFormLayout *const layout = new QFormLayout;
900
901         // Add div-related settings
902         pvdiv_sb_ = new QSpinBox(parent);
903         pvdiv_sb_->setRange(0, MaximumVDivs);
904         pvdiv_sb_->setValue(pos_vdivs_);
905         connect(pvdiv_sb_, SIGNAL(valueChanged(int)),
906                 this, SLOT(on_pos_vdivs_changed(int)));
907         layout->addRow(tr("Number of pos vertical divs"), pvdiv_sb_);
908
909         nvdiv_sb_ = new QSpinBox(parent);
910         nvdiv_sb_->setRange(0, MaximumVDivs);
911         nvdiv_sb_->setValue(neg_vdivs_);
912         connect(nvdiv_sb_, SIGNAL(valueChanged(int)),
913                 this, SLOT(on_neg_vdivs_changed(int)));
914         layout->addRow(tr("Number of neg vertical divs"), nvdiv_sb_);
915
916         div_height_sb_ = new QSpinBox(parent);
917         div_height_sb_->setRange(20, 1000);
918         div_height_sb_->setSingleStep(5);
919         div_height_sb_->setSuffix(tr(" pixels"));
920         div_height_sb_->setValue(div_height_);
921         connect(div_height_sb_, SIGNAL(valueChanged(int)),
922                 this, SLOT(on_div_height_changed(int)));
923         layout->addRow(tr("Div height"), div_height_sb_);
924
925         // Add the vertical resolution
926         resolution_cb_ = new QComboBox(parent);
927
928         for (int i = MinScaleIndex; i < MaxScaleIndex; i++) {
929                 const QString label = QString("%1").arg(get_resolution(i));
930                 resolution_cb_->insertItem(0, label, QVariant(i));
931         }
932
933         int cur_idx = resolution_cb_->findData(QVariant(scale_index_));
934         resolution_cb_->setCurrentIndex(cur_idx);
935
936         connect(resolution_cb_, SIGNAL(currentIndexChanged(int)),
937                 this, SLOT(on_resolution_changed(int)));
938
939         QGridLayout *const vdiv_layout = new QGridLayout;
940         QLabel *const vdiv_unit = new QLabel(tr("V/div"));
941         vdiv_layout->addWidget(resolution_cb_, 0, 0);
942         vdiv_layout->addWidget(vdiv_unit, 0, 1);
943
944         layout->addRow(tr("Vertical resolution"), vdiv_layout);
945
946         // Add the autoranging checkbox
947         QCheckBox* autoranging_cb = new QCheckBox();
948         autoranging_cb->setCheckState(autoranging_ ? Qt::Checked : Qt::Unchecked);
949
950         connect(autoranging_cb, SIGNAL(stateChanged(int)),
951                 this, SLOT(on_autoranging_changed(int)));
952
953         layout->addRow(tr("Autoranging"), autoranging_cb);
954
955         // Add the conversion type dropdown
956         conversion_cb_ = new QComboBox();
957
958         conversion_cb_->addItem(tr("none"),
959                 SignalBase::NoConversion);
960         conversion_cb_->addItem(tr("to logic via threshold"),
961                 SignalBase::A2LConversionByThreshold);
962         conversion_cb_->addItem(tr("to logic via schmitt-trigger"),
963                 SignalBase::A2LConversionBySchmittTrigger);
964
965         cur_idx = conversion_cb_->findData(QVariant(base_->get_conversion_type()));
966         conversion_cb_->setCurrentIndex(cur_idx);
967
968         layout->addRow(tr("Conversion"), conversion_cb_);
969
970         connect(conversion_cb_, SIGNAL(currentIndexChanged(int)),
971                 this, SLOT(on_conversion_changed(int)));
972
973     // Add the conversion threshold settings
974     conv_threshold_cb_ = new QComboBox();
975     conv_threshold_cb_->setEditable(true);
976
977     layout->addRow(tr("Conversion threshold(s)"), conv_threshold_cb_);
978
979     connect(conv_threshold_cb_, SIGNAL(currentIndexChanged(int)),
980             this, SLOT(on_conv_threshold_changed(int)));
981     connect(conv_threshold_cb_, SIGNAL(editTextChanged(const QString&)),
982             this, SLOT(on_conv_threshold_changed()));  // index will be -1
983
984         // Add the display type dropdown
985         display_type_cb_ = new QComboBox();
986
987         display_type_cb_->addItem(tr("analog"), DisplayAnalog);
988         display_type_cb_->addItem(tr("converted"), DisplayConverted);
989         display_type_cb_->addItem(tr("analog+converted"), DisplayBoth);
990
991         cur_idx = display_type_cb_->findData(QVariant(display_type_));
992         display_type_cb_->setCurrentIndex(cur_idx);
993
994         layout->addRow(tr("Show traces for"), display_type_cb_);
995
996         connect(display_type_cb_, SIGNAL(currentIndexChanged(int)),
997                 this, SLOT(on_display_type_changed(int)));
998
999         // Update the conversion widget contents and states
1000         update_conversion_widgets();
1001
1002         form->addRow(layout);
1003 }
1004
1005 void AnalogSignal::hover_point_changed(const QPoint &hp)
1006 {
1007         Signal::hover_point_changed(hp);
1008
1009         // Note: Even though the view area begins at 0, we exclude 0 because
1010         // that's also the value given when the cursor is over the header to the
1011         // left of the trace paint area
1012         if (hp.x() <= 0) {
1013                 value_at_hover_pos_ = std::numeric_limits<float>::quiet_NaN();
1014         } else {
1015                 try {
1016                         value_at_hover_pos_ = value_at_pixel_pos_.at(hp.x());
1017                 } catch (out_of_range&) {
1018                         value_at_hover_pos_ = std::numeric_limits<float>::quiet_NaN();
1019                 }
1020         }
1021 }
1022
1023 void AnalogSignal::on_min_max_changed(float min, float max)
1024 {
1025         (void)min;
1026         (void)max;
1027
1028         if (autoranging_)
1029                 perform_autoranging(false, false);
1030 }
1031
1032 void AnalogSignal::on_pos_vdivs_changed(int vdivs)
1033 {
1034         if (vdivs == pos_vdivs_)
1035                 return;
1036
1037         pos_vdivs_ = vdivs;
1038
1039         // There has to be at least one div, positive or negative
1040         if ((neg_vdivs_ == 0) && (pos_vdivs_ == 0)) {
1041                 pos_vdivs_ = 1;
1042                 if (pvdiv_sb_)
1043                         pvdiv_sb_->setValue(pos_vdivs_);
1044         }
1045
1046         if (autoranging_) {
1047                 perform_autoranging(true, true);
1048
1049                 // It could be that a positive or negative div was added, so update
1050                 if (pvdiv_sb_) {
1051                         pvdiv_sb_->setValue(pos_vdivs_);
1052                         nvdiv_sb_->setValue(neg_vdivs_);
1053                 }
1054         }
1055
1056         if (owner_) {
1057                 // Call order is important, otherwise the lazy event handler won't work
1058                 owner_->extents_changed(false, true);
1059                 owner_->row_item_appearance_changed(false, true);
1060         }
1061 }
1062
1063 void AnalogSignal::on_neg_vdivs_changed(int vdivs)
1064 {
1065         if (vdivs == neg_vdivs_)
1066                 return;
1067
1068         neg_vdivs_ = vdivs;
1069
1070         // There has to be at least one div, positive or negative
1071         if ((neg_vdivs_ == 0) && (pos_vdivs_ == 0)) {
1072                 pos_vdivs_ = 1;
1073                 if (pvdiv_sb_)
1074                         pvdiv_sb_->setValue(pos_vdivs_);
1075         }
1076
1077         if (autoranging_) {
1078                 perform_autoranging(true, true);
1079
1080                 // It could be that a positive or negative div was added, so update
1081                 if (pvdiv_sb_) {
1082                         pvdiv_sb_->setValue(pos_vdivs_);
1083                         nvdiv_sb_->setValue(neg_vdivs_);
1084                 }
1085         }
1086
1087         if (owner_) {
1088                 // Call order is important, otherwise the lazy event handler won't work
1089                 owner_->extents_changed(false, true);
1090                 owner_->row_item_appearance_changed(false, true);
1091         }
1092 }
1093
1094 void AnalogSignal::on_div_height_changed(int height)
1095 {
1096         div_height_ = height;
1097         update_scale();
1098
1099         if (owner_) {
1100                 // Call order is important, otherwise the lazy event handler won't work
1101                 owner_->extents_changed(false, true);
1102                 owner_->row_item_appearance_changed(false, true);
1103         }
1104 }
1105
1106 void AnalogSignal::on_resolution_changed(int index)
1107 {
1108         scale_index_ = resolution_cb_->itemData(index).toInt();
1109         update_scale();
1110
1111         if (owner_)
1112                 owner_->row_item_appearance_changed(false, true);
1113 }
1114
1115 void AnalogSignal::on_autoranging_changed(int state)
1116 {
1117         autoranging_ = (state == Qt::Checked);
1118
1119         if (autoranging_)
1120                 perform_autoranging(false, true);
1121
1122         if (owner_) {
1123                 // Call order is important, otherwise the lazy event handler won't work
1124                 owner_->extents_changed(false, true);
1125                 owner_->row_item_appearance_changed(false, true);
1126         }
1127 }
1128
1129 void AnalogSignal::on_conversion_changed(int index)
1130 {
1131         SignalBase::ConversionType old_conv_type = base_->get_conversion_type();
1132
1133         SignalBase::ConversionType conv_type =
1134                 (SignalBase::ConversionType)(conversion_cb_->itemData(index).toInt());
1135
1136         if (conv_type != old_conv_type) {
1137                 base_->set_conversion_type(conv_type);
1138                 update_conversion_widgets();
1139
1140                 if (owner_)
1141                         owner_->row_item_appearance_changed(false, true);
1142         }
1143 }
1144
1145 void AnalogSignal::on_conv_threshold_changed(int index)
1146 {
1147         SignalBase::ConversionType conv_type = base_->get_conversion_type();
1148
1149         // Note: index is set to -1 if the text in the combo box matches none of
1150         // the entries in the combo box
1151
1152         if ((index == -1) && (conv_threshold_cb_->currentText().length() == 0))
1153                 return;
1154
1155         // The combo box entry with the custom value has user_data set to -1
1156         const int user_data = conv_threshold_cb_->findText(
1157                         conv_threshold_cb_->currentText());
1158
1159         const bool use_custom_thr = (index == -1) || (user_data == -1);
1160
1161         if (conv_type == SignalBase::A2LConversionByThreshold && use_custom_thr) {
1162                 // Not one of the preset values, try to parse the combo box text
1163                 // Note: Regex loosely based on
1164                 // https://txt2re.com/index-c++.php3?s=0.1V&1&-13
1165                 QString re1 = "([+-]?\\d*[\\.,]?\\d*)"; // Float value
1166                 QString re2 = "([a-zA-Z]*)"; // SI unit
1167                 QRegExp regex(re1 + re2);
1168
1169                 const QString text = conv_threshold_cb_->currentText();
1170                 if (!regex.exactMatch(text))
1171                         return;  // String doesn't match the regex
1172
1173                 QStringList tokens = regex.capturedTexts();
1174
1175                 // For now, we simply assume that the unit is volt without modifiers
1176                 const double thr = tokens.at(1).toDouble();
1177
1178                 // Only restart the conversion if the threshold was updated.
1179                 // We're starting a delayed conversion because the user may still be
1180                 // typing and the UI would lag if we kept on restarting it immediately
1181                 if (base_->set_conversion_option("threshold_value", thr))
1182                         base_->start_conversion(true);
1183         }
1184
1185         if (conv_type == SignalBase::A2LConversionBySchmittTrigger && use_custom_thr) {
1186                 // Not one of the preset values, try to parse the combo box text
1187                 // Note: Regex loosely based on
1188                 // https://txt2re.com/index-c++.php3?s=0.1V/0.2V&2&14&-22&3&15
1189                 QString re1 = "([+-]?\\d*[\\.,]?\\d*)"; // Float value
1190                 QString re2 = "([a-zA-Z]*)"; // SI unit
1191                 QString re3 = "\\/"; // Forward slash, not captured
1192                 QString re4 = "([+-]?\\d*[\\.,]?\\d*)"; // Float value
1193                 QString re5 = "([a-zA-Z]*)"; // SI unit
1194                 QRegExp regex(re1 + re2 + re3 + re4 + re5);
1195
1196                 const QString text = conv_threshold_cb_->currentText();
1197                 if (!regex.exactMatch(text))
1198                         return;  // String doesn't match the regex
1199
1200                 QStringList tokens = regex.capturedTexts();
1201
1202                 // For now, we simply assume that the unit is volt without modifiers
1203                 const double low_thr = tokens.at(1).toDouble();
1204                 const double high_thr = tokens.at(3).toDouble();
1205
1206                 // Only restart the conversion if one of the options was updated.
1207                 // We're starting a delayed conversion because the user may still be
1208                 // typing and the UI would lag if we kept on restarting it immediately
1209                 bool o1 = base_->set_conversion_option("threshold_value_low", low_thr);
1210                 bool o2 = base_->set_conversion_option("threshold_value_high", high_thr);
1211                 if (o1 || o2)
1212                         base_->start_conversion(true);  // Start delayed conversion
1213         }
1214
1215         base_->set_conversion_preset((SignalBase::ConversionPreset)index);
1216
1217         // Immediately start the conversion if we're not using custom values
1218         // (i.e. we're using one of the presets)
1219         if (!use_custom_thr)
1220                 base_->start_conversion();
1221 }
1222
1223 void AnalogSignal::on_delayed_conversion_starter()
1224 {
1225         base_->start_conversion();
1226 }
1227
1228 void AnalogSignal::on_display_type_changed(int index)
1229 {
1230         display_type_ = (DisplayType)(display_type_cb_->itemData(index).toInt());
1231
1232         if (owner_)
1233                 owner_->row_item_appearance_changed(false, true);
1234 }
1235
1236 void AnalogSignal::on_settingViewConversionThresholdDispMode_changed(const QVariant new_value)
1237 {
1238         conversion_threshold_disp_mode_ = new_value.toInt();
1239
1240         if (owner_)
1241                 owner_->row_item_appearance_changed(false, true);
1242 }
1243
1244 } // namespace trace
1245 } // namespace views
1246 } // namespace pv